Skip to contentSkip to conversation

NAND: show manufacturer and device ID for unknown chips

PATCH New Scott Wood 2 participants 2 messages Jun 23, 2010 – Jun 24, 2010

Subsystems (2)
lore
Share & tools
lore

Scott Wood

author
#0 lore raw

PATCH v2 1/1 NAND: show manufacturer and device ID for unknown chips

From: Florian Fainelli <[email protected]>

When the NAND part is not supported, it is useful to show the manufacturer and device ID to help debugging and reporting.

---
Whitespace amended to be consistent with rest of file.

Applied to u-boot-nand-flash next.

 drivers/mtd/nand/nand_base.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
drivers/mtd/nand/nand_base.c +5 -1
index 7171bdd..ed1c9c9 100644
@@ -2652,8 +2652,12 @@ static struct nand_flash_dev *nand_get_flash_type(struct mtd_info *mtd,
 		}
 	}
 
-	if (!type)
+	if (!type) {
+		printk(KERN_INFO "%s: unknown NAND device: Manufacturer ID:"
+		       " 0x%02x, Chip ID: 0x%02x\n", __func__,
+		       *maf_id, dev_id);
 		return ERR_PTR(-ENODEV);
+	}
 
 	if (!mtd->name)
 		mtd->name = type->name;
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH v2 1/1 NAND: show manufacturer and device ID for unknown chips

Hey Scott,

Quoted 9 lines · On Wednesday 23 June 2010 23:53:01 Scott Wood wrote:

From: Florian Fainelli <[email protected]>

When the NAND part is not supported, it is useful to show the manufacturer and device ID to help debugging and reporting.

---
Whitespace amended to be consistent with rest of file.

Thanks, I was just about to respin it.

Quoted 24 lines

Applied to u-boot-nand-flash next.

 drivers/mtd/nand/nand_base.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
drivers/mtd/nand/nand_base.c +5 -1
index 7171bdd..ed1c9c9 100644
@@ -2652,8 +2652,12 @@ static struct nand_flash_dev
 *nand_get_flash_type(struct mtd_info *mtd, }
 	}
 
-	if (!type)
+	if (!type) {
+		printk(KERN_INFO "%s: unknown NAND device: Manufacturer ID:"
+		       " 0x%02x, Chip ID: 0x%02x\n", __func__,
+		       *maf_id, dev_id);
 		return ERR_PTR(-ENODEV);
+	}
 
 	if (!mtd->name)
 		mtd->name = type->name;