NAND: show manufacturer and device ID for unknown chips
Subsystems (2)
PATCH 1/2 NAND: show manufacturer and device ID for unknown chips
When the NAND part is not supported, it is useful to show the manufacturer and device ID to help debugging and reporting.
---
drivers/mtd/nand/nand_base.c +5 -1
@@ -2652,8 +2652,12 @@ static struct nand_flash_dev *nand_get_flash_type(struct mtd_info *mtd, } } -if (!type) +if (!type) { +printk (KERN_INFO "%s: unknown NAND device: Manufacturer ID :" +" 0x%02x, Chip ID: 0x%02x\n" , __func__, + *maf_id, dev_id);return ERR_PTR (-ENODEV ); + }if (!mtd->name) mtd->name = type->name;
PATCH 1/2 NAND: show manufacturer and device ID for unknown chips
Le Saturday 12 June 2010 20:59:25, Florian Fainelli a ?crit :
Quoted 4 lines
When the NAND part is not supported, it is useful to show the manufacturer and device ID to help debugging and reporting.
Signed-off-by Florian Fainelli <[email protected]>
Scott, anything from with the patch? Thanks!
Quoted 19 lines
---
drivers/mtd/nand/nand_base.c +5
-1@@ -2652,8 +2652,12 @@ static struct nand_flash_dev *nand_get_flash_type(struct mtd_info *mtd, } } - if (!type) + if (!type) { + printk(KERN_INFO "%s: unknown NAND device: Manufacturer ID :" + " 0x%02x, Chip ID: 0x%02x\n", __func__, + *maf_id, dev_id); return ERR_PTR(-ENODEV); + } if (!mtd->name) mtd->name = type->name;
Signature · 1 line
Florian
PATCH 1/2 NAND: show manufacturer and device ID for unknown chips
Quoted 7 lines · Florian Fainelli
Le Saturday 12 June 2010 20:59:25, Florian Fainelli a ?crit :
Quoted 4 lines
When the NAND part is not supported, it is useful to show the manufacturer and device ID to help debugging and reporting.
Signed-off-by Florian Fainelli <[email protected]>Scott, anything from with the patch? Thanks!
I just got back from vacation, but the patches look reasonable.
Quoted 9 lines
Quoted 9 lines
---
drivers/mtd/nand/nand_base.c +0
-0@@ -2652,8 +2652,12 @@ static struct nand_flash_dev *nand_get_flash_type(struct mtd_info *mtd, } }
Quoted 3 lines
drivers/mtd/nand/nand_base.c static struct nand_flash_dev *nand_get_flash_type(struct mtd_info *mtd, · line 2656
Quoted 3 lines
drivers/mtd/nand/nand_base.c +2
-1-if (!type) +if (!type) { + printk(KERN_INFO "%s: unknown NAND device: Manufacturer ID :"
I'd leave out the space before the colon ("foo: bar", not "foo : bar"), though. I think that may be a regional style issue, but let's stick with what the rest of the code does.
-Scott