Bash completion script for grub util commands

---
 ChangeLog.completion.bash                        |    3 
 Makefile.in                                      |    4 
 util/integration/completion/grub-completion.bash |  450 ++++++++++++++++++++++
 3 files changed, 457 insertions(+), 0 deletions(-)
 create mode 100644 ChangeLog.completion.bash
 create mode 100644 util/integration/completion/grub-completion.bash

new file mode 100644
index 0000000..8b1fea9
@@ -0,0 +1,3 @@
+2010-08-11  Yves Blusseau  <[email protected]>
+
+	* util/integration/completion/grub-completion.bash: New script

index 39061be..53b1ecd 100644
@@ -366,6 +366,10 @@ install-local: all
 	  dest="`echo $$file | sed 's,.*/,,' | sed '$(transform)'`"; \
 	  $(INSTALL_DATA) $$dir$$file $(DESTDIR)$(sysconfdir)/grub.d/$$dest; \
 	done
+	$(SHELL) $(mkinstalldirs) $(DESTDIR)$(sysconfdir)/bash_completion.d
+	@file="grub-completion.bash"; dest="grub"; \
+	  if test -f "$$file"; then dir=; else dir="$(srcdir)/util/integration/completion/"; fi; \
+	  $(INSTALL_DATA) $$dir$$file $(DESTDIR)$(sysconfdir)/bash_completion.d/$$dest
 	$(SHELL) $(mkinstalldirs) $(DESTDIR)$(libdir)/grub
 	@list='$(lib_SCRIPTS)'; \
 	for file in $$list; do \

20:59 <phcoder> cjwatson: is it convenient to install bash_completion scripts in non-bash package?

At least from this point of view, sure, I don't see a problem. I think perhaps util/integration/completion/grub-completion.bash is unnecessarily deep nesting in the source tree though; creating two levels of subdirectory at once seems a bit much. If it were me I'd probably put it in util/bash-completion.d/grub. (Also, I think the bikeshed should be pink.)

Colin Watson                                       [[email protected]]