i915, drm: Fix build dependency on VGA_ARB
Subsystems (2)
PATCH 1/1 i915, drm: Fix build dependency on VGA_ARB
I get:
LD init/built-in.o
LD .tmp_vmlinux1drivers/built-in.o: In function `intel_modeset_init':
(.text+0xa993f): undefined reference to vga_get' drivers/built-in.o: In function intel_modeset_init':
(.text+0xa9963): undefined reference to `vga_put'
make: *** [.tmp_vmlinux1] Error 1
since CONFIG_AGB_ARB is not being selected. Make I915 driver select it as the numerous other things it selects.
---
This is on latest Linus git (v2.6.36-rc2-237-gd4348c6) after doing `make oldconfig' on an Acer Aspire One netbook.
drivers/gpu/drm/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/gpu/drm/Kconfig +1 -0
@@ -97,6 +97,7 @@ config DRM_I830 config DRM_I915 tristate "i915 driver" depends on AGP_INTEL + select VGA_ARB select SHMEM select DRM_KMS_HELPER select FB_CFB_FILLRECT
Signature · 6 lines
1.7.1 -- Regards/Gruss, Boris.
Quoted 27 lines · Borislav Petkov
I get:
LD
init/built-in.o
LD .tmp_vmlinux1drivers/built-in.o: In function `intel_modeset_init':
(.text+0xa993f): undefined reference tovga_get' drivers/built-in.o: In functionintel_modeset_init':
(.text+0xa9963): undefined reference to `vga_put'
make: *** [.tmp_vmlinux1] Error 1since
CONFIG_AGB_ARBis not being selected. Make I915 driver select it as the numerous other things it selects.Signed-off-by Borislav Petkov <[email protected]>---
This is on latest Linus git (v2.6.36-rc2-237-gd4348c6) after doing `make oldconfig' on an Acer Aspire One netbook.
drivers/gpu/drm/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)drivers/gpu/drm/Kconfig +0
-0
drivers/gpu/drm/Kconfig config DRM_I830 · line 103
Quoted 7 lines
drivers/gpu/drm/Kconfig +1
-0@@ -97,6 +97,7 @@ config DRM_I830 config DRM_I915 tristate "i915 driver" depends on AGP_INTEL + select VGA_ARB select SHMEM select DRM_KMS_HELPER select FB_CFB_FILLRECT
I reported this build failure here:
http://lkml.org/lkml/2010/8/23/127
Is there no other way to fix this? From the Kconfig description of VGA_ARB I thought I would not need this (and it's a new thing too), so why make my kernel bigger so easily?
Quoted 38 lines · Carlos R. Mafra
Quoted 27 lines · Borislav Petkov
I get:
LD
init/built-in.o
LD .tmp_vmlinux1drivers/built-in.o: In function `intel_modeset_init':
(.text+0xa993f): undefined reference tovga_get' drivers/built-in.o: In functionintel_modeset_init':
(.text+0xa9963): undefined reference to `vga_put'
make: *** [.tmp_vmlinux1] Error 1since
CONFIG_AGB_ARBis not being selected. Make I915 driver select it as the numerous other things it selects.Signed-off-by Borislav Petkov <[email protected]>---
This is on latest Linus git (v2.6.36-rc2-237-gd4348c6) after doing `make oldconfig' on an Acer Aspire One netbook.
drivers/gpu/drm/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)drivers/gpu/drm/Kconfig +0
-0drivers/gpu/drm/Kconfig config DRM_I830 · line 103
Quoted 7 lines
drivers/gpu/drm/Kconfig +1
-0@@ -97,6 +97,7 @@ config DRM_I830 config DRM_I915 tristate "i915 driver" depends on AGP_INTEL + select VGA_ARB select SHMEM select DRM_KMS_HELPER select FB_CFB_FILLRECTI reported this build failure here:
Quoted 5 lines
http://lkml.org/lkml/2010/8/23/127
Is there no other way to fix this? From the
Kconfigdescription ofVGA_ARBI thought I would not need this (and it's a new thing too), so why make my kernel bigger so easily?
<linux/vgaarb.h> should define dummy inline functions if CONFIG_VGA_ARB is not defined. It already does this for vga_client_register() but should cover the other functions as well.
Ben.
Signature · 3 lines
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
- Albert CamusFrom: Ben Hutchings <[email protected]>
Date: Thu, Aug 26, 2010 at 04:59:21PM +0100
Quoted 3 lines
<
linux/vgaarb.h> should define dummy inline functions ifCONFIG_VGA_ARBis not defined. It already does this forvga_client_register()but should cover the other functions as well.
But what if you still need the VGA arbitration functionality? I don't think I'll be running more than one X server on that netbook but still...
Signature · 2 lines
Regards/Gruss,
Boris.