MTD/SPI/FLASH: add support for Ramtron FRAMs using SPI
PATCH v2 1/1 MTD/SPI/FLASH: add support for Ramtron FRAMs using SPI
From: Reinhard Meyer <[email protected]>
--- drivers/mtd/spi/Makefile | 1 + drivers/mtd/spi/ramtron.c | 312 ++++++++++++++++++++++++++++++++++ drivers/mtd/spi/spi_flash.c | 54 ++++++- drivers/mtd/spi/spi_flash_internal.h | 1 + 4 files changed, 363 insertions(+), 5 deletions(-) create mode 100644 drivers/mtd/spi/ramtron.c
drivers/mtd/spi/Makefile +1 -0
@@ -32,6 +32,7 @@ COBJS-$(CONFIG_SPI_FLASH_SPANSION) += spansion.o COBJS-$(CONFIG_SPI_FLASH_SST) += sst.o COBJS-$(CONFIG_SPI_FLASH_STMICRO) += stmicro.o COBJS-$(CONFIG_SPI_FLASH_WINBOND) += winbond.o +COBJS-$(CONFIG_SPI_FRAM_RAMTRON) += ramtron.o COBJS-$(CONFIG_SPI_M95XXX) += eeprom_m95xxx.o COBJS := $(COBJS-y)
drivers/mtd/spi/ramtron.c new file +312 -0
312 lines not on this page · raw message
drivers/mtd/spi/spi_flash.c +49 -5
87 lines not on this page · raw message
drivers/mtd/spi/spi_flash_internal.h +1 -0
@@ -50,3 +50,4 @@ struct spi_flash *spi_flash_probe_macronix(struct spi_slave *spi, u8 *idcode);struct spi_flash *spi_flash_probe_sst (struct spi_slave *spi,u8 *idcode);struct spi_flash *spi_flash_probe_stmicro (struct spi_slave *spi,u8 *idcode);struct spi_flash *spi_flash_probe_winbond (struct spi_slave *spi,u8 *idcode); +struct spi_flash *spi_fram_probe_ramtron (struct spi_slave *spi,u8 *idcode);
Signature · 1 line
1.5.6.5
PATCH v2 1/1 MTD/SPI/FLASH: add support for Ramtron FRAMs using SPI
Quoted 3 lines · On Friday, August 27, 2010 07:16:37 Reinhard Meyer wrote:
From: Reinhard Meyer <[email protected]>
Signed-off-by Reinhard Meyer <[email protected]>
looks like you still need to do git commit --amend --author 'Reinhard Meyer <[email protected]>' ...
Quoted 1 line
+#ifdef
CONFIG_SPI_FRAM_RAMTRON_NONSTD
i would stick with the style "NON_JEDEC"
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100828/e5e57b16/attachment.pgp
PATCH v2 1/1 MTD/SPI/FLASH: add support for Ramtron FRAMs using SPI
Dear Mike Frysinger,
Quoted 7 lines · On Friday, August 27, 2010 07:16:37 Reinhard Meyer wrote:
Quoted 3 lines
From: Reinhard Meyer<[email protected]>
Signed-off-by Reinhard Meyer<[email protected]>looks like you still need to do
git commit --amend --author 'Reinhard Meyer <[email protected]>'...
Both are valid e-mail addresses, who says the one who signs off and the one who sends the e-mail must be the same person? Its tedious to change that because its like 10 commits back in my branch. But I can do that again.
Quoted 4 lines
Quoted 2 lines
+#ifdef
CONFIG_SPI_FRAM_RAMTRON_NONSTDi would stick with the style "
NON_JEDEC"
Doable.
Is there anything else within the patch itself that you deem need to be changed?
Reinhard
PATCH v2 1/1 MTD/SPI/FLASH: add support for Ramtron FRAMs using SPI
Quoted 6 lines · On Saturday, August 28, 2010 18:23:18 Reinhard Meyer wrote:
Dear Mike Frysinger,
Quoted 5 lines · On Friday, August 27, 2010 07:16:37 Reinhard Meyer wrote:
Quoted 3 lines
From: Reinhard Meyer<[email protected]>
Signed-off-by Reinhard Meyer<[email protected]>
Quoted 7 lines
Quoted 2 lines
looks like you still need to do
git commit --amend --author 'Reinhard Meyer <[email protected]>'...Both are valid e-mail addresses, who says the one who signs off and the one who sends the e-mail must be the same person? Its tedious to change that because its like 10 commits back in my branch. But I can do that again.
i dont think there is anything spelled out anywhere, but it's very uncommon. which is to say ive never seen anyone do it before *on purpose*, only on accident and then they wanted to fix it. being a sheeple in this scenario makes other people's lives easier because it's following the existing behavior without throwing people off.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100828/7b7e67ea/attachment.pgp
PATCH v2 1/1 MTD/SPI/FLASH: add support for Ramtron FRAMs using SPI
Quoted 15 lines · Mike Frysinger
Quoted 6 lines · On Saturday, August 28, 2010 18:23:18 Reinhard Meyer wrote:
Dear Mike Frysinger,
Quoted 5 lines · On Friday, August 27, 2010 07:16:37 Reinhard Meyer wrote:
Quoted 3 lines
From: Reinhard Meyer<[email protected]>
Signed-off-by Reinhard Meyer<[email protected]>Quoted 7 lines
Quoted 2 lines
looks like you still need to do
git commit --amend --author 'Reinhard Meyer<[email protected]>'...Both are valid e-mail addresses, who says the one who signs off and the one who sends the e-mail must be the same person? Its tedious to change that because its like 10 commits back in my branch. But I can do that again.
Quoted 6 lines
i dont think there is anything spelled out anywhere, but it's very uncommon. which is to say ive never seen anyone do it before *on purpose*, only on accident and then they wanted to fix it. being a sheeple in this scenario makes other people's lives easier because it's following the existing behavior without throwing people off.
-mike
It is just that there are several commits (not only this one) which I have made before I introduced the new e-mail address (solely for u-boot purposes). It might be easier if I just change the sign-off addresses back to <info@> for those older patches. That's simple to do when I squash a correction anyway.
Or I let cat 00xxxxxx | sed s/info at emk/u-boot at emk/ | git send-email handle that...
That will fix some older copyrights of mine that are reinhard.meyer at emk..., too.
Reinhard