Skip to contentSkip to conversation

ipheth: remove incorrect devtype to WWAN

PATCH In review Dan Williams 2 participants 2 messages Sep 8, 2010 – Sep 10, 2010 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipheth: remove incorrect devtype to WWAN

The 'wwan' devtype is meant for devices that require preconfiguration and *every* time setup before the ethernet interface can be used, like cellular modems which require a series of setup commands on serial ports or other mechanisms before the ethernet interface will handle packets.

As ipheth only requires one-per-hotplug pairing setup with no preconfiguration (like APN, phone #, etc) and the network interface is usable at any time after that initial setup, remove the incorrect devtype wwan.

---

drivers/net/usb/ipheth.c +0 -3
index 08e7b6a..3388569 100644
@@ -424,10 +424,6 @@ static const struct net_device_ops ipheth_netdev_ops = {
 	.ndo_get_stats = &ipheth_stats,
 };
 
-static struct device_type ipheth_type = {
-	.name	= "wwan",
-};

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

From: Dan Williams <[email protected]>
Date: Wed, 08 Sep 2010 12:50:47 -0500

Quoted 11 lines

The 'wwan' devtype is meant for devices that require preconfiguration and *every* time setup before the ethernet interface can be used, like cellular modems which require a series of setup commands on serial ports or other mechanisms before the ethernet interface will handle packets.

As ipheth only requires one-per-hotplug pairing setup with no preconfiguration (like APN, phone #, etc) and the network interface is usable at any time after that initial setup, remove the incorrect devtype wwan.

Applied, thanks Dan.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html