drm/i915: fix GMCH power reporting
Subsystems (2)
PATCH 1/1 drm/i915: fix GMCH power reporting
The IPS driver needs to know the current power consumption of the GMCH in order to make decisions about when to increase or decrease the CPU and/or GPU power envelope. So fix up the divisions to save the results so the numbers are actually correct (contrary to some earlier comments and code, these functions do not modify the first argument and use it for the result).
drivers/gpu/drm/i915/i915_dma.c +3 -3
@@ -1787,9 +1787,9 @@ unsigned long i915_chipset_val(struct drm_i915_private *dev_priv) } } -div_u64 (diff, diff1); + diff =div_u64 (diff, diff1); ret = ((m * diff) + c); -div_u64 (ret,10 ); + ret =div_u64 (ret,10 ); dev_priv->last_count1 = total_count; dev_priv->last_time1 = now;
@@ -1858,7 +1858,7 @@ void i915_update_gfx_val(struct drm_i915_private *dev_priv)/* More magic constants... */ diff = diff *1181 ; -div_u64 (diff, diffms *10 ); + diff =div_u64 (diff, diffms *10 ); dev_priv->gfx_power = diff; }
Chris Wilson
AppliedQuoted 6 lines · Jesse Barnes
The IPS driver needs to know the current power consumption of the GMCH in order to make decisions about when to increase or decrease the CPU and/or GPU power envelope. So fix up the divisions to save the results so the numbers are actually correct (contrary to some earlier comments and code, these functions do not modify the first argument and use it for the result).
Applied to -fixes, with a cc for stable, "it's nice to have good values in debugfs if nothing else".
-Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre