Skip to contentSkip to conversation

mips: irq: add stackoverflow detection

PATCH In review Adam Jiang 3 participants 4 messages Oct 6, 2010 MIPS

lore
Share & tools
lore

Adam Jiang

author
#0 lore raw

PATCH v3 1/1 mips: irq: add stackoverflow detection

Add stackoverflow detection to mips arch

This is the 3rd version of the smiple patch. 2K is too big for many system, so I Modified the warning line by following Ralf's suggestion.

---
 arch/mips/Kconfig.debug             |    7 +++++++
 arch/mips/include/asm/thread_info.h |    2 ++
 arch/mips/kernel/irq.c              |   25 +++++++++++++++++++++++++
 3 files changed, 34 insertions(+), 0 deletions(-)
arch/mips/Kconfig.debug +7 -0
index 43dc279..30c58d4 100644
@@ -67,6 +67,13 @@ config CMDLINE_OVERRIDE
 
 	  Normally, you will choose 'N' here.
 
+config DEBUG_STACKOVERFLOW
+	bool "Check for stack overflows"
+	depends on DEBUG_KERNEL
+	help
+	  This option will cause messages to be printed if free stack
+	  space drops below a certain limit.
+
 config DEBUG_STACK_USAGE
 	bool "Enable stack utilization instrumentation"
 	depends on DEBUG_KERNEL
arch/mips/include/asm/thread_info.h +2 -0
index 70df9c0..b60b28d 100644
@@ -83,6 +83,8 @@ register struct thread_info *__current_thread_info __asm__("$28");
 #define THREAD_SIZE (PAGE_SIZE << THREAD_SIZE_ORDER)
 #define THREAD_MASK (THREAD_SIZE - 1UL)
 
+#define STACK_WARN  (THREAD_SIZE/8)
+
 #define __HAVE_ARCH_THREAD_INFO_ALLOCATOR
 
 #ifdef CONFIG_DEBUG_STACK_USAGE
arch/mips/kernel/irq.c +25 -0
index c6345f5..b43edb7 100644
@@ -151,6 +151,28 @@ void __init init_IRQ(void)
 #endif
 }
 
+#ifdef CONFIG_DEBUG_STACKOVERFLOW
+static inline void check_stack_overflow(void)
+{
+	unsigned long sp;
+
+	asm volatile("move %0, $sp" : "=r" (sp));
+	sp = sp & THREAD_MASK;
+
+	/*
+	 * check for stack overflow: is there less than STACK_WARN free?
+	 * STACK_WARN is defined as 1/8 of THREAD_SIZE by default.
+	 */
+	if (unlikely(sp < (sizeof(struct thread_info) + STACK_WARN))) {
+		printk("do_IRQ: stack overflow: %ld\n",
+		       sp - sizeof(struct thread_info));
+		dump_stack();
+	}
+}
+#else
+static inline void check_stack_overflow(void) {}
+#endif
+
 /*
  * do_IRQ handles all normal device IRQ's (the special
  * SMP cross-CPU interrupts have their own specific
@@ -159,6 +181,9 @@ void __init init_IRQ(void)
 void __irq_entry do_IRQ(unsigned int irq)
 {
 	irq_enter();
+
+	check_stack_overflow();
+
 	__DO_IRQ_SMTC_HOOK(irq);
 	generic_handle_irq(irq);
 	irq_exit();
Signature · 1 line
1.7.2.2
#1 lore raw

Hello.

Quoted 1 line · Adam Jiang

Add stackoverflow detection to mips arch

There's no such word: stackoverflow. Space is needed.

Quoted 4 lines

This is the 3rd version of the smiple patch. 2K is too big for many system, so I Modified the warning line by following Ralf's suggestion.

[...]

Quoted 5 lines
arch/mips/kernel/irq.c +0 -0
index c6345f5..b43edb7 100644

arch/mips/kernel/irq.c void __init init_IRQ(void) · line 160

Quoted 10 lines
arch/mips/kernel/irq.c +7 -0
@@ -151,6 +151,28 @@ void __init init_IRQ(void)
  #endif
  }
 
+#ifdef CONFIG_DEBUG_STACKOVERFLOW
+static inline void check_stack_overflow(void)
+{
+	unsigned long sp;
+
+	asm volatile("move %0, $sp" : "=r" (sp));
+	sp = sp & THREAD_MASK;

Why not:

	sp &= THREAD_MASK;

It's C, after all! :-)

WBR, Sergei

#2 lore raw
Quoted 18 lines · Sergei Shtylyov
Quoted 1 line

Add stackoverflow detection to mips arch

There's no such word: stackoverflow. Space is needed.

Quoted 4 lines

This is the 3rd version of the smiple patch. 2K is too big for many system, so I Modified the warning line by following Ralf's suggestion.

[...]

Quoted 8 lines
arch/mips/kernel/irq.c +0 -0
index c6345f5..b43edb7 100644
@@ -151,6 +151,28 @@ void __init init_IRQ(void)
 #endif
 }
 
Quoted 13 lines

arch/mips/kernel/irq.c void __init init_IRQ(void) · line 160

Quoted 7 lines
arch/mips/kernel/irq.c +7 -0
+#ifdef CONFIG_DEBUG_STACKOVERFLOW
+static inline void check_stack_overflow(void)
+{
+	unsigned long sp;
+
+	asm volatile("move %0, $sp" : "=r" (sp));
+	sp = sp & THREAD_MASK;
   Why not:

	sp &= THREAD_MASK;

   It's C, after all! :-)

I already had accepted his previous version with minor changes so I've combined the two.

Thanks Adam!

Ralf

author
#3 lore raw
Quoted 30 lines · Ralf Baechle
Quoted 28 lines · Sergei Shtylyov
Quoted 1 line

Add stackoverflow detection to mips arch

There's no such word: stackoverflow. Space is needed.

Quoted 4 lines

This is the 3rd version of the smiple patch. 2K is too big for many system, so I Modified the warning line by following Ralf's suggestion.

[...]

Quoted 5 lines
arch/mips/kernel/irq.c +0 -0
index c6345f5..b43edb7 100644

arch/mips/kernel/irq.c void __init init_IRQ(void) · line 160

Quoted 10 lines
arch/mips/kernel/irq.c +7 -0
@@ -151,6 +151,28 @@ void __init init_IRQ(void)
 #endif
 }
 
+#ifdef CONFIG_DEBUG_STACKOVERFLOW
+static inline void check_stack_overflow(void)
+{
+	unsigned long sp;
+
+	asm volatile("move %0, $sp" : "=r" (sp));
+	sp = sp & THREAD_MASK;

Why not:

Quoted 6 lines
Quoted 3 lines
	sp &= THREAD_MASK;
   It's C, after all! :-)

I already had accepted his previous version with minor changes so I've combined the two.

Thanks Ralf. I am very glad I can do this small piece of code for Linux kernel, though with many faults. :) No doubt I will try to do much more then.

Best regards,
/Adam