Skip to contentSkip to conversation

ppc4xx: Add CATCenter IoCon 405EP board support

PATCH New Dirk Eibach 3 participants 7 messages Oct 13, 2010 – Oct 14, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppc4xx: Add CATCenter IoCon 405EP board support

Board support for the Guntermann & Drunck IoCon.

---
 MAINTAINERS                 |    1 +
 MAKEALL                     |    1 +
 board/gdsys/iocon/Makefile  |   51 +++++++
 board/gdsys/iocon/config.mk |   24 ++++
 board/gdsys/iocon/iocon.c   |  302 +++++++++++++++++++++++++++++++++++++++++++
 board/gdsys/iocon/osd.c     |  255 ++++++++++++++++++++++++++++++++++++
 board/gdsys/iocon/osd.h     |   29 ++++
 boards.cfg                  |    1 +
 include/configs/iocon.h     |  242 ++++++++++++++++++++++++++++++++++
 9 files changed, 906 insertions(+), 0 deletions(-)
 create mode 100644 board/gdsys/iocon/Makefile
 create mode 100644 board/gdsys/iocon/config.mk
 create mode 100644 board/gdsys/iocon/iocon.c
 create mode 100644 board/gdsys/iocon/osd.c
 create mode 100644 board/gdsys/iocon/osd.h
 create mode 100644 include/configs/iocon.h
MAINTAINERS +1 -0
index c209af5..e2762ea 100644
@@ -145,6 +145,7 @@ Dirk Eibach <[email protected]>
 	dlvision        PPC405EP
 	gdppc440etx	PPC440EP/GR
 	intip		PPC460EX
+	iocon		PPC405EP
 	neo		PPC405EP
 
 Dave Ellis <[email protected]>
MAKEALL +1 -0
index 1b506d6..2e5973c 100755
@@ -157,6 +157,7 @@ LIST_4xx="$(boards_by_cpu ppc4xx)
 	hcu4		\
 	hcu5		\
 	intip		\
+	iocon		\
 	kilauea		\
 	kilauea_nand	\
 	mcu25		\
board/gdsys/iocon/Makefile new file +51 -0

51 lines not on this page · raw message

board/gdsys/iocon/config.mk new file +24 -0
new file mode 100644
index 0000000..1bdf5e4
@@ -0,0 +1,24 @@
+#
+# (C) Copyright 2000
+# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+TEXT_BASE = 0xFFFC0000
board/gdsys/iocon/iocon.c new file +302 -0

302 lines not on this page · raw message

board/gdsys/iocon/osd.c new file +255 -0

255 lines not on this page · raw message

board/gdsys/iocon/osd.h new file +29 -0
new file mode 100644
index 0000000..4431cbc
@@ -0,0 +1,29 @@
+/*
+ * (C) Copyright 2010
+ * Dirk Eibach,  Guntermann & Drunck GmbH, eibach at gdsys.de
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef _OSD_H_
+#define _OSD_H_
+
+int osd_probe(void);
+
+#endif
boards.cfg +1 -0
index 9226424..e58a791 100644
@@ -358,6 +358,7 @@ pcs440ep	powerpc	ppc4xx
 quad100hd	powerpc	ppc4xx
 dlvision	powerpc	ppc4xx		-		gdsys
 gdppc440etx	powerpc	ppc4xx		-		gdsys
+iocon		powerpc	ppc4xx		-		gdsys
 CPCIISER4	powerpc	ppc4xx		cpciiser4	esd
 DASA_SIM	powerpc	ppc4xx		dasa_sim	esd
 PMC405DE	powerpc	ppc4xx		pmc405de	esd
include/configs/iocon.h new file +242 -0

242 lines not on this page · raw message

Signature · 1 line
1.5.6.5
#1 lore raw

PATCH 1/1 ppc4xx: Add CATCenter IoCon 405EP board support

Dear Dirk Eibach,

Quoted 12 lines · In message <[email protected]> you wrote:

Board support for the Guntermann & Drunck IoCon.

---
 MAINTAINERS                 |    1 +
 MAKEALL                     |    1 +
 board/gdsys/iocon/Makefile  |   51 +++++++
 board/gdsys/iocon/config.mk |   24 ++++
 board/gdsys/iocon/iocon.c   |  302 +++++++++++++++++++++++++++++++++++++++++++
 board/gdsys/iocon/osd.c     |  255 ++++++++++++++++++++++++++++++++++++
 board/gdsys/iocon/osd.h     |   29 ++++
 boards.cfg                  |    1 +
Quoted 8 lines
 include/configs/iocon.h     |  242 ++++++++++++++++++++++++++++++++++
 9 files changed, 906 insertions(+), 0 deletions(-)
 create mode 100644 board/gdsys/iocon/Makefile
 create mode 100644 board/gdsys/iocon/config.mk
 create mode 100644 board/gdsys/iocon/iocon.c
 create mode 100644 board/gdsys/iocon/osd.c
 create mode 100644 board/gdsys/iocon/osd.h
 create mode 100644 include/configs/iocon.h

Which patch version is this nw? What has been changed?

Please see
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Gravitation cannot be held responsible for people falling in  love."
- Albert Einstein
#2 lore raw

PATCH 1/1 ppc4xx: Add CATCenter IoCon 405EP board support

Dear Wolfgang,

Quoted 18 lines
Quoted 6 lines
---
 MAINTAINERS                 |    1 +
 MAKEALL                     |    1 +
 board/gdsys/iocon/Makefile  |   51 +++++++
 board/gdsys/iocon/config.mk |   24 ++++
 board/gdsys/iocon/iocon.c   |  302 

+++++++++++++++++++++++++++++++++++++++++++

Quoted 1 line
 board/gdsys/iocon/osd.c     |  255 

++++++++++++++++++++++++++++++++++++

Quoted 3 lines
 board/gdsys/iocon/osd.h     |   29 ++++
 boards.cfg                  |    1 +
 include/configs/iocon.h     |  242 

++++++++++++++++++++++++++++++++++

Quoted 4 lines
 9 files changed, 906 insertions(+), 0 deletions(-)  create mode 

100644 board/gdsys/iocon/Makefile create mode 100644 board/gdsys/iocon/config.mk create mode 100644 board/gdsys/iocon/iocon.c create mode 100644

Quoted 5 lines

board/gdsys/iocon/osd.c

Quoted 2 lines

create mode 100644 board/gdsys/iocon/osd.h create mode 100644 include/configs/iocon.h

Which patch version is this nw? What has been changed?

It's the first version of this patch, so the header should be allright :p

Cheers
Dirk
--------------------------------------------------------------------------
Guntermann & Drunck GmbH Systementwicklung
Dortmunder Str. 4a
D-57234 Wilnsdorf - Germany
Tel: +49 (0) 27 39 / 89 01 - 100 Fax: +49 (0) 27 39 / 89 01 - 120
E-Mail: mailto:sales at gdsys.de Web: www.gdsys.de
--------------------------------------------------------------------------
Geschaeftsfuehrer:
Udo Guntermann - Martin Drunck - Reiner Ruelmann - Klaus Tocke HRB 2884, Amtsgericht Siegen - WEEE-Reg.-Nr. DE30763240 USt.-Id.-Nr. DE 126575222 - Steuer-Nr. 342 / 5835 / 1041
--------------------------------------------------------------------------
DQS-zertifiziert nach ISO 9001:2000
--------------------------------------------------------------------------

#3 lore raw

PATCH 1/1 ppc4xx: Add CATCenter IoCon 405EP board support

Dear "Eibach, Dirk",

Quoted 5 lines · In message <[email protected]> you wrote:

This is an OpenPGP/MIME signed message (RFC 2440 and 3156) ---SG_MailGateway:=gJA5JiKFGK1gbc86QTKjeFZk9I
Content-Type: application/pgp-encrypted

Version: 1

Please do not send encrypted messages to the mailing list.

Please send plain text only.

Message unreadable, ignored. Sorry.

#4 lore raw

PATCH 1/1 ppc4xx: Add CATCenter IoCon 405EP board support

In reply to Dirk Eibach

Dear Dirk Eibach,

Quoted 12 lines · In message <[email protected]> you wrote:

Board support for the Guntermann & Drunck IoCon.

---
 MAINTAINERS                 |    1 +
 MAKEALL                     |    1 +
 board/gdsys/iocon/Makefile  |   51 +++++++
 board/gdsys/iocon/config.mk |   24 ++++
 board/gdsys/iocon/iocon.c   |  302 +++++++++++++++++++++++++++++++++++++++++++
 board/gdsys/iocon/osd.c     |  255 ++++++++++++++++++++++++++++++++++++
 board/gdsys/iocon/osd.h     |   29 ++++
 boards.cfg                  |    1 +
Quoted 8 lines
 include/configs/iocon.h     |  242 ++++++++++++++++++++++++++++++++++
 9 files changed, 906 insertions(+), 0 deletions(-)
 create mode 100644 board/gdsys/iocon/Makefile
 create mode 100644 board/gdsys/iocon/config.mk
 create mode 100644 board/gdsys/iocon/iocon.c
 create mode 100644 board/gdsys/iocon/osd.c
 create mode 100644 board/gdsys/iocon/osd.h
 create mode 100644 include/configs/iocon.h

It seems thius board is very similar to the "io" board; especially board/gdsys/iocon/{io,iocon}.c and include/configs/{ip,iocon}.h share many, many identical lines.

Please factor out such common code. Eventually, a single board entry with two configurations is sufficient?

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Make it right before you make it faster.
#5 lore raw

PATCH 1/1 ppc4xx: Add CATCenter IoCon 405EP board support

Quoted 4 lines

It seems thius board is very similar to the "io" board; especially board/gdsys/iocon/{io,iocon}.c and include/configs/{ip,iocon}.h share many, many identical lines.

#6 lore raw

PATCH 1/1 ppc4xx: Add CATCenter IoCon 405EP board support

Dear "Eibach, Dirk",

Quoted 5 lines · In message <[email protected]> you wrote:
Quoted 3 lines

Please factor out such common code. Eventually, a single board entry with two configurations is sufficient?

Nice idea. Is there a way to do this with boards.cfg?

Yes. See the proposed changes in the "Makefile-cleanup" branch of the u-boot-testing repo; see for example this version of boards.cfg which passes in boards.cfg all options that used to go through the top level Makefile:

http://git.denx.de/?p=u-boot/u-boot-testing.git;a=blob;f=boards.cfg;h=920725448b4747d29fac03668d069cef448a945e;hb=Makefile-cleanup

For example, see the CATcenter entries in lines 639 ff.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is better to marry than to burn.
                                - Bible ``I Corinthians'' ch. 7, v. 9