Skip to contentSkip to conversation

KVM test: Make cache=none the default on KVM autotest runs

PATCH In review Lucas Meneghel Rodrigues 3 participants 7 messages Oct 14, 2010 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 KVM test: Make cache=none the default on KVM autotest runs

cache=none is our supported way of running images, so enforce this policy on the KVM autotest defaults. It will also make it easier for people trying to figure out where to change the cache mode for images.

---
 client/tests/kvm/tests_base.cfg.sample |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
client/tests/kvm/tests_base.cfg.sample +1 -0
index 769d750..87fd51d 100644
@@ -35,6 +35,7 @@ smp = 1
 mem = 512
 image_size = 10G
 drive_index_image1 = 0
+drive_cache = none
 shell_port = 22
 display = vnc
 drive_index_cd1 = 1
Signature · 1 line
1.7.2.3
#1 lore raw

PATCH 2/2 KVM test: Remove image_boot=yes from virtio_blk variant

Recent qemu can handle virtio without boot without boot=on, and qemu.git will simply state the option as invalid. So remove it from the default config on tests_base.cfg, just leave it there commented in case someone is testing older versions.

---
 client/tests/kvm/tests_base.cfg.sample |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
client/tests/kvm/tests_base.cfg.sample +3 -1
index 87fd51d..f8c70fe 100644
@@ -1914,7 +1914,9 @@ variants:
         drive_format=scsi
     - virtio_blk:
         drive_format=virtio
-        image_boot=yes
+        # Some older qemu might need image_boot=yes for virtio images to work.
+        # Please uncomment the below if that is the case.
+        #image_boot=yes
 
 
 virtio_net|virtio_blk|e1000|balloon_check:
Signature · 1 line
1.7.2.3
#2 lore raw

Re: [PATCH 2/2] KVM test: Remove image_boot=yes from virtio_blk variant

Quoted 5 lines · On Thu, 14 Oct 2010 01:24:12 -0300 Lucas Meneghel Rodrigues <[email protected]>…

Recent qemu can handle virtio without boot without boot=on, and qemu.git will simply state the option as invalid. So remove it from the default config on tests_base.cfg, just leave it there commented in case someone is testing older versions.

But older qemu shipped with distros might require "boot=on". Its good to check qemu version.

Thanks
Pradeep

#3 lore raw

PATCH 1/2 KVM : ping6 test

In reply to Lucas Meneghel Rodrigues

This patch is for Ping6 testing

* ping6 with various message sizes guest to/from local/remote host using link-local addresses
By default IPv6 seems to be disabled on virbr0. Enable it by doing echo 0 > /proc/sys/net/ipv6/conf/virbr0/disable_ipv6

Please find the below attached patch.

Thanks
Pradeep

_______________________________________________
Autotest mailing list
[email protected]
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest

#4 lore raw

Re: [AUTOTEST] [PATCH 1/2] KVM : ping6 test

Quoted 8 lines · pradeep

This patch is for Ping6 testing

* ping6 with various message sizes guest to/from local/remote host using link-local addresses
By default IPv6 seems to be disabled on virbr0. Enable it by doing echo 0 > /proc/sys/net/ipv6/conf/virbr0/disable_ipv6

Please find the below attached patch

We also need update related code in kvm_test_utils.py, and consider the difference of 'ping' and 'ping6'.

Quoted 13 lines

---

client/tests/kvm/tests/ping.py +2 -1
@@ -1,5 +1,6 @@
-import logging
+import logging, time
 from autotest_lib.client.common_lib import error
+from autotest_lib.client.bin import utils
 import kvm_test_utils
 
 

client/tests/kvm/tests/ping.py def run_ping(test, params, env): · line 33

Quoted 6 lines
client/tests/kvm/tests/ping.py +3 -0
@@ -27,10 +28,18 @@ def run_ping(test, params, env):
     nics = params.get("nics").split()
     strict_check = params.get("strict_check", "no") == "yes"
 
+    address_type = params.get("address_type")
+    #By default IPv6 seems to be disabled on virbr0. 
+    ipv6_cmd = "echo %s > /proc/sys/net/ipv6/conf/virbr0/disable_ipv6"

We may use other bridge, so 'virbr0', need replace this hardcode name. We can reference to 'autotest-upstream/client/tests/kvm/scripts/qemu-ifup'

       switch=$(/usr/sbin/brctl show | awk 'NR==2 { print $1 }')
Quoted 23 lines
client/tests/kvm/tests/ping.py +9 -1
+
     packet_size = [0, 1, 4, 48, 512, 1440, 1500, 1505, 4054, 4055, 4096, 4192,
                    8878, 9000, 32767, 65507]
 
     try:
+        if address_type == "ipv6":
+                utils.run(ipv6_cmd % "0" )
+                time.sleep(5)
+
         for i, nic in enumerate(nics):
             ip = vm.get_address(i)
             if not ip:
@@ -68,5 +77,9 @@ def run_ping(test, params, env):
                 if status != 0:
                     raise error.TestFail("Ping returns non-zero value %s" %
                                          output)
+        if address_type == "ipv6":
+                utils.run(ipv6_cmd % "1" )
+                time.sleep(5)
+
     finally:
         session.close()
---
#5 lore raw

Re: [Autotest] [AUTOTEST] [PATCH 1/2] KVM : ping6 test

Quoted 8 lines · On Thu, 14 Oct 2010 18:05:04 +0800 Amos Kong <[email protected]> wrote:
Quoted 7 lines · pradeep

This patch is for Ping6 testing

* ping6 with various message sizes guest to/from local/remote
host using link-local addresses
By default IPv6 seems to be disabled on virbr0. Enable it by doing echo 0 > /proc/sys/net/ipv6/conf/virbr0/disable_ipv6

Quoted 4 lines
Quoted 1 line

Please find the below attached patch

We also need update related code in kvm_test_utils.py, and consider the difference of 'ping' and 'ping6'.

ping6 test again calls same ping, and enables ipv6. so we dont need to make any changes in kvm_test_utils.py for ping6.

Quoted 55 lines
Quoted 20 lines

---
--- autotest/client/tests/kvm/tests/ping.py 2010-10-14
14:20:52.523791118 +0530 +++
autotest_new/client/tests/kvm/tests/ping.py 2010-10-14
14:46:57.711797139 +0530 @@ -1,5 +1,6 @@ -import logging

(quoted diff) +5 -0
+import logging, time
 from autotest_lib.client.common_lib import error
+from autotest_lib.client.bin import utils
 import kvm_test_utils
@@ -27,10 +28,18 @@ def run_ping(test, params, env):
     nics = params.get("nics").split()
     strict_check = params.get("strict_check", "no") == "yes"
 
+    address_type = params.get("address_type")
+    #By default IPv6 seems to be disabled on virbr0. 
+    ipv6_cmd = "echo %s
Quoted 1 line
Quoted 1 line

/proc/sys/net/ipv6/conf/virbr0/disable_ipv6"

We may use other bridge, so 'virbr0', need replace this hardcode name. We can reference to 'autotest-upstream/client/tests/kvm/scripts/qemu-ifup' switch=$(/usr/sbin/brctl show | awk 'NR==2 { print $1 }')

Quoted 13 lines

+

     packet_size = [0, 1, 4, 48, 512, 1440, 1500, 1505, 4054, 4055,

4096, 4192, 8878, 9000, 32767, 65507]

try:

(quoted diff) +4 -0
+        if address_type == "ipv6":
+                utils.run(ipv6_cmd % "0" )
+                time.sleep(5)
+
         for i, nic in enumerate(nics):
             ip = vm.get_address(i)
             if not ip:

Review def run_ping(test, params, env):

Quoted 10 lines
(quoted diff) +4 -1
@@ -68,5 +77,9 @@ def run_ping(test, params, env):
                 if status != 0:
                     raise error.TestFail("Ping returns non-zero
 value %s" % output)
+        if address_type == "ipv6":
+                utils.run(ipv6_cmd % "1" )
+                time.sleep(5)
+
     finally:
         session.close()
---

_______________________________________________
Autotest mailing list
[email protected]
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest