Skip to contentSkip to conversation

dma: imx-dma: fix imxdma_probe error path

PATCH RESEND In review Axel Lin 2 participants 2 messages Nov 2, 2010

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH RESEND 1/1 dma: imx-dma: fix imxdma_probe error path

Otherwise, the i variable will be -1 inside the latest iteration of the while loop.

---
This resend only update the commit log.
Regards,
Axel

 drivers/dma/imx-dma.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/dma/imx-dma.c +1 -1
index f629e49..e53d438 100644
@@ -379,7 +379,7 @@ static int __init imxdma_probe(struct platform_device *pdev)
 	return 0;
 
 err_init:
-	while (i-- >= 0) {
+	while (--i >= 0) {
 		struct imxdma_channel *imxdmac = &imxdma->channel[i];
 		imx_dma_free(imxdmac->imxdma_channel);
 	}
Signature · 1 line
1.7.2
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Axel Lin

Otherwise, the i variable will be -1 inside the latest iteration of the while loop.

Quoted 27 lines

---
This resend only update the commit log.
Regards,
Axel

 drivers/dma/imx-dma.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/dma/imx-dma.c +1 -1
index f629e49..e53d438 100644
@@ -379,7 +379,7 @@ static int __init imxdma_probe(struct platform_device *pdev)
 	return 0;
 
 err_init:
-	while (i-- >= 0) {
+	while (--i >= 0) {
 		struct imxdma_channel *imxdmac = &imxdma->channel[i];
 		imx_dma_free(imxdmac->imxdma_channel);
 	}
Signature · 1 line
1.7.2
Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |