Skip to contentSkip to conversation

ASoC: Add MAX98089 CODEC driver

PATCH In review Jesse Marroquin 2 participants 3 messages Nov 11, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: Add MAX98089 CODEC driver

This patch adds the initial driver for the MAX98089 CODEC.

---
 include/sound/max98089.h    |   50 +
 sound/soc/codecs/Kconfig    |    4 +
 sound/soc/codecs/Makefile   |    2 +
 sound/soc/codecs/max98089.c | 2097 +++++++++++++++++++++++++++++++++++++++++++
 sound/soc/codecs/max98089.h |  193 ++++
 5 files changed, 2346 insertions(+), 0 deletions(-)
 create mode 100644 include/sound/max98089.h
 create mode 100644 sound/soc/codecs/max98089.c
 create mode 100644 sound/soc/codecs/max98089.h
include/sound/max98089.h new file +50 -0
new file mode 100644
index 0000000..1c69aaa
@@ -0,0 +1,50 @@
+/*
+ * Platform data for MAX98089
+ *
+ * Copyright 2010 Maxim Integrated Products
+ *
+ *  This program is free software; you can redistribute  it and/or modify it
+ *  under  the terms of  the GNU General  Public License as published by the
+ *  Free Software Foundation;  either version 2 of the  License, or (at your
+ *  option) any later version.
+ *
+ */
+
+#ifndef __SOUND_MAX98089_PDATA_H__
+#define __SOUND_MAX98089_PDATA_H__
+
+/* Equalizer filter response configuration */
+struct max98089_eq_cfg {
+	const char *name;
+	unsigned int rate;
+	u16 band1[5];
+	u16 band2[5];
+	u16 band3[5];
+	u16 band4[5];
+	u16 band5[5];
+};
+
+/* codec platform data */
+struct max98089_pdata {
+
+	/* Equalizers for DAI1 and DAI2 */
+	struct max98089_eq_cfg *eq_cfg;
+	unsigned int eq_cfgcnt;
+
+	/* Receiver output can be configured as power amplifier or LINE out */
+	/* Set receiver_mode to:
+	 * 0 = amplifier output, or
+	 * 1 = LINE level output
+	 */
+	unsigned int receiver_mode:1;
+
+	/* Analog/digital microphone configuration:
+	 * 0 = analog microphone input (normal setting)
+	 * 1 = digital microphone input
+	 */
+	unsigned int digmic_left_mode:1;
+	unsigned int digmic_right_mode:1;
+
+};
+
+#endif
sound/soc/codecs/Kconfig +4 -0
index 94a9d06..7735050 100644
@@ -28,6 +28,7 @@ config SND_SOC_ALL_CODECS
 	select SND_SOC_DA7210 if I2C
 	select SND_SOC_JZ4740 if SOC_JZ4740
 	select SND_SOC_MAX98088 if I2C
+	select SND_SOC_MAX98089 if I2C
 	select SND_SOC_MAX9877 if I2C
 	select SND_SOC_PCM3008
 	select SND_SOC_SPDIF
@@ -162,6 +163,9 @@ config SND_SOC_DA7210
 config SND_SOC_MAX98088
        tristate
 
+config SND_SOC_MAX98089
+	tristate
+
 config SND_SOC_PCM3008
        tristate
 
sound/soc/codecs/Makefile +2 -0
index f67a2d6..243665f 100644
@@ -16,6 +16,7 @@ snd-soc-cx20442-objs := cx20442.o
 snd-soc-da7210-objs := da7210.o
 snd-soc-l3-objs := l3.o
 snd-soc-max98088-objs := max98088.o
+snd-soc-max98089-objs := max98089.o
 snd-soc-pcm3008-objs := pcm3008.o
 snd-soc-spdif-objs := spdif_transciever.o
 snd-soc-ssm2602-objs := ssm2602.o
@@ -91,6 +92,7 @@ obj-$(CONFIG_SND_SOC_DA7210)	+= snd-soc-da7210.o
 obj-$(CONFIG_SND_SOC_L3)	+= snd-soc-l3.o
 obj-$(CONFIG_SND_SOC_JZ4740_CODEC)	+= snd-soc-jz4740-codec.o
 obj-$(CONFIG_SND_SOC_MAX98088)	+= snd-soc-max98088.o
+obj-$(CONFIG_SND_SOC_MAX98089)	+= snd-soc-max98089.o
 obj-$(CONFIG_SND_SOC_PCM3008)	+= snd-soc-pcm3008.o
 obj-$(CONFIG_SND_SOC_SPDIF)	+= snd-soc-spdif.o
 obj-$(CONFIG_SND_SOC_SSM2602)	+= snd-soc-ssm2602.o
sound/soc/codecs/max98089.c new file +2097 -0

2,097 lines not on this page · raw message

sound/soc/codecs/max98089.h new file +193 -0

193 lines not on this page · raw message

Signature · 1 line
1.5.6.5
#1 lore raw
Quoted 1 line · Jesse Marroquin

This patch adds the initial driver for the MAX98089 CODEC.

I've not read this properly yet but on a first quick scan through this bears a more than passing resemblance to the MAX98088 driver - are there sufficient incompatibilities between the chips to warrant having a separate driver? http://datasheets.maxim-ic.com/en/ds/MAX98088.pdf
would suggest not...

Keeping a single driver means less code to maintain, which is generally a win. Variations between the parts can be accommodated by registering different controls and so on based on the I2C device ID that the system registers.

#2 lore raw

Thanks for pointing out the I2C device ID. After looking at the existing drivers that have multiple I2C IDs, I see that the devices can be uniquely identified. With this we should be able to accommodate both devices with the same driver.

Quoted 14 lines · Mark Brown
Quoted 1 line · Jesse Marroquin

This patch adds the initial driver for the MAX98089 CODEC.

I've not read this properly yet but on a first quick scan through this bears a more than passing resemblance to the MAX98088 driver - are there sufficient incompatibilities between the chips to warrant having a separate driver? http://datasheets.maxim-ic.com/en/ds/MAX98088.pdf
would suggest not...

Keeping a single driver means less code to maintain, which is generally a win. Variations between the parts can be accommodated by registering different controls and so on based on the I2C device ID that the system registers.