Blackfin: bf525-ucr2: new board port
PATCH 1/1 Blackfin: bf525-ucr2: new board port
From: Chong Huang <[email protected]>
--- MAINTAINERS | 5 ++ board/bf525-ucr2/Makefile | 54 ++++++++++++++++++++++ board/bf525-ucr2/bf525-ucr2.c | 16 +++++++ board/bf525-ucr2/config.mk | 32 +++++++++++++ boards.cfg | 1 + include/configs/bf525-ucr2.h | 101 +++++++++++++++++++++++++++++++++++++++++ 6 files changed, 209 insertions(+), 0 deletions(-) create mode 100644 board/bf525-ucr2/Makefile create mode 100644 board/bf525-ucr2/bf525-ucr2.c create mode 100644 board/bf525-ucr2/config.mk create mode 100644 include/configs/bf525-ucr2.h
MAINTAINERS +5 -0
@@ -1094,6 +1094,11 @@ M.Hasewinkel (MHA) <[email protected]> dnp5370 BF537 +Haitao Zhang <[email protected]> +Chong Huang <[email protected]> + + bf525-ucr2 BF525 + ######################################################################### # End of MAINTAINERS list # #########################################################################
board/bf525-ucr2/Makefile new file +54 -0
54 lines not on this page · raw message
board/bf525-ucr2/bf525-ucr2.c new file +16 -0
@@ -0,0 +1,16 @@ +/* U-boot - bf525-ucr2.c board specific routines +* +* (C) Copyright 2000-2004 +* Wolfgang Denk, DENX Software Engineering, wd at denx.de. +* +* Licensed under the GPL-2 or later. +*/ + +#include <common.h> + +int checkboard (void ) +{ +printf ("Board: bf525-ucr2\n" ); +printf ("Support: http://www.ucrobotics.com/\n" ); +return 0 ; +}
board/bf525-ucr2/config.mk new file +32 -0
@@ -0,0 +1,32 @@ +# +# Copyright (c) 2005-2008 Analog Device Inc. +# +# (C) Copyright 2001 +# Wolfgang Denk, DENX Software Engineering, wd at denx.de. +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +# This is not actually used for Blackfin boards so do not change it +#TEXT_BASE = do-not-use-me + +CONFIG_BFIN_CPU = bf525-0.2 + +# Set some default LDR flags based on boot mode. +LDR_FLAGS += $(LDR_FLAGS-$(CONFIG_BFIN_BOOT_MODE))
boards.cfg +1 -0
@@ -163,6 +163,7 @@ mimc200 avr32 at32ap - mimc hammerhead avr32 at32ap - miromico at32ap700x bct-brettl2 blackfin blackfin bf518f-ezbrd blackfin blackfin +bf525-ucr2 blackfin blackfin bf526-ezbrd blackfin blackfin bf527-ad7160-eval blackfin blackfin bf527-ezkit blackfin blackfin
include/configs/bf525-ucr2.h new file +101 -0
101 lines not on this page · raw message
Signature · 1 line
1.7.3.3
PATCH 1/1 Blackfin: bf525-ucr2: new board port
Dear Mike Frysinger,
Quoted 5 lines · In message <[email protected]> you wrote:
From: Chong Huang <[email protected]>
Signed-off-by Chong Huang <[email protected]>Signed-off-by Haitao Zhang <[email protected]>Signed-off-by Mike Frysinger <[email protected]>
...
Quoted 2 lines
board/bf525-ucr2/config.mk new file +0
-0
...
board/bf525-ucr2/config.mk line 32
Quoted 4 lines
board/bf525-ucr2/config.mk new file +4
-0+CONFIG_BFIN_CPU = bf525-0.2 + +# Set some default LDR flags based on boot mode. +LDR_FLAGS += $(LDR_FLAGS-$(CONFIG_BFIN_BOOT_MODE))
Can we not move all this into the board config file, and drop the config.mk ?
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de If today is the first day of the rest of your life, what the hell was yesterday?
PATCH 1/1 Blackfin: bf525-ucr2: new board port
Quoted 10 lines · On Saturday, December 18, 2010 18:14:48 Wolfgang Denk wrote:
board/bf525-ucr2/config.mk line 32
Quoted 6 lines · Mike Frysinger
board/bf525-ucr2/config.mk new file +4
-0+CONFIG_BFIN_CPU = bf525-0.2 + +# Set some default LDR flags based on boot mode. +LDR_FLAGS += $(LDR_FLAGS-$(CONFIG_BFIN_BOOT_MODE))Can we not move all this into the board config file, and drop the config.mk ?
i dont know what you're referring to. the cpu needs to be available before autoconf.mk is generated, and LDR_FLAGS is a build setting that makes more sense to keep in the build .mk.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101218/2ef42ae2/attachment.pgp
PATCH 1/1 Blackfin: bf525-ucr2: new board port
Dear Mike Frysinger,
Quoted 10 lines · In message <[email protected]> you wrote:
Quoted 9 lines
board/bf525-ucr2/config.mk line 32
Quoted 6 lines
+++
b/board/bf525-ucr2/config.mkboard/bf525-ucr2/config.mk new file +4
-0+CONFIG_BFIN_CPU = bf525-0.2 + +# Set some default LDR flags based on boot mode. +LDR_FLAGS += $(LDR_FLAGS-$(CONFIG_BFIN_BOOT_MODE))Can we not move all this into the board config file, and drop the config.mk ?
Quoted 3 lines
i dont know what you're referring to. the cpu needs to be available before autoconf.mk is generated, and
LDR_FLAGSis a build setting that makes more sense to keep in the build .mk.
I want to get rid of all these board specific config.mk files. And I don't see a good reason why it would be needed here. Other boards don;t need any of this either.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de By the way, ALL software projects are done by iterative prototyping. Some companies call their prototypes "releases", that's all.
PATCH 1/1 Blackfin: bf525-ucr2: new board port
Quoted 10 lines · On Sunday, December 19, 2010 07:25:00 Wolfgang Denk wrote:
Quoted 9 lines · Mike Frysinger
Quoted 8 lines
board/bf525-ucr2/config.mk line 32
Quoted 5 lines
+++
b/board/bf525-ucr2/config.mkboard/bf525-ucr2/config.mk new file +4
-0+CONFIG_BFIN_CPU = bf525-0.2 + +# Set some default LDR flags based on boot mode. +LDR_FLAGS += $(LDR_FLAGS-$(CONFIG_BFIN_BOOT_MODE))Can we not move all this into the board config file, and drop the config.mk ?
Quoted 7 lines
Quoted 3 lines
i dont know what you're referring to. the cpu needs to be available before autoconf.mk is generated, and
LDR_FLAGSis a build setting that makes more sense to keep in the build .mk.I want to get rid of all these board specific config.mk files. And I don't see a good reason why it would be needed here. Other boards don;t need any of this either.
then where exactly are boards supposed to specify their own custom build settings ? like optimizations that they want to enable on specific files/subdirs ? many Blackfin boards prefer speed over size in the compression code because we arent hurting for space, and most people prefer the faster decompression at runtime. without a board config.mk, that isnt possible.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101219/de0db56e/attachment.pgp
PATCH 1/1 Blackfin: bf525-ucr2: new board port
Dear Mike Frysinger,
Quoted 7 lines · In message <[email protected]> you wrote:
Quoted 4 lines
I want to get rid of all these board specific config.mk files. And I don't see a good reason why it would be needed here. Other boards don;t need any of this either.
then where exactly are boards supposed to specify their own custom build settings ? like optimizations that they want to enable on specific
Boards should not need custom build rules in the first place.
Quoted 4 lines
files/subdirs ? many Blackfin boards prefer speed over size in the compression code because we arent hurting for space, and most people prefer the faster decompression at runtime. without a board config.mk, that isnt possible.
Can these be gobal settings for all BF boards then?
"not possible" is a strong statement.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Thought for the day: What if there were no hypothetical situations?
PATCH 1/1 Blackfin: bf525-ucr2: new board port
Quoted 9 lines · On Sunday, December 19, 2010 15:09:44 Wolfgang Denk wrote:
Quoted 6 lines · Mike Frysinger
Quoted 3 lines
I want to get rid of all these board specific config.mk files. And I don't see a good reason why it would be needed here. Other boards don;t need any of this either.
then where exactly are boards supposed to specify their own custom build settings ? like optimizations that they want to enable on specific
Boards should not need custom build rules in the first place.
i didnt say build rules, i said settings. that means tweaking things like CFLAGS. none of the Blackfin board config.mk's have custom build rules.
Quoted 6 lines
Quoted 4 lines
files/subdirs ? many Blackfin boards prefer speed over size in the compression code because we arent hurting for space, and most people prefer the faster decompression at runtime. without a board config.mk, that isnt possible.
Can these be gobal settings for all BF boards then?
no, that doesnt make any sense. just because i want some of the boards i maintain to favor speed over size doesnt mean every board maintainer should. thus the settings are in the board-specific config.mk where they should be. -mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101219/d5a694aa/attachment.pgp
PATCH 1/1 Blackfin: bf525-ucr2: new board port
Dear Mike Frysinger,
Quoted 6 lines · In message <[email protected]> you wrote:
Quoted 2 lines
Can these be gobal settings for all BF boards then?
no, that doesnt make any sense. just because i want some of the boards i maintain to favor speed over size doesnt mean every board maintainer should. thus the settings are in the board-specific config.mk where they should be.
We have here:
CONFIG_BFIN_CPU = bf525-0.2 LDR_FLAGS += $(LDR_FLAGS-$(CONFIG_BFIN_BOOT_MODE))
Which these fall into that group?
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Prepare for tomorrow -- get ready. -- Edith Keeler, "The City On the Edge of Forever", stardate unknown
PATCH 1/1 Blackfin: bf525-ucr2: new board port
Quoted 8 lines · On Sunday, December 19, 2010 16:20:15 Wolfgang Denk wrote:
Quoted 6 lines · Mike Frysinger
Quoted 1 line
Can these be gobal settings for all BF boards then?
no, that doesnt make any sense. just because i want some of the boards i maintain to favor speed over size doesnt mean every board maintainer should. thus the settings are in the board-specific config.mk where they should be.
Quoted 6 lines
We have here:
CONFIG_BFIN_CPU = bf525-0.2 LDR_FLAGS += $(LDR_FLAGS-$(CONFIG_BFIN_BOOT_MODE))Which these fall into that group?
i dont understand the question, so i'll just spout random noise.
the LDR_FLAGS-y convention is board specific and is only set in boards' config.mk. i could unify that convention across all Blackfin boards and move this one specific line to the common Blackfin config.mk, but that still wouldnt change the requirement of a board specific config.mk to set up custom LDR_FLAGS for its specific boot modes. which some Blackfin boards need.
as for the cpu selection, obviously that cannot be in any common file since the cpu variant and silicon rev is about as board specific as you could possibly get.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101219/a8406a8d/attachment.pgp
PATCH 1/1 Blackfin: bf525-ucr2: new board port
Dear Mike Frysinger,
Quoted 6 lines · In message <[email protected]> you wrote:
Quoted 6 lines
Quoted 5 lines
no, that doesnt make any sense. just because i want some of the boards i maintain to favor speed over size doesnt mean every board maintainer should. thus the settings are in the board-specific config.mk where they should be.
Quoted 8 lines
Quoted 6 lines
We have here:
CONFIG_BFIN_CPU = bf525-0.2 LDR_FLAGS += $(LDR_FLAGS-$(CONFIG_BFIN_BOOT_MODE))Which these fall into that group?
i dont understand the question, so i'll just spout random noise.
Well, your argument was the need to provide board or file specific optimizer options to "favor speed over size ...". To me it seems this argument has nothing to do with what the definitions above are doing.
Quoted 3 lines
the LDR_FLAGS-y convention is board specific and is only set in boards' config.mk. i could unify that convention across all Blackfin boards and move this one specific line to the common Blackfin config.mk, but that still
OK, then please let's do this. I guess this will allow to remove a number of other config.mk files as well.
Quoted 2 lines
wouldnt change the requirement of a board specific config.mk to set up custom
LDR_FLAGSfor its specific boot modes. which some Blackfin boards need.
Such config.mk files that are really needed (i. e. for which no easy other approach exists) may remain.
Quoted 3 lines
as for the cpu selection, obviously that cannot be in any common file since the cpu variant and silicon rev is about as board specific as you could possibly get.
And why cannot it be set in the board config file like every other board doing it?
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de You Earth people glorified organized violence for forty centuries. But you imprison those who employ it privately. -- Spock, "Dagger of the Mind", stardate 2715.1
PATCH 1/1 Blackfin: bf525-ucr2: new board port
Quoted 10 lines · On Monday, December 20, 2010 05:49:22 Wolfgang Denk wrote:
Quoted 9 lines · Mike Frysinger
Quoted 9 lines
Quoted 4 lines
no, that doesnt make any sense. just because i want some of the boards i maintain to favor speed over size doesnt mean every board maintainer should. thus the settings are in the board-specific config.mk where they should be.
We have here:
CONFIG_BFIN_CPU = bf525-0.2 LDR_FLAGS += $(LDR_FLAGS-$(CONFIG_BFIN_BOOT_MODE))
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Which these fall into that group?
i dont understand the question, so i'll just spout random noise.
Well, your argument was the need to provide board or file specific optimizer options to "favor speed over size ...". To me it seems this argument has nothing to do with what the definitions above are doing.
i was responding to your *general* statement that you wish to get rid of all board config.mk's. and my simple response that this goal is not feasible. so to back up my statement with fact, i gave real world examples that are not attainable if you punt all board config.mk's.
Quoted 7 lines
Quoted 4 lines
the LDR_FLAGS-y convention is board specific and is only set in boards' config.mk. i could unify that convention across all Blackfin boards and move this one specific line to the common Blackfin config.mk, but that still
OK, then please let's do this. I guess this will allow to remove a number of other config.mk files as well.
np
Quoted 6 lines
Quoted 3 lines
as for the cpu selection, obviously that cannot be in any common file since the cpu variant and silicon rev is about as board specific as you could possibly get.
And why cannot it be set in the board config file like every other board doing it?
ive explained in the past why. one of the reasons why i think config.mk makes more sense is this setting is only used for compilation (build flags). it isnt used directly anywhere in the config.h or related code. i also find it significantly cleaner than the cpu handling as found in the arm or m68k or ppc ports where copy & pasting swaths of code is the rule.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101220/22e5b3fd/attachment.pgp
PATCH 1/1 Blackfin: bf525-ucr2: new board port
Dear Mike Frysinger,
Quoted 4 lines · In message <[email protected]> you wrote:
Quoted 4 lines
Quoted 4 lines
as for the cpu selection, obviously that cannot be in any common file since the cpu variant and silicon rev is about as board specific as you could possibly get.
I did not ask for moving it into a common file, but into the board config file.
Quoted 8 lines
Quoted 2 lines
And why cannot it be set in the board config file like every other board doing it?
ive explained in the past why. one of the reasons why i think config.mk makes more sense is this setting is only used for compilation (build flags). it isnt used directly anywhere in the
config.hor related code. i also find it significantly cleaner than the cpu handling as found in the arm or m68k or ppc ports where copy & pasting swaths of code is the rule.
OK, so this is a "I think it makes more sense" and a "I find it cleaner". There was no "cannot", as far as I can tell.
I think it makes a lot of sense to try and move all board specific configuration settings into a single file (the board config file); this will, among other things, make it easier to make such settings accessable through some config tool - assume somebody wants to take steps toward Kconfig or such.
So please get rid of this config.mk file.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de In accord with UNIX philosophy, Perl gives you enough rope to hang yourself. - L. Wall & R. L. Schwartz, _Programming Perl_
PATCH 1/1 Blackfin: bf525-ucr2: new board port
Quoted 11 lines · On Monday, December 20, 2010 16:05:20 Wolfgang Denk wrote:
Quoted 9 lines · Mike Frysinger
Quoted 2 lines
And why cannot it be set in the board config file like every other board doing it?
ive explained in the past why. one of the reasons why i think config.mk makes more sense is this setting is only used for compilation (build flags). it isnt used directly anywhere in the
config.hor related code.
i also find it significantly cleaner than the cpu handling as found in
the arm or m68k or ppc ports where copy & pasting swaths of code is the rule.
Quoted 2 lines
OK, so this is a "I think it makes more sense" and a "I find it cleaner". There was no "cannot", as far as I can tell.
things can be moved back, but it would require ugly hacks in the Blackfin code to pull it back out. if you want to live with the ugly hacks as a trade off of getting rid of a few more Blackfin config.mk's (but not all), then that is possible.
note that these issues shouldnt hold up merging a board which is working the way it should as the other boards.
Quoted 5 lines
I think it makes a lot of sense to try and move all board specific configuration settings into a single file (the board config file); this will, among other things, make it easier to make such settings accessable through some config tool - assume somebody wants to take steps toward
Kconfigor such.
i dont see how Kconfig would be relevant. the point of Kconfig is to let users configure optional features, not aspects burned into hardware. letting people pick a processor that isnt on the board makes no sense. linux specifically has followed this style -- the way the board is physically wired up is in the platform resources, not Kconfig.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101220/ed1ee832/attachment.pgp
PATCH 1/1 Blackfin: bf525-ucr2: new board port
Dear Mike Frysinger,
Quoted 3 lines · In message <[email protected]> you wrote:
note that these issues shouldnt hold up merging a board which is working the way it should as the other boards.
I have nothing to add. Please get rid of this unnecessary config.mk file.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de It is easier to write an incorrect program than understand a correct one.
PATCH 1/1 Blackfin: bf525-ucr2: new board port
Quoted 5 lines · On Monday, December 20, 2010 17:56:38 Wolfgang Denk wrote:
Quoted 2 lines · Mike Frysinger
note that these issues shouldnt hold up merging a board which is working the way it should as the other boards.
I have nothing to add. Please get rid of this unnecessary config.mk file.
so you agree with my statement, or you're going to prevent any new Blackfin boards from being merged until something you consider a deficiency in the core (and really a board independent issue) is resolved ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101220/450c4cac/attachment.pgp
PATCH 1/1 Blackfin: bf525-ucr2: new board port
Dear Mike Frysinger,
Quoted 6 lines · In message <[email protected]> you wrote:
Quoted 2 lines
I have nothing to add. Please get rid of this unnecessary config.mk file.
so you agree with my statement, or you're going to prevent any new Blackfin boards from being merged until something you consider a deficiency in the core (and really a board independent issue) is resolved ?
I will NAK submissions that include unnecessary config.mk files.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Oh dear, I think you'll find reality's on the blink again." - Marvin The Paranoid Android
PATCH 1/1 Blackfin: bf525-ucr2: new board port
Quoted 10 lines · On Tuesday, December 21, 2010 00:37:24 Wolfgang Denk wrote:
Quoted 7 lines · Mike Frysinger
Quoted 2 lines
I have nothing to add. Please get rid of this unnecessary config.mk file.
so you agree with my statement, or you're going to prevent any new Blackfin boards from being merged until something you consider a deficiency in the core (and really a board independent issue) is resolved ?
I will NAK submissions that include unnecessary config.mk files.
unnecessary in your opinion of course
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101222/ce87b6c9/attachment.pgp