ppp: allow disabling multilink protocol ID compression
Subsystems (3)
PATCH 1/1 ppp: allow disabling multilink protocol ID compression
Linux would not connect to other router running old version Cisco IOS (12.0). This is most likely a bug in that version of IOS, since it is fixed in later versions. As a workaround this patch allows a module parameter to be set to disable compressing the protocol ID.
See: https://bugzilla.vyatta.com/show_bug.cgi?id979
RFC 1990 allows an implementation to formulate MP fragments as if protocol compression had been negotiated. This allows us to always send compressed protocol IDs. But some implementations don't accept MP fragments with compressed protocol IDs. This parameter allows us to interoperate with them. The default value of the configurable parameter is the same as the current behavior: protocol compression is enabled. If protocol compression is disabled we will not send compressed protocol IDs.
This is based on an earlier patch by Bob Gilligan (using a sysctl). Module parameter is writable to allow for enabling even if ppp is already loaded for other uses.
drivers/net/ppp_generic.c +7 -2
@@ -1283,6 +1283,11 @@ ppp_push(struct ppp *ppp) }#ifdef CONFIG_PPP_MULTILINK +static bool mp_protocol_compress__read_mostly = true; +module_param (mp_protocol_compress, bool,S_IRUGO |S_IWUSR ); +MODULE_PARM_DESC (mp_protocol_compress, +"compress protocol id in multilink fragments" ); +/* * Divide a packet to be transmitted into fragments and * send them out the individual links.
@@ -1345,10 +1350,10 @@ static int ppp_mp_explode(struct ppp *ppif (nfree =0 || nfree < navail /2 )return 0 ;/* can't take now, leave it in xmit_pending */ -/* Do protocol field compression (XXX this should be optional) */ +/* Do protocol field compression */ p = skb->data; len = skb->len; -if (*p =0 ) { +if (*p =0 && mp_protocol_compress) { ++p; --len; }
Quoted 15 lines · Stephen Hemminger
Linux would not connect to other router running old version Cisco IOS (12.0). This is most likely a bug in that version of IOS, since it is fixed in later versions. As a workaround this patch allows a module parameter to be set to disable compressing the protocol ID.
See: https://bugzilla.vyatta.com/show_bug.cgi?id979
RFC 1990 allows an implementation to formulate MP fragments as if protocol compression had been negotiated. This allows us to always send compressed protocol IDs. But some implementations don't accept MP fragments with compressed protocol IDs. This parameter allows us to interoperate with them. The default value of the configurable parameter is the same as the current behavior: protocol compression is enabled. If protocol compression is disabled we will not send compressed protocol IDs.
Quoted 5 lines
This is based on an earlier patch by Bob Gilligan (using a sysctl). Module parameter is writable to allow for enabling even if ppp is already loaded for other uses.
Signed-off-by Stephen Hemminger <[email protected]>
Quoted 15 lines · Stephen Hemminger
Linux would not connect to other router running old version Cisco IOS (12.0). This is most likely a bug in that version of IOS, since it is fixed in later versions. As a workaround this patch allows a module parameter to be set to disable compressing the protocol ID.
See: https://bugzilla.vyatta.com/show_bug.cgi?id979
RFC 1990 allows an implementation to formulate MP fragments as if protocol compression had been negotiated. This allows us to always send compressed protocol IDs. But some implementations don't accept MP fragments with compressed protocol IDs. This parameter allows us to interoperate with them. The default value of the configurable parameter is the same as the current behavior: protocol compression is enabled. If protocol compression is disabled we will not send compressed protocol IDs.
Quoted 5 lines
This is based on an earlier patch by Bob Gilligan (using a sysctl). Module parameter is writable to allow for enabling even if ppp is already loaded for other uses.
Signed-off-by Stephen Hemminger <[email protected]>
From: Paul Mackerras <[email protected]>
Date: Wed, 22 Dec 2010 09:44:00 +1100
Quoted 17 lines · Stephen Hemminger
Quoted 16 lines
Linux would not connect to other router running old version Cisco IOS (12.0). This is most likely a bug in that version of IOS, since it is fixed in later versions. As a workaround this patch allows a module parameter to be set to disable compressing the protocol ID.
See: https://bugzilla.vyatta.com/show_bug.cgi?id979
RFC 1990 allows an implementation to formulate MP fragments as if protocol compression had been negotiated. This allows us to always send compressed protocol IDs. But some implementations don't accept MP fragments with compressed protocol IDs. This parameter allows us to interoperate with them. The default value of the configurable parameter is the same as the current behavior: protocol compression is enabled. If protocol compression is disabled we will not send compressed protocol IDs.
Quoted 7 lines
Quoted 5 lines
This is based on an earlier patch by Bob Gilligan (using a sysctl). Module parameter is writable to allow for enabling even if ppp is already loaded for other uses.
Signed-off-by Stephen Hemminger <[email protected]>Acked-by Paul Mackerras <[email protected]>
Applied, thanks.