Skip to contentSkip to conversation

removed ad-hoc cmdline default

PATCH In review Robert Millan 2 participants 3 messages Nov 7, 2010 – Jan 24, 2011 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 removed ad-hoc cmdline default

Loongson builds have an ad-hoc cmdline default of "console=ttyS0,115200 root=/dev/hda1". These settings come from vendor (I remember builds from Lemote branch requiring a "console=tty" override in order to get a working console).

At least on my Yeeloong, they're particularly useless: there's no (external) serial port, and the IDE drive is now recognised as /dev/ sda.

I recommend removing them. They make sense from a distributor/vendor POV but otherwise are just a nuissance.

Remove ad-hoc cmdline settings.

arch/mips/loongson/common/cmdline.c +0 -5
index 1a06def..353e1d2 100644
@@ -44,10 +44,5 @@ void __init prom_init_cmdline(void)
 		strcat(arcs_cmdline, " ");
 	}
 
-	if ((strstr(arcs_cmdline, "console=")) == NULL)
-		strcat(arcs_cmdline, " console=ttyS0,115200");
-	if ((strstr(arcs_cmdline, "root=")) == NULL)
-		strcat(arcs_cmdline, " root=/dev/hda1");
-
 	prom_init_machtype();
 }
#1 lore raw
Quoted 11 lines · Robert Millan

Loongson builds have an ad-hoc cmdline default of "console=ttyS0,115200 root=/dev/hda1". These settings come from vendor (I remember builds from Lemote branch requiring a "console=tty" override in order to get a working console).

At least on my Yeeloong, they're particularly useless: there's no (external) serial port, and the IDE drive is now recognised as /dev/ sda.

I recommend removing them. They make sense from a distributor/vendor POV but otherwise are just a nuissance.

Makes sense to me but I'm not an authoritative expert for all Loongson platforms so I'm going to wait for comments for a few days before I'm going to apply this.

Generally forcing options like this is just a bad idea.

Ralf