Skip to contentSkip to conversation

libxl regression: don't require vncpasswd when empty

PATCH Applied Christoph Egger 2 participants 2 messages Feb 18, 2011

lore
Share & tools
lore

Christoph Egger

author
#0 lore raw

PATCH 1/1 libxl regression: don't require vncpasswd when empty

Hi, this is a resending as a reminder!

Attached patch fixes a regression introduced in c/s 22866:ed9ef3b07d2a:

Don't require a NULL-byte password when the guest config file has the entry
vncpasswd=''

Signed-off-by Christoph Egger <[email protected]>
Signature · 6 lines
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
tools/libxl/libxl_dm.c +1 -1
diff -r 12de39a2c580 tools/libxl/libxl_dm.c
@@ -74,7 +74,7 @@ static char ** libxl_build_device_model_
         } else {
             vncarg = "127.0.0.1:0";
         }
-        if (info->vncpasswd)
+        if (info->vncpasswd && (info->vncpasswd[0] != '\0'))
             vncarg = libxl__sprintf(gc, "%s,password", vncarg);
         flexarray_append(dm_args, "-vnc");
         flexarray_append(dm_args, vncarg);

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Applied
#1 lore raw

Christoph Egger writes ("[Xen-devel] [PATCH] libxl regression: don't require vncpasswd when empty"):

Quoted 3 lines

Don't require a NULL-byte password when the guest config file has the entry
vncpasswd=''

I've applied this, thanks.

Ian.