Skip to contentSkip to conversation

2.6.39 breaks floppy

bisected Ondrej Zary 3 participants 3 messages May 25, 2011

lore
Share & tools
lore

Ondrej Zary

author
#0 lore raw

Hello,
floppy stopped working in 2.6.39 (confirmed on two machines). 2.6.38 worked fine.
/dev/fd0 is created but does not work (mdir says: "No such device or address", mount says "/dev/fd0 is not a valid block device"). dmesg shows no errors:

Floppy drive(s): fd0 is 1.44M
FDC 0 is a post-1991 82077

Bisected it to 9fd097b14918875bd6f125ed699d7bbbba5893ee (block: unexport DISK_EVENT_MEDIA_CHANGE for legacy/fringe drivers)

Adding the removed line back to floppy.c fixes the problem.

Signature · 1 line
Ondrej Zary
#1 lore raw
Quoted 6 lines · Ondrej Zary

Hello,
floppy stopped working in 2.6.39 (confirmed on two machines). 2.6.38 worked fine.
/dev/fd0 is created but does not work (mdir says: "No such device or address", mount says "/dev/fd0 is not a valid block device"). dmesg shows no errors:

Quoted 7 lines

Floppy drive(s): fd0 is 1.44M
FDC 0 is a post-1991 82077

Bisected it to 9fd097b14918875bd6f125ed699d7bbbba5893ee (block: unexport DISK_EVENT_MEDIA_CHANGE for legacy/fringe drivers)

Adding the removed line back to floppy.c fixes the problem.

Tejun?

Signature · 1 line
Jens Axboe
#2 lore raw

Hello,

Quoted 4 lines · Jens Axboe
Quoted 4 lines

Bisected it to 9fd097b14918875bd6f125ed699d7bbbba5893ee (block: unexport DISK_EVENT_MEDIA_CHANGE for legacy/fringe drivers)

Adding the removed line back to floppy.c fixes the problem.

It's the same one as the following. Patch posted. It's caused by genhd->ev not allocated when ->events | async_events is empty.

https://bugzilla.kernel.org/show_bug.cgi?id=35832

Will soon post a patch.

Thanks.

Signature · 1 line
tejun