New packages: acl and attr

PATCH Superseded Yegor Yefremov 2 participants 2 messages Jun 28, 2011 – Jul 11, 2011

Share & tools

Yegor Yefremov

author

2011-06-28 13:11 UTC #0 lore raw

PATCH v2 1/1 New packages: acl and attr

In addition to providing the acl and extended attributes functionality, these new packages satisfy newer udev versions, so you can build all extras.

Signed-off-by Heiko Zuerker <[email protected]>

Signed-off-by Daniel Mack <[email protected]>

Signed-off-by Yegor Yefremov <[email protected]>

---
 package/Config.in      |    2 ++
 package/acl/Config.in  |   11 +++++++++++
 package/acl/acl.mk     |   18 ++++++++++++++++++
 package/attr/Config.in |    7 +++++++
 package/attr/attr.mk   |   17 +++++++++++++++++
 5 files changed, 55 insertions(+)
 create mode 100644 package/acl/Config.in
 create mode 100644 package/acl/acl.mk
 create mode 100644 package/attr/Config.in
 create mode 100644 package/attr/attr.mk

package/Config.in +2 -0

Index: b/package/Config.in
===================================================================
@@ -487,6 +487,8 @@
 endmenu
 
 menu "System tools"
+source "package/acl/Config.in"
+source "package/attr/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/bootutils/Config.in"
 endif

package/acl/Config.in new file +11 -0

Index: b/package/acl/Config.in
===================================================================
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_ACL
+	bool "acl"
+	select BR2_PACKAGE_ATTR
+	help
+	  POSIX Access Control Lists, which are used to define more
+	  fine-grained discretionary access rights for files and
+	  directories.
+	  This package also provides libacl.
+
+comment "acl requires attr to be built"
+        depends on !BR2_PACKAGE_ATTR

package/acl/acl.mk new file +18 -0

Index: b/package/acl/acl.mk
===================================================================
@@ -0,0 +1,18 @@
+#############################################################
+#
+# acl
+#
+#############################################################
+
+ACL_VERSION = 2.2.49
+ACL_SOURCE := acl_$(ACL_VERSION).orig.tar.gz
+ACL_SITE = http://ftp.debian.org/debian/pool/main/a/acl
+ACL_INSTALL_STAGING = YES
+ACL_DEPENDENCIES = attr
+ACL_CONF_OPT = --enable-gettext=no
+
+# override installation paths, due to non-conform installation routine
+ACL_INSTALL_STAGING_OPT = prefix=$(STAGING_DIR)/usr exec_prefix=$(TARGET_DIR)/usr PKG_DEVLIB_DIR=$(STAGING_DIR)/usr/lib install-dev install-lib
+ACL_INSTALL_TARGET_OPT = prefix=$(TARGET_DIR)/usr exec_prefix=$(TARGET_DIR)/usr install install-lib
+
+$(eval $(call AUTOTARGETS,package,acl))

package/attr/Config.in new file +7 -0

Index: b/package/attr/Config.in
===================================================================
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_ATTR
+	bool "attr"
+	help
+	  Extended attributes are name:value pairs associated permanently with
+	  files and directories, similar to the environment strings associated
+	  with a process
+	  This package also provides libattr.

package/attr/attr.mk new file +17 -0

Index: b/package/attr/attr.mk
===================================================================
@@ -0,0 +1,17 @@
+#############################################################
+#
+# attr
+#
+#############################################################
+
+ATTR_VERSION = 2.4.46
+ATTR_SOURCE := attr_$(ATTR_VERSION).orig.tar.gz
+ATTR_SITE = http://ftp.debian.org/debian/pool/main/a/attr
+ATTR_INSTALL_STAGING = YES
+ATTR_CONF_OPT = --enable-gettext=no
+
+# override installation paths, due to non-conform installation routine
+ATTR_INSTALL_STAGING_OPT = prefix=$(STAGING_DIR)/usr exec_prefix=$(STAGING_DIR)/usr PKG_DEVLIB_DIR=$(STAGING_DIR)/usr/lib install-dev install-lib
+ATTR_INSTALL_TARGET_OPT = prefix=$(TARGET_DIR)/usr exec_prefix=$(TARGET_DIR)/usr install install-lib
+
+$(eval $(call AUTOTARGETS,package,attr))

Thomas Petazzoni

2011-07-11 22:11 UTC #1 lore raw

PATCH v2 1/1 New packages: acl and attr

Le Tue, 28 Jun 2011 15:11:34 +0200,
Yegor Yefremov <[email protected]> a ?crit :

package/acl/Config.in line 11

Quoted 2 lines

package/acl/Config.in new file +2 -0

+comment "acl requires attr to be built"
+        depends on !BR2_PACKAGE_ATTR

Please get rid of this, as ATTR selects ACL, so ATTR is always visible, and will automatically select ACL if enabled.

package/acl/acl.mk line 8

Quoted 13 lines

Index: b/package/acl/acl.mk
===================================================================
package/acl/acl.mk new file +8 -0
@@ -0,0 +1,18 @@
+#############################################################
+#
+# acl
+#
+#############################################################
+
+ACL_VERSION = 2.2.49
+ACL_SOURCE := acl_$(ACL_VERSION).orig.tar.gz

Use = instead of :=

package/acl/acl.mk line 14

Quoted 6 lines

package/acl/acl.mk new file +6 -0

+ACL_SITE = http://ftp.debian.org/debian/pool/main/a/acl
+ACL_INSTALL_STAGING = YES
+ACL_DEPENDENCIES = attr
+ACL_CONF_OPT = --enable-gettext=no
+
+# override installation paths, due to non-conform installation routine

Could you change the comment to something like :

# While the configuration system uses autoconf, the Makefiles are

# hand-written and do not use automake. Therefore, we have to hack
# around their deficiencies by passing installation paths.

(or something similar, at least mentioning that the root of the problem is that automake isn't used).

package/acl/acl.mk line 16

Quoted 2 lines

package/acl/acl.mk new file +2 -0

+ACL_INSTALL_STAGING_OPT = prefix=$(STAGING_DIR)/usr exec_prefix=$(TARGET_DIR)/usr PKG_DEVLIB_DIR=$(STAGING_DIR)/usr/lib install-dev install-lib
+ACL_INSTALL_TARGET_OPT = prefix=$(TARGET_DIR)/usr exec_prefix=$(TARGET_DIR)/usr install install-lib

Maybe :

ACL_COMMON_INSTALL_OPTS = 		\
	prefix=$(STAGING_DIR)/usr 	\
	exec_prefix=$(TARGET_DIR)/usr

ACL_INSTALL_STAGING_OPT = 			\
	$(ACL_COMMON_INSTALL_OPTS)		\
	PKG_DEVLIB_DIR=$(STAGING_DIR)/usr/lib	\
	install-dev install-lib

ACL_INSTALL_TARGET_OPT =

	$(ACL_COMMON_INSTALL_OPTS)		\
	PKG_DEVLIB_DIR=$(STAGING_DIR)/usr/lib	\
	install install-lib

package/acl/acl.mk line 18

Quoted 2 lines

package/acl/acl.mk new file +2 -0

+ATTR_VERSION = 2.4.46
+ATTR_SOURCE := attr_$(ATTR_VERSION).orig.tar.gz

= instead of :=

package/acl/acl.mk

Quoted 3 lines

package/acl/acl.mk new file +3 -0

+# override installation paths, due to non-conform installation routine
+ATTR_INSTALL_STAGING_OPT = prefix=$(STAGING_DIR)/usr exec_prefix=$(STAGING_DIR)/usr PKG_DEVLIB_DIR=$(STAGING_DIR)/usr/lib install-dev install-lib
+ATTR_INSTALL_TARGET_OPT = prefix=$(TARGET_DIR)/usr exec_prefix=$(TARGET_DIR)/usr install install-lib

Same as previous package.

Thomas

Signature · 4 lines

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com