ucm: fix seg fault in execute_cset()
PATCH 1/2 ucm: fix seg fault in execute_cset()
When there's no space in 'cset', 'pos' gets NULL, dereferencing 'pos' gets a seg fault. We need to be more robust.
Signed-off-by Lu Guanqun <[email protected]>
--- src/ucm/main.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
src/ucm/main.c +2 -1
@@ -196,7 +196,8 @@ static int execute_cset(snd_ctl_t *ctl, char *cset) goto __fail; err =0 ; __fail: - *pos =' ' ; +if (pos !=NULL ) + *pos =' ' ;if (id !=NULL )free (id);
PATCH 2/2 ucm: tivial code style fix
Signed-off-by Lu Guanqun <[email protected]>
--- src/ucm/main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
src/ucm/main.c +1 -1
@@ -173,7 +173,7 @@ static int execute_cset(snd_ctl_t *ctl, char *cset) pos =strrchr (cset,' ' );if (pos ==NULL ) {uc_error ("undefined value for cset >%s<" , cset); - err = -EINVAL ; + err = -EINVAL ; goto __fail; } *pos ='\0' ;
Takashi Iwai
AppliedAt Fri, 19 Aug 2011 16:05:25 +0800,
Quoted 5 lines · Lu Guanqun
When there's no space in 'cset', 'pos' gets NULL, dereferencing 'pos' gets a seg fault. We need to be more robust.
Signed-off-by Lu Guanqun <[email protected]>
Thanks, applied both now.
Takashi
Quoted 19 lines
--- src/ucm/main.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)src/ucm/main.c +2
-1@@ -196,7 +196,8 @@ static int execute_cset(snd_ctl_t *ctl, char *cset) goto __fail; err =0 ; __fail: - *pos =' ' ; +if (pos !=NULL ) + *pos =' ' ;if (id !=NULL )free (id);