commit e978aa7d7d57d04eb5f88 breaks suspend on laptop.
Arnd Bergmann
Tested-byQuoted 2 lines · Rafael J. Wysocki
If that's "
acpi_idle", the appended patch should help (it works for me at least).
Hi Rafael,
I currently have limited email connectivity but I happened to bisect the same bug and your patch fixes it for me. I am certainly on acpi_idle with my thinkpad w500.
Sorry for breaking the email threading and dropping people from Cc.
Quoted 11 lines
From: Rafael J. Wysocki <[email protected]>
Subject: ACPI / cpuidle: Removeacpi_idle_suspend(to fix suspend regression) After commite978aa7d7d57d04eb5f88a7507c4fb98577def77(cpuidle: Movedev->last_residencyupdate to driver enter routine; removedev->last_state) settingacpi_idle_suspendto 1 byacpi_processor_suspend()causes the ACPI cpuidle routines to return error codes continuously, which in turn causes cpuidle to lock up (hard). However,acpi_idle_suspenddoesn't appear to be useful for any purpose (it's racy and doesn't really provide any real protection), so it can be removed, which makes the problem go away.
Quoted 1 line
Signed-off-by Rafael J. Wysocki <[email protected]>
Arnd
Quoted 9 lines · Arnd Bergmann
Quoted 2 lines · Rafael J. Wysocki
If that's "
acpi_idle", the appended patch should help (it works for me at least).Hi Rafael,
I currently have limited email connectivity but I happened to bisect the same bug and your patch fixes it for me. I am certainly on
acpi_idlewith my thinkpad w500.
Yes, I'm quite sure everyone on acpi_idle is affected by this bug.
Quoted 1 line
Sorry for breaking the email threading and dropping people from Cc.
No problem.
Quoted 11 lines
Quoted 11 lines
From: Rafael J. Wysocki <[email protected]>
Subject: ACPI / cpuidle: Removeacpi_idle_suspend(to fix suspend regression) After commite978aa7d7d57d04eb5f88a7507c4fb98577def77(cpuidle: Movedev->last_residencyupdate to driver enter routine; removedev->last_state) settingacpi_idle_suspendto 1 byacpi_processor_suspend()causes the ACPI cpuidle routines to return error codes continuously, which in turn causes cpuidle to lock up (hard). However,acpi_idle_suspenddoesn't appear to be useful for any purpose (it's racy and doesn't really provide any real protection), so it can be removed, which makes the problem go away.
Quoted 3 lines
Quoted 1 line
Signed-off-by Rafael J. Wysocki <[email protected]>Tested-by Arnd Bergmann <[email protected]>
Thanks for the info. Unfortunately, I've already resent the patch without your Tested-by: tag, but it can still be added when the patch is committed.
Rafael
Quoted 3 lines · Rafael J. Wysocki
Thanks for the info. Unfortunately, I've already resent the patch without your Tested-by: tag, but it can still be added when the patch is committed.
Added, committed, and pushed out,
Linus
Quoted 6 lines · Linus Torvalds
Quoted 3 lines · Rafael J. Wysocki
Thanks for the info. Unfortunately, I've already resent the patch without your Tested-by: tag, but it can still be added when the patch is committed.
Added, committed, and pushed out,
Thanks a lot!
Rafael