Skip to contentSkip to conversation

commit e978aa7d7d57d04eb5f88 breaks suspend on laptop.

bisected Arnd Bergmann 3 participants 4 messages Nov 12, 2011 – Nov 13, 2011

lore
Share & tools
lore

Arnd Bergmann

author Tested-by
#0 lore raw
Quoted 2 lines · Rafael J. Wysocki

If that's "acpi_idle", the appended patch should help (it works for me at least).

Hi Rafael,

I currently have limited email connectivity but I happened to bisect the same bug and your patch fixes it for me. I am certainly on acpi_idle with my thinkpad w500.

Sorry for breaking the email threading and dropping people from Cc.

Quoted 11 lines

From: Rafael J. Wysocki <[email protected]>
Subject: ACPI / cpuidle: Remove acpi_idle_suspend (to fix suspend regression) After commit e978aa7d7d57d04eb5f88a7507c4fb98577def77 (cpuidle: Move dev->last_residency update to driver enter routine; remove dev->last_state) setting acpi_idle_suspend to 1 by acpi_processor_suspend() causes the ACPI cpuidle routines to return error codes continuously, which in turn causes cpuidle to lock up (hard). However, acpi_idle_suspend doesn't appear to be useful for any purpose (it's racy and doesn't really provide any real protection), so it can be removed, which makes the problem go away.

Quoted 1 line

Arnd

#1 lore raw
Quoted 9 lines · Arnd Bergmann
Quoted 2 lines · Rafael J. Wysocki

If that's "acpi_idle", the appended patch should help (it works for me at least).

Hi Rafael,

I currently have limited email connectivity but I happened to bisect the same bug and your patch fixes it for me. I am certainly on acpi_idle with my thinkpad w500.

Yes, I'm quite sure everyone on acpi_idle is affected by this bug.

Quoted 1 line

Sorry for breaking the email threading and dropping people from Cc.

No problem.

Quoted 11 lines
Quoted 11 lines

From: Rafael J. Wysocki <[email protected]>
Subject: ACPI / cpuidle: Remove acpi_idle_suspend (to fix suspend regression) After commit e978aa7d7d57d04eb5f88a7507c4fb98577def77 (cpuidle: Move dev->last_residency update to driver enter routine; remove dev->last_state) setting acpi_idle_suspend to 1 by acpi_processor_suspend() causes the ACPI cpuidle routines to return error codes continuously, which in turn causes cpuidle to lock up (hard). However, acpi_idle_suspend doesn't appear to be useful for any purpose (it's racy and doesn't really provide any real protection), so it can be removed, which makes the problem go away.

Quoted 3 lines
Quoted 1 line

Thanks for the info. Unfortunately, I've already resent the patch without your Tested-by: tag, but it can still be added when the patch is committed.

Rafael

#2 lore raw
Quoted 3 lines · Rafael J. Wysocki

Thanks for the info.  Unfortunately, I've already resent the patch without your Tested-by: tag, but it can still be added when the patch is committed.

Added, committed, and pushed out,

Linus

#3 lore raw
Quoted 6 lines · Linus Torvalds
Quoted 3 lines · Rafael J. Wysocki

Thanks for the info. Unfortunately, I've already resent the patch without your Tested-by: tag, but it can still be added when the patch is committed.

Added, committed, and pushed out,

Thanks a lot!

Rafael