Seeing as alot of ath9k devices is PCI/PCIe or their mini equivalent it makes sense to set ATH9K_PCI to y by default
PATCH 1/1 Seeing as alot of ath9k devices is PCI/PCIe or their mini equivalent it makes sense to set ATH9K_PCI to y by default
from: Daniel Kuehn <[email protected]>
Most ath9k devices are PCI/PCIe based, therefor making PCI/PCIe support default y helps those porting a config from 2.6 kernel series from getting "non-functional" wireless drivers with 3.x kernel series.
--- drivers/net/wireless/ath/ath9k/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
(quoted diff) +0 -0
b/drivers/net/wireless/ath/ath9k/Kconfig index d9c08c6..7b4c074 100644
drivers/net/wireless/ath/ath9k/Kconfig +1 -0
@@ -25,6 +25,7 @@ config ATH9K config ATH9K_PCI bool "Atheros ath9k PCI/PCIe bus support" + default y depends on ATH9K && PCI ---help--- This option enables the PCI bus support in ath9k.
Signature · 1 line
1.7.7.2
PATCH 1/1 Seeing as alot of ath9k devices is PCI/PCIe or their mini equivalent it makes sense to set ATH9K_PCI to y by default
2011.11.09. 23:57 keltez?ssel, Daniel Kuehn ?rta:
Quoted 7 lines
from: Daniel Kuehn <[email protected]>
Most ath9k devices are PCI/PCIe based, therefor making PCI/PCIe support default y helps those porting a config from 2.6 kernel series from getting "non-functional" wireless drivers with 3.x kernel series.
Signed-off-by Daniel Kuehn <[email protected]>
The option was enabled in the past but it has been removed a few months ago by the following commit:
commit 64bd0821a3b66c3307d7a4ee5523e3e35ec2df0e
Author: Tao Ma <[email protected]> Date: Wed May 25 09:44:05 2011 +0800
wireless: Default to 'n' for 2 new added devices in Kconfig.
We make oldconfig every time when a new kernel arrives, but if we don't have such a device(I guess this is the most common case for a new device), the default value should be 'n' so that the kernel size we build doesn't grow up too much quickly. For anyone who has the device, it is OK for them to turn it on by themselves.
In my opinion it should not be added again.
Regards,
Gabor
PATCH 1/1 Seeing as alot of ath9k devices is PCI/PCIe or their mini equivalent it makes sense to set ATH9K_PCI to y by default
Quoted 25 lines · On Thu, 17 Nov 2011 16:13:53 +0100 Gabor Juhos <[email protected]> wrote:
2011.11.09. 23:57 keltez?ssel, Daniel Kuehn ?rta:
Quoted 7 lines
from: Daniel Kuehn <[email protected]>
Most ath9k devices are PCI/PCIe based, therefor making PCI/PCIe support default y helps those porting a config from 2.6 kernel series from getting "non-functional" wireless drivers with 3.x kernel series.
Signed-off-by Daniel Kuehn <[email protected]>The option was enabled in the past but it has been removed a few months ago by the following commit:
commit
64bd0821a3b66c3307d7a4ee5523e3e35ec2df0eAuthor: Tao Ma <[email protected]> Date: Wed May 25 09:44:05 2011 +0800wireless: Default to 'n' for 2 new added devices in
Kconfig.We make oldconfig every time when a new kernel arrives, but if we don't have such a device(I guess this is the most common case for a new device), the default value should be 'n' so that the kernel size we build doesn't grow up too much quickly. For anyone who has the device, it is OK for them to turn it on by themselves.
Quoted 7 lines
Cc "John W. Linville" <[email protected]>Cc Johannes Berg <[email protected]>Signed-off-by Tao Ma <[email protected]>Signed-off-by John W. Linville <[email protected]>In my opinion it should not be added again.
I agree with you there if it was removed before, maybe then only the help section of ath9k should be changed to say that you have to enable either PCI/PCIe or AHB support for it to work?
Because it doesn't seem to be possible to make it choose that option and still make it removable IF ath9k is chosen.
It seems you either need to default it to y (with default y) or make it unremovable if ath9k is selected (with select ATH9K_PCI for ATH9K).
Quoted 3 lines
Regards,
Gabor
Kind regards,
Daniel Kuehn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20111117/9e7cc23f/attachment.pgp
PATCH 1/1 Seeing as alot of ath9k devices is PCI/PCIe or their mini equivalent it makes sense to set ATH9K_PCI to y by default
2011.11.17. 16:39 keltez?ssel, Daniel Kuehn ?rta:
Quoted 3 lines
I agree with you there if it was removed before, maybe then only the help section of ath9k should be changed to say that you have to enable either PCI/PCIe or AHB support for it to work?
Yes, adding a comment there would make sense, although that does not prevent to build ath9k without bus support.
-Gabor
PATCH 1/1 Seeing as alot of ath9k devices is PCI/PCIe or their mini equivalent it makes sense to set ATH9K_PCI to y by default
Quoted 8 lines · On Thu, 17 Nov 2011 19:44:59 +0100 Gabor Juhos <[email protected]> wrote:
2011.11.17. 16:39 keltez?ssel, Daniel Kuehn ?rta:
Quoted 3 lines
I agree with you there if it was removed before, maybe then only the help section of ath9k should be changed to say that you have to enable either PCI/PCIe or AHB support for it to work?
Yes, adding a comment there would make sense, although that does not prevent to build ath9k without bus support.
Yeah, that is the initial problem I found that I wanted to try and patch, but seeing as it only stands between either always enabling it, or forcing one or the other bus always on if you choose ath9k I don't know what else could be done except note in the help that you also need to enable bus support.
I haven't poked around that much with Kconfig but it clearly seems like there isn't a way to default select y but make it possible to disable it...
So there doesn't seem to be a clear way to automagically include the most common bus support for ath9k.
Quoted 2 lines
-Gabor
Kind regards,
Daniel Kuehn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20111117/dfc990f7/attachment.pgp