soc/lapis: add machine driver
PATCH v2 1/1 soc/lapis: add machine driver
Add machine driver for LAPIS Semiconductor ML7213 IOH.
---
V2: Updates Mark's comments.
- Sorted in Makefile and Kconfig position
- Import I2C configuration processing from CODEC driver
- Add widget and route map
- Add initialization processing (ml26124_set_dai_sysclk)
- Modify codec_dai_name settins
- Use snd_soc_register_card not platform_device_alloc
- Use return platform_driver_register not platform_driver_probe
--- sound/soc/Kconfig | 1 + sound/soc/Makefile | 1 + sound/soc/lapis/Kconfig | 6 + sound/soc/lapis/Makefile | 4 + sound/soc/lapis/ml7213ioh-machine.c | 197 +++++++++++++++++++++++++++++++++++ 5 files changed, 209 insertions(+), 0 deletions(-) create mode 100644 sound/soc/lapis/Kconfig create mode 100644 sound/soc/lapis/Makefile create mode 100644 sound/soc/lapis/ml7213ioh-machine.c
sound/soc/Kconfig +1 -0
@@ -52,6 +52,7 @@ source "sound/soc/jz4740/Kconfig" source "sound/soc/nuc900/Kconfig" source "sound/soc/omap/Kconfig" source "sound/soc/kirkwood/Kconfig" +source "sound/soc/lapis/Kconfig" source "sound/soc/mid-x86/Kconfig" source "sound/soc/mxs/Kconfig" source "sound/soc/pxa/Kconfig"
sound/soc/Makefile +1 -0
@@ -11,6 +11,7 @@ obj-$(CONFIG_SND_SOC) += ep93xx/ obj-$(CONFIG_SND_SOC) += fsl/ obj-$(CONFIG_SND_SOC) += imx/ obj-$(CONFIG_SND_SOC) += jz4740/ +obj-$(CONFIG_SND_SOC) += lapis/ obj-$(CONFIG_SND_SOC) += mid-x86/ obj-$(CONFIG_SND_SOC) += mxs/ obj-$(CONFIG_SND_SOC) += nuc900/
sound/soc/lapis/Kconfig new file +6 -0
@@ -0,0 +1,6 @@ +config SND_SOC_ML7213_MACHINE + tristate "ML7213 IOH ASoC machine driver" + depends on SND_SOC_TXX9ACLC + select SND_SOC_ML7213_PLATFORM + help + This is ASoC machine driver for ML7213 IOH
sound/soc/lapis/Makefile new file +4 -0
@@ -0,0 +1,4 @@ +# Platform +snd-soc-ml7213-machine-objs := ml7213ioh-machine.o + +obj-$(CONFIG_SND_SOC_ML7213_MACHINE) += snd-soc-ml7213-plat.o
sound/soc/lapis/ml7213ioh-machine.c new file +197 -0
197 lines not on this page · raw message
Signature · 1 line
1.7.4.4
sound/soc/lapis/ml7213ioh-machine.c line 34
Quoted 8 lines · Tomoya MORINAGA
sound/soc/lapis/ml7213ioh-machine.c new file +8
-0+#define CODEC_DEV_ADDR 0x1A +static struct i2c_board_info ioh_hwmon_info[] = { + {I2C_BOARD_INFO ("ioh_i2c-0" ,CODEC_DEV_ADDR +1 )}, + {I2C_BOARD_INFO ("ioh_i2c-1" ,CODEC_DEV_ADDR +2 )}, + {I2C_BOARD_INFO ("ioh_i2c-2" ,CODEC_DEV_ADDR +3 )}, + {I2C_BOARD_INFO ("ioh_i2c-3" ,CODEC_DEV_ADDR +4 )}, + {I2C_BOARD_INFO ("ioh_i2c-4" ,CODEC_DEV_ADDR +5 )}, + {I2C_BOARD_INFO ("ioh_i2c-5" ,CODEC_DEV_ADDR +0 )},
This looks completely wrong. I'd not expect to see any I2C_BOARD_INFO usage at all in a machine driver (that should be done by whatever enumerates the system as a whole) and I'm not clear what the intended effect of the above is - the names look like the names of I2C controllers...
sound/soc/lapis/ml7213ioh-machine.c line 61
Quoted 9 lines
sound/soc/lapis/ml7213ioh-machine.c new file +9
-0+static int ml7213_ioh_init (struct snd_soc_pcm_runtime *rtd) +{ +struct snd_soc_codec *codec = rtd->codec; +struct snd_soc_dapm_context *dapm = &codec->dapm; + +snd_soc_dapm_new_controls (dapm, ml7213_dapm_widgets, +ARRAY_SIZE (ml7213_dapm_widgets)); + +snd_soc_dapm_add_routes (dapm, ml7213_routes,ARRAY_SIZE (ml7213_routes));
Use table based init for these.
Quoted 10 lines
sound/soc/lapis/ml7213ioh-machine.c new file +10
-0+static int ml7213_startup (struct snd_pcm_substream *substream) +{ +struct snd_soc_pcm_runtime *rtd = substream->private_data; +struct snd_soc_codec *codec = rtd->codec; +struct i2c_client *i2c; +struct i2c_adapter *adapter; + +mutex_lock (&codec->mutex); + + adapter =i2c_get_adapter (1 );
sound/soc/lapis/ml7213ioh-machine.c line 86
Quoted 10 lines
sound/soc/lapis/ml7213ioh-machine.c new file +10
-0+if (!adapter) +return -ENODEV ; + + i2c =i2c_new_device (adapter, &ioh_hwmon_info[substream->number]); +if (!i2c) { +mutex_unlock (&codec->mutex); +return -1 ; + } +i2c_put_adapter (adapter); +mutex_unlock (&codec->mutex);
No, this is definitely wrong - we certainly shouldn't be registering new devices whenever someone starts an audio stream. I'm struggling to understand what the intended effect is though.
sound/soc/lapis/ml7213ioh-machine.c line 105
Quoted 6 lines
sound/soc/lapis/ml7213ioh-machine.c new file +6
-0+switch (params_rate (params)) { +case 16000 : +case 32000 : +case 48000 : + clk =12288800 ; +break ;
You may as well just set the CODEC clock rate once on init() and let the CODEC driver worry about what it can do with the clock it's got, if the values aren't going to change there's no need to set them every time.
sound/soc/lapis/ml7213ioh-machine.c line 114
Quoted 4 lines
sound/soc/lapis/ml7213ioh-machine.c new file +4
-0+ ret =snd_soc_dai_set_fmt (codec_dai,SND_SOC_DAIFMT_I2S | +SND_SOC_DAIFMT_NB_NF |SND_SOC_DAIFMT_CBS_CFS ); +if (ret <0 ) +return ret;
Use the dai_fmt field in the dai_link to set this.
sound/soc/lapis/ml7213ioh-machine.c line 197
Quoted 3 lines
sound/soc/lapis/ml7213ioh-machine.c new file +3
-0+MODULE_AUTHOR ("Tomoya MORINAGA <[email protected]>" ); +MODULE_DESCRIPTION ("LAPIS Semiconductor ML7213 IOH ALSA SoC machine driver" ); +MODULE_LICENSE ("GPL" );
Should have MODULE_ALIAS too.
Hi Mark,
First of all, let me confirm my understanding for machine driver. According to "machine.txt", I created this machine driver referring corgi.c/spitz.c.
However, corgi.c/spitz.c. don't look obeying your saying.
e.g.
2011/12/3 Mark Brown <[email protected]>:
Quoted 4 lines
Quoted 1 line
+
snd_soc_dapm_add_routes(dapm, ml7213_routes, ARRAY_SIZE(ml7213_routes));Use table based init for these.
I couldn't see any table based init processing at corgi.c/spitz.c.
Quoted 8 lines
Quoted 7 lines
+ switch (
params_rate(params)) {
+ case 16000:
+ case 32000:
+ case 48000:
+ clk = 12288800;
+ break;
Quoted 4 lines
You may as well just set the CODEC clock rate once on
init()and let the CODEC driver worry about what it can do with the clock it's got, if the values aren't going to change there's no need to set them every time.
corgi.c/spitz.c look coded like above.
So, I'm confused.
Is this procedure true ?
Thanks,
tomoya
Quoted 3 lines · Tomoya MORINAGA
According to "machine.txt", I created this machine driver referring
corgi.c/spitz.c.
However,corgi.c/spitz.c. don't look obeying your saying.
You really need to look at current drivers to make sure you're following current best practice - older drivers, particularly for obsolte hardware like the Zaurus machines, may well not reflect the current best practices.
2011/12/3 Mark Brown <[email protected]>:
Quoted 14 lines · Tomoya MORINAGA
sound/soc/lapis/ml7213ioh-machine.c line 34
Quoted 9 lines
sound/soc/lapis/ml7213ioh-machine.c new file +8
-0+#define CODEC_DEV_ADDR 0x1A +static struct i2c_board_info ioh_hwmon_info[] = { + {I2C_BOARD_INFO("ioh_i2c-0", CODEC_DEV_ADDR + 1)}, + {I2C_BOARD_INFO("ioh_i2c-1", CODEC_DEV_ADDR + 2)}, + {I2C_BOARD_INFO("ioh_i2c-2", CODEC_DEV_ADDR + 3)}, + {I2C_BOARD_INFO("ioh_i2c-3", CODEC_DEV_ADDR + 4)}, + {I2C_BOARD_INFO("ioh_i2c-4", CODEC_DEV_ADDR + 5)}, + {I2C_BOARD_INFO("ioh_i2c-5", CODEC_DEV_ADDR + 0)},This looks completely wrong. I'd not expect to see any
I2C_BOARD_INFOusage at all in a machine driver (that should be done by whatever enumerates the system as a whole)
Do you mean machine driver must not use I2C_BOARD_INFO ? Is this true ? Grepping I2C_BOARD_INFO at sound/soc, the following drivers use I2C_BOARD_INFO.
pxa/raumfeld.c: I2C_BOARD_INFO("max9485", 0x63),
pxa/magician.c: I2C_BOARD_INFO("uda1380", 0x18),
s6000/s6105-ipcam.c: { I2C_BOARD_INFO("tlv320aic33", 0x18), }Quoted 3 lines
and I'm not clear what the intended
effect of the above is - the names look like the names of I2C controllers...
You are right.
"ioh_i2c-0" must be "ml26124".
Quoted 17 lines
Quoted 17 lines
sound/soc/lapis/ml7213ioh-machine.c new file +16
-0+static int ml7213_startup (struct snd_pcm_substream *substream) +{ + struct snd_soc_pcm_runtime *rtd = substream->private_data; + struct snd_soc_codec *codec = rtd->codec; + struct i2c_client *i2c; + struct i2c_adapter *adapter; + + mutex_lock(&codec->mutex); + + adapter = i2c_get_adapter(1); + if (!adapter) + return -ENODEV; + + i2c = i2c_new_device(adapter, &ioh_hwmon_info[substream->number]); + if (!i2c) { + mutex_unlock(&codec->mutex);
Quoted 8 lines
Quoted 4 lines
+ return -1;
+ }
+i2c_put_adapter(adapter);
+mutex_unlock(&codec->mutex);No, this is definitely wrong - we certainly shouldn't be registering new devices whenever someone starts an audio stream. I'm struggling to understand what the intended effect is though.
Do you mean this registering must be at xx_init processing ? OK, I'll move this processing into init().
Quoted 6 lines
Quoted 4 lines
+ ret = snd_soc_dai_set_fmt(codec_dai,
SND_SOC_DAIFMT_I2S|
+SND_SOC_DAIFMT_NB_NF|SND_SOC_DAIFMT_CBS_CFS);
+ if (ret < 0)
+ return ret;Use the
dai_fmtfield in thedai_linkto set this.
Sorry, I can't understand your saying.
Let me know in more detail.
Quoted 6 lines
sound/soc/lapis/ml7213ioh-machine.c line 197
Quoted 4 lines
sound/soc/lapis/ml7213ioh-machine.c new file +3
-0+MODULE_AUTHOR ("Tomoya MORINAGA <[email protected]>" ); +MODULE_DESCRIPTION ("LAPIS Semiconductor ML7213 IOH ALSA SoC machine driver" ); +MODULE_LICENSE ("GPL" );Should have
MODULE_ALIAStoo.
Do you mean machine driver should have MODULE_ALIAS ? Grepping MODULE_ALIAS at sound/soc, it seems MODULE_ALIAS is used in platform driver only like below. pxa/pxa2xx-i2s.c:MODULE_ALIAS("platform:pxa2xx-i2s");
Does machine driver need like "MODULE_ALIAS("machine:ml7213CRB")" ?
Thanks in advance
tomoya
Quoted 8 lines · Tomoya MORINAGA
2011/12/3 Mark Brown <[email protected]>:
Quoted 5 lines
Quoted 1 line
+ {
I2C_BOARD_INFO("ioh_i2c-5", CODEC_DEV_ADDR + 0)},This looks completely wrong. I'd not expect to see any
I2C_BOARD_INFOusage at all in a machine driver (that should be done by whatever enumerates the system as a whole)
Quoted 6 lines
Do you mean machine driver must not use
I2C_BOARD_INFO? Is this true ? GreppingI2C_BOARD_INFOatsound/soc, the following drivers useI2C_BOARD_INFO.pxa/raumfeld.c: I2C_BOARD_INFO("max9485", 0x63), pxa/magician.c: I2C_BOARD_INFO("uda1380", 0x18), s6000/s6105-ipcam.c: { I2C_BOARD_INFO("tlv320aic33", 0x18), }
You'll note that this is *really* rare; there are vastly more machine drivers that don't do this. If there's some specific reason then there's nothing technical stopping this happening but it's very unusual.
Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
+ ret = snd_soc_dai_set_fmt(codec_dai,
SND_SOC_DAIFMT_I2S|
+SND_SOC_DAIFMT_NB_NF|SND_SOC_DAIFMT_CBS_CFS);
+ if (ret < 0)
+ return ret;Use the
dai_fmtfield in thedai_linkto set this.Sorry, I can't understand your saying.
Let me know in more detail.
I'm not sure what more to say... Have you looked at that field and how it is both implemented and used in other drivers, or at the commit logs for relevant changes? What do you find unclear?
Quoted 6 lines
Quoted 1 line
Should have
MODULE_ALIAStoo.Do you mean machine driver should have
MODULE_ALIAS? GreppingMODULE_ALIASatsound/soc, it seemsMODULE_ALIASis used in platform driver only like below. pxa/pxa2xx-i2s.c:MODULE_ALIAS("platform:pxa2xx-i2s");
I don't think you're looking at a current kernel...
Quoted 1 line
Does machine driver need like "
MODULE_ALIAS("machine:ml7213CRB")" ?
No, it should match the name of the platform driver you created. The
platform: refers to the bus type.
2011/12/6 Mark Brown <[email protected]>:
Quoted 7 lines
Quoted 3 lines
According to "machine.txt", I created this machine driver referring
corgi.c/spitz.c.
However,corgi.c/spitz.c. don't look obeying your saying.You really need to look at current drivers to make sure you're following current best practice - older drivers, particularly for obsolte hardware like the Zaurus machines, may well not reflect the current best practices.
I see.
I won't read this docs.
BTW, Let me know the best practice of machine driver? I can't identify which driver is modern or not.
Quoted 15 lines
Quoted 8 lines
2011/12/3 Mark Brown <[email protected]>:
Quoted 5 lines
Quoted 1 line
+ {
I2C_BOARD_INFO("ioh_i2c-5", CODEC_DEV_ADDR + 0)},This looks completely wrong. I'd not expect to see any
I2C_BOARD_INFOusage at all in a machine driver (that should be done by whatever enumerates the system as a whole)Quoted 6 lines
Do you mean machine driver must not use
I2C_BOARD_INFO? Is this true ? GreppingI2C_BOARD_INFOatsound/soc, the following drivers useI2C_BOARD_INFO.pxa/raumfeld.c:I2C_BOARD_INFO("max9485", 0x63),pxa/magician.c:I2C_BOARD_INFO("uda1380", 0x18),s6000/s6105-ipcam.c: {I2C_BOARD_INFO("tlv320aic33", 0x18), }
Quoted 3 lines
You'll note that this is *really* rare; there are vastly more machine drivers that don't do this. If there's some specific reason then there's nothing technical stopping this happening but it's very unusual.
I see.
I want to know how to use i2c device.
Let me know the best practice driver uses i2c device.
Quoted 6 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
+ ret = snd_soc_dai_set_fmt(codec_dai,
SND_SOC_DAIFMT_I2S|
+SND_SOC_DAIFMT_NB_NF|SND_SOC_DAIFMT_CBS_CFS);
+ if (ret < 0)
+ return ret;
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Use the
dai_fmtfield in thedai_linkto set this.Sorry, I can't understand your saying.
Let me know in more detail.I'm not sure what more to say... Have you looked at that field and how it is both implemented and used in other drivers, or at the commit logs for relevant changes? What do you find unclear?
You said "Use the dai_fmt field in the dai_link to set this." However, both dai_fmt and dai_link are already implemented like below. static struct snd_soc_dai_link ioh_i2s_dai = {
...
};
static struct snd_soc_card ioh_i2s_card = {
...
.dai_link = &ioh_i2s_dai,
...
};
So, I can't understand your saying.
Quoted 8 lines
Quoted 7 lines
Quoted 2 lines
Should have
MODULE_ALIAStoo.Do you mean machine driver should have
MODULE_ALIAS? Grepping MODULE_ALIAS atsound/soc, it seemsMODULE_ALIASis used in platform driver only like below. pxa/pxa2xx-i2s.c:MODULE_ALIAS("platform:pxa2xx-i2s");
Quoted 6 lines
I don't think you're looking at a current kernel...
Quoted 1 line
Does machine driver need like "
MODULE_ALIAS("machine:ml7213CRB")" ?No, it should match the name of the platform driver you created. The
platform: refers to the bus type.
I understood.
thanks,
tomoya
Quoted 9 lines · Tomoya MORINAGA
2011/12/6 Mark Brown <[email protected]>:
Quoted 7 lines
Quoted 3 lines
According to "machine.txt", I created this machine driver referring
corgi.c/spitz.c.
However,corgi.c/spitz.c. don't look obeying your saying.You really need to look at current drivers to make sure you're following current best practice - older drivers, particularly for obsolte hardware like the Zaurus machines, may well not reflect the current best practices.
Quoted 7 lines
I see.
I won't read this docs.BTW, Let me know the best practice of machine driver? I can't identify which driver is modern or not.
Check the OMAP and Samsung directories. Those are pretty current
2011/12/6 Austin, Brian <[email protected]>:
Quoted 12 lines · Tomoya MORINAGA
Quoted 10 lines
2011/12/6 Mark Brown <[email protected]>:
Quoted 7 lines
Quoted 3 lines
According to "machine.txt", I created this machine driver referring
corgi.c/spitz.c.
However,corgi.c/spitz.c. don't look obeying your saying.You really need to look at current drivers to make sure you're following current best practice - older drivers, particularly for obsolte hardware like the Zaurus machines, may well not reflect the current best practices.
Quoted 9 lines
Quoted 7 lines
I see.
I won't read this docs.BTW, Let me know the best practice of machine driver? I can't identify which driver is modern or not.
Check the OMAP and Samsung directories. Those are pretty current
Thanks. However, i2c access code is not included in Samsung. Though OMAP includes i2c access code like below,
omap/sdp3430.c: twl_i2c_read_u8(TWL4030_MODULE_INTBR, &pin_mux, omap/sdp3430.c: twl_i2c_write_u8(TWL4030_MODULE_INTBR, pin_mux,
this code doesn't seem applicable for me.
Could you show best practice for i2c access of machine driver?
thanks,
tomoya
Quoted 7 lines · Tomoya MORINAGA
Thanks. However, i2c access code is not included in Samsung. Though OMAP includes i2c access code like below,
omap/sdp3430.c: twl_i2c_read_u8(TWL4030_MODULE_INTBR,&pin_mux,omap/sdp3430.c: twl_i2c_write_u8(TWL4030_MODULE_INTBR,pin_mux,
this code doesn't seem applicable for me.Could you show best practice for i2c access of machine driver?
I2C access by machine drivers is not good practice. If you must do it for some reason use the standard ASoC functions to read and write registers.
2011/12/6 Tomoya MORINAGA <[email protected]>:
Quoted 20 lines
Quoted 5 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
+ ret = snd_soc_dai_set_fmt(codec_dai,
SND_SOC_DAIFMT_I2S|
+SND_SOC_DAIFMT_NB_NF|SND_SOC_DAIFMT_CBS_CFS);
+ if (ret < 0)
+ return ret;Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Use the
dai_fmtfield in thedai_linkto set this.Sorry, I can't understand your saying.
Let me know in more detail.I'm not sure what more to say... Have you looked at that field and how it is both implemented and used in other drivers, or at the commit logs for relevant changes? What do you find unclear?
You said "Use the
dai_fmtfield in thedai_linkto set this." However, bothdai_fmtanddai_linkare already implemented like below. static structsnd_soc_dai_linkioh_i2s_dai= {
...
};
Quoted 6 lines
static struct
snd_soc_cardioh_i2s_card= {
...
.dai_link =&ioh_i2s_dai,
...
};
So, I can't understand your saying.
Could you give me your answer ?
thanks,
tomoya
Quoted 1 line · Tomoya MORINAGA
2011/12/6 Tomoya MORINAGA <[email protected]>:
You're complaining that you didn't a response within 24 hours! This is really not reasonable for something which is essentially volunteer driven project.
Quoted 10 lines
Quoted 9 lines
You said "Use the
dai_fmtfield in thedai_linkto set this." However, bothdai_fmtanddai_linkare already implemented like below. static structsnd_soc_dai_linkioh_i2s_dai= {static struct
snd_soc_cardioh_i2s_card= {
...
.dai_link =&ioh_i2s_dai,
...
};
Quoted 3 lines
Quoted 1 line
So, I can't understand your saying.
Could you give me your answer ?
Your above code has no references to dai_fmt. Have you looked at the dai_fmt field in the dai_link structure or at the existing examples of its use?
2011/12/7 Mark Brown <[email protected]>:
Quoted 3 lines
Your above code has no references to
dai_fmt. Have you looked at thedai_fmtfield in thedai_linkstructure or at the existing examples of its use?
Still I can't understand your saying. Let me clarify.
Firstly, the above "dai_link structure" means below ? If yes, there is no member "dai_fmt", right ?
697 struct snd_soc_dai_link {
698 /* config - must be set by machine driver */ 699 const char *name; /* Codec name */ 700 const char *stream_name; /* Stream name */ 701 const char *codec_name; /* for multi-codec */ 702 const char *platform_name; /* for multi-platform */ 703 const char *cpu_dai_name; 704 const char *codec_dai_name;
705
706 /* Keep DAI active over suspend */
707 unsigned int ignore_suspend:1;
708
709 /* Symmetry requirements */
710 unsigned int symmetric_rates:1;
711
712 /* codec/machine specific init - e.g. add machine controls */
713 int (*init)(struct snd_soc_pcm_runtime *rtd);
714
715 /* machine stream operations */
716 struct snd_soc_ops *ops;
717
Review
Quoted 2 lines
(quoted diff) +2
-0+ ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S | + SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS);
At the above point, do you mean I shouldn't set these formats( SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS) directly ?
Anyway,let me know your best reference driver obeys your saying about it.
thanks,
tomoya
Quoted 3 lines · Tomoya MORINAGA
Firstly, the above "
dai_linkstructure" means below ? If yes, there is no member "dai_fmt", right ?
697 structsnd_soc_dai_link{
As previously advised you should work against current development kernels. dai_fmt is present in current development kernels (and Linus' tree for that matter).
Quoted 6 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+ ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S | + SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS);At the above point, do you mean I shouldn't set these
formats( SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS)directly ?
Yes.
2011/12/9 Mark Brown <[email protected]>:
Quoted 10 lines · Tomoya MORINAGA
Quoted 4 lines
Firstly, the above "
dai_linkstructure" means below ? If yes, there is no member "dai_fmt", right ?
697 structsnd_soc_dai_link{As previously advised you should work against current development kernels. dai_fmt is present in current development kernels (and Linus' tree for that matter).
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
+ ret = snd_soc_dai_set_fmt(codec_dai,
SND_SOC_DAIFMT_I2S|
+SND_SOC_DAIFMT_NB_NF|SND_SOC_DAIFMT_CBS_CFS);At the above point, do you mean I shouldn't set these
formats( SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS)directly ?Yes.
Seeing linux-next tree, I could understand your saying. I saw linux tree(3.2-rc4).
thanks,
tomoya