vfs: make writeback_in_progress() inline
Subsystems (2)
PATCH 1/2 vfs: make writeback_in_progress() inline
writeback_in_progress() is very simple, and we will use writeback_in_progress() in the module, so make it inline.
Signed-off-by Miao Xie <[email protected]>
--- fs/fs-writeback.c | 12 ------------ include/linux/backing-dev.h | 12 +++++++++++- 2 files changed, 11 insertions(+), 13 deletions(-)
fs/fs-writeback.c +0 -12
@@ -59,18 +59,6 @@ struct wb_writeback_work {*/ int nr_pdflush_threads; -/** -* writeback_in_progress - determine whether there is writeback in progress -* @bdi: the device's backing_dev_info structure. -* -* Determine whether there is writeback waiting to be handled against a -* backing device. -*/ -int writeback_in_progress (struct backing_dev_info *bdi) -{ -return test_bit (BDI_writeback_running, &bdi->state); -} -static inline struct backing_dev_info *inode_to_bdi (struct inode *inode) {struct super_block *sb = inode->i_sb;
include/linux/backing-dev.h +11 -1
@@ -258,7 +258,17 @@ int bdi_set_max_ratio(struct backing_dev_info *bdi, unsigned int max_ratio);extern struct backing_dev_info default_backing_dev_info;extern struct backing_dev_info noop_backing_dev_info; -int writeback_in_progress (struct backing_dev_info *bdi); +/** +* writeback_in_progress - determine whether there is writeback in progress +* @bdi: the device's backing_dev_info structure. +* +* Determine whether there is writeback waiting to be handled against a +* backing device. +*/ +static inline int writeback_in_progress (struct backing_dev_info *bdi) +{ +return test_bit (BDI_writeback_running, &bdi->state); +}static inline int bdi_congested (struct backing_dev_info *bdi,int bdi_bits) {
Signature · 1 line
1.7.6.4
cc Fengguang
cc Linux-kernel
Quoted 55 lines · Miao Xie
writeback_in_progress()is very simple, and we will usewriteback_in_progress()in the module, so make it inline.Signed-off-by Miao Xie <[email protected]>--- fs/fs-writeback.c | 12 ------------ include/linux/backing-dev.h | 12 +++++++++++- 2 files changed, 11 insertions(+), 13 deletions(-)fs/fs-writeback.c +0
-12@@ -59,18 +59,6 @@ struct wb_writeback_work {*/ int nr_pdflush_threads; -/** -* writeback_in_progress - determine whether there is writeback in progress -* @bdi: the device's backing_dev_info structure. -* -* Determine whether there is writeback waiting to be handled against a -* backing device. -*/ -int writeback_in_progress (struct backing_dev_info *bdi) -{ -return test_bit (BDI_writeback_running, &bdi->state); -} -static inline struct backing_dev_info *inode_to_bdi (struct inode *inode) {struct super_block *sb = inode->i_sb;include/linux/backing-dev.h +11
-1@@ -258,7 +258,17 @@ int bdi_set_max_ratio(struct backing_dev_info *bdi, unsigned int max_ratio);extern struct backing_dev_info default_backing_dev_info;extern struct backing_dev_info noop_backing_dev_info; -int writeback_in_progress (struct backing_dev_info *bdi); +/** +* writeback_in_progress - determine whether there is writeback in progress +* @bdi: the device's backing_dev_info structure. +* +* Determine whether there is writeback waiting to be handled against a +* backing device. +*/ +static inline int writeback_in_progress (struct backing_dev_info *bdi) +{ +return test_bit (BDI_writeback_running, &bdi->state); +}static inline int bdi_congested (struct backing_dev_info *bdi,int bdi_bits) {
Quoted 2 lines · Miao Xie
writeback_in_progress()is very simple, and we will usewriteback_in_progress()in the module, so make it inline.
Modules don't really have a business looking at this information. I'd prefer to keep it static in fs-writeback.c.