Skip to contentSkip to conversation

vfs: make writeback_in_progress() inline

PATCH In review Miao Xie 2 participants 3 messages Dec 6, 2011

Subsystems (2)
lore
Share & tools
lore

Miao Xie

author
#0 lore raw

PATCH 1/2 vfs: make writeback_in_progress() inline

writeback_in_progress() is very simple, and we will use writeback_in_progress() in the module, so make it inline.

---
 fs/fs-writeback.c           |   12 ------------
 include/linux/backing-dev.h |   12 +++++++++++-
 2 files changed, 11 insertions(+), 13 deletions(-)
fs/fs-writeback.c +0 -12
index 04cf3b9..341448c 100644
@@ -59,18 +59,6 @@ struct wb_writeback_work {
  */
 int nr_pdflush_threads;
 
-/**
- * writeback_in_progress - determine whether there is writeback in progress
- * @bdi: the device's backing_dev_info structure.
- *
- * Determine whether there is writeback waiting to be handled against a
- * backing device.
- */
-int writeback_in_progress(struct backing_dev_info *bdi)
-{
-	return test_bit(BDI_writeback_running, &bdi->state);
-}
-
 static inline struct backing_dev_info *inode_to_bdi(struct inode *inode)
 {
 	struct super_block *sb = inode->i_sb;
include/linux/backing-dev.h +11 -1
index 3b2f9cb..ae4d7c0 100644
@@ -258,7 +258,17 @@ int bdi_set_max_ratio(struct backing_dev_info *bdi, unsigned int max_ratio);
 extern struct backing_dev_info default_backing_dev_info;
 extern struct backing_dev_info noop_backing_dev_info;
 
-int writeback_in_progress(struct backing_dev_info *bdi);
+/**
+ * writeback_in_progress - determine whether there is writeback in progress
+ * @bdi: the device's backing_dev_info structure.
+ *
+ * Determine whether there is writeback waiting to be handled against a
+ * backing device.
+ */
+static inline int writeback_in_progress(struct backing_dev_info *bdi)
+{
+	return test_bit(BDI_writeback_running, &bdi->state);
+}
 
 static inline int bdi_congested(struct backing_dev_info *bdi, int bdi_bits)
 {
Signature · 1 line
1.7.6.4
author
#1 lore raw

cc Fengguang
cc Linux-kernel

Quoted 55 lines · Miao Xie

writeback_in_progress() is very simple, and we will use writeback_in_progress() in the module, so make it inline.

---
 fs/fs-writeback.c           |   12 ------------
 include/linux/backing-dev.h |   12 +++++++++++-
 2 files changed, 11 insertions(+), 13 deletions(-)
fs/fs-writeback.c +0 -12
index 04cf3b9..341448c 100644
@@ -59,18 +59,6 @@ struct wb_writeback_work {
  */
 int nr_pdflush_threads;
 
-/**
- * writeback_in_progress - determine whether there is writeback in progress
- * @bdi: the device's backing_dev_info structure.
- *
- * Determine whether there is writeback waiting to be handled against a
- * backing device.
- */
-int writeback_in_progress(struct backing_dev_info *bdi)
-{
-	return test_bit(BDI_writeback_running, &bdi->state);
-}
-
 static inline struct backing_dev_info *inode_to_bdi(struct inode *inode)
 {
 	struct super_block *sb = inode->i_sb;
include/linux/backing-dev.h +11 -1
index 3b2f9cb..ae4d7c0 100644
@@ -258,7 +258,17 @@ int bdi_set_max_ratio(struct backing_dev_info *bdi, unsigned int max_ratio);
 extern struct backing_dev_info default_backing_dev_info;
 extern struct backing_dev_info noop_backing_dev_info;
 
-int writeback_in_progress(struct backing_dev_info *bdi);
+/**
+ * writeback_in_progress - determine whether there is writeback in progress
+ * @bdi: the device's backing_dev_info structure.
+ *
+ * Determine whether there is writeback waiting to be handled against a
+ * backing device.
+ */
+static inline int writeback_in_progress(struct backing_dev_info *bdi)
+{
+	return test_bit(BDI_writeback_running, &bdi->state);
+}
 
 static inline int bdi_congested(struct backing_dev_info *bdi, int bdi_bits)
 {
#2 lore raw
In reply to Miao Xie
Quoted 2 lines · Miao Xie

writeback_in_progress() is very simple, and we will use writeback_in_progress() in the module, so make it inline.

Modules don't really have a business looking at this information. I'd prefer to keep it static in fs-writeback.c.