Skip to contentSkip to conversation

svcrdma: silence a Sparse warning

PATCH In review Dan Carpenter 3 participants 4 messages Feb 21, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 svcrdma: silence a Sparse warning

Sparse complains that the definition function definition and the implementation aren't anotated the same way.

include/linux/sunrpc/svc_rdma.h +1 -1
index d205e9f..0b8e3e6 100644
@@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,
 extern void svc_rdma_xdr_encode_write_list(struct rpcrdma_msg *, int);
 extern void svc_rdma_xdr_encode_reply_array(struct rpcrdma_write_array *, int);
 extern void svc_rdma_xdr_encode_array_chunk(struct rpcrdma_write_array *, int,
-					    u32, u64, u32);
+					    __be32, __be64, u32);
 extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *,
 					     struct rpcrdma_msg *,
 					     struct rpcrdma_msg *,
#1 lore raw

(Cc'ing Tom).

Quoted 18 lines · Dan Carpenter

Sparse complains that the definition function definition and the implementation aren't anotated the same way.

include/linux/sunrpc/svc_rdma.h +1 -1
index d205e9f..0b8e3e6 100644
@@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,
 extern void svc_rdma_xdr_encode_write_list(struct rpcrdma_msg *, int);
 extern void svc_rdma_xdr_encode_reply_array(struct rpcrdma_write_array *, int);
 extern void svc_rdma_xdr_encode_array_chunk(struct rpcrdma_write_array *, int,
-					    u32, u64, u32);
+					    __be32, __be64, u32);
 extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *,
 					     struct rpcrdma_msg *,
 					     struct rpcrdma_msg *,
#2 lore raw

This is my bad. I don't know why my sparse didn't catch it, it seems like it should have. Thanks for
fixing it Dan.

Tom

Quoted 25 lines · J. Bruce Fields

(Cc'ing Tom).

Quoted 10 lines · Dan Carpenter

Sparse complains that the definition function definition and the implementation aren't anotated the same way.

include/linux/sunrpc/svc_rdma.h +0 -0
index d205e9f..0b8e3e6 100644

include/linux/sunrpc/svc_rdma.h extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *, · line 196

Quoted 8 lines
include/linux/sunrpc/svc_rdma.h +1 -1
@@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,
  extern void svc_rdma_xdr_encode_write_list(struct rpcrdma_msg *, int);
  extern void svc_rdma_xdr_encode_reply_array(struct rpcrdma_write_array *, int);
  extern void svc_rdma_xdr_encode_array_chunk(struct rpcrdma_write_array *, int,
-					    u32, u64, u32);
+					    __be32, __be64, u32);
  extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *,
  					     struct rpcrdma_msg *,
  					     struct rpcrdma_msg *,

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
Quoted 4 lines · Tom Tucker

This is my bad. I don't know why my sparse didn't catch it, it seems like it should have. Thanks for
fixing it Dan.

Thanks, applying.--b.

Quoted 35 lines

Tom

Quoted 17 lines · J. Bruce Fields

(Cc'ing Tom).

Quoted 14 lines · Dan Carpenter

Sparse complains that the definition function definition and the implementation aren't anotated the same way.

include/linux/sunrpc/svc_rdma.h +0 -1
index d205e9f..0b8e3e6 100644
@@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,
 extern void svc_rdma_xdr_encode_write_list(struct rpcrdma_msg *, int);
 extern void svc_rdma_xdr_encode_reply_array(struct rpcrdma_write_array *, int);
 extern void svc_rdma_xdr_encode_array_chunk(struct rpcrdma_write_array *, int,
-					    u32, u64, u32);
Quoted 8 lines

include/linux/sunrpc/svc_rdma.h extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *, · line 196

Quoted 4 lines
include/linux/sunrpc/svc_rdma.h +1 -0
+					    __be32, __be64, u32);
 extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *,
 					     struct rpcrdma_msg *,
 					     struct rpcrdma_msg *,

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html