svcrdma: silence a Sparse warning
Subsystems (3)
PATCH 1/1 svcrdma: silence a Sparse warning
Sparse complains that the definition function definition and the implementation aren't anotated the same way.
include/linux/sunrpc/svc_rdma.h +1 -1
@@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,extern void svc_rdma_xdr_encode_write_list (struct rpcrdma_msg *,int );extern void svc_rdma_xdr_encode_reply_array (struct rpcrdma_write_array *,int );extern void svc_rdma_xdr_encode_array_chunk (struct rpcrdma_write_array *,int , -u32 ,u64 ,u32 ); +__be32 ,__be64 ,u32 ); extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *, struct rpcrdma_msg *, struct rpcrdma_msg *,
(Cc'ing Tom).
Quoted 18 lines · Dan Carpenter
Sparse complains that the definition function definition and the implementation aren't anotated the same way.
Signed-off-by Dan Carpenter <[email protected]>include/linux/sunrpc/svc_rdma.h +1
-1@@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,extern void svc_rdma_xdr_encode_write_list (struct rpcrdma_msg *,int );extern void svc_rdma_xdr_encode_reply_array (struct rpcrdma_write_array *,int );extern void svc_rdma_xdr_encode_array_chunk (struct rpcrdma_write_array *,int , -u32 ,u64 ,u32 ); +__be32 ,__be64 ,u32 ); extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *, struct rpcrdma_msg *, struct rpcrdma_msg *,
This is my bad. I don't know why my sparse didn't catch it, it seems like it should have. Thanks for
fixing it Dan.
Tom
Quoted 25 lines · J. Bruce Fields
(Cc'ing Tom).
Quoted 10 lines · Dan Carpenter
Sparse complains that the definition function definition and the implementation aren't anotated the same way.
Signed-off-by Dan Carpenter<[email protected]>include/linux/sunrpc/svc_rdma.h +0
-0include/linux/sunrpc/svc_rdma.h extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *, · line 196
Quoted 8 lines
include/linux/sunrpc/svc_rdma.h +1
-1@@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,extern void svc_rdma_xdr_encode_write_list (struct rpcrdma_msg *,int );extern void svc_rdma_xdr_encode_reply_array (struct rpcrdma_write_array *,int );extern void svc_rdma_xdr_encode_array_chunk (struct rpcrdma_write_array *,int , -u32 ,u64 ,u32 ); +__be32 ,__be64 ,u32 ); extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *, struct rpcrdma_msg *, struct rpcrdma_msg *,--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 4 lines · Tom Tucker
This is my bad. I don't know why my sparse didn't catch it, it seems like it should have. Thanks for
fixing it Dan.
Thanks, applying.--b.
Quoted 35 lines
Tom
Quoted 17 lines · J. Bruce Fields
(Cc'ing Tom).
Quoted 14 lines · Dan Carpenter
Sparse complains that the definition function definition and the implementation aren't anotated the same way.
Signed-off-by Dan Carpenter<[email protected]>include/linux/sunrpc/svc_rdma.h +0
-1@@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,extern void svc_rdma_xdr_encode_write_list (struct rpcrdma_msg *,int );extern void svc_rdma_xdr_encode_reply_array (struct rpcrdma_write_array *,int ); extern void svc_rdma_xdr_encode_array_chunk(struct rpcrdma_write_array *, int, -u32 ,u64 ,u32 );Quoted 8 lines
include/linux/sunrpc/svc_rdma.h extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *, · line 196
Quoted 4 lines
include/linux/sunrpc/svc_rdma.h +1
-0+ __be32, __be64, u32); extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *, struct rpcrdma_msg *, struct rpcrdma_msg *,--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html