MX5: PAD_CTL_DRV_VOT_LOW and PAD_CTL_DRV_VOT_HIGH exchanged
PATCH 1/1 MX5: PAD_CTL_DRV_VOT_LOW and PAD_CTL_DRV_VOT_HIGH exchanged
After an update to the MX51 reference manual (Rev. 5), the values of the PAD_CTL_DRV_VOT_LOW and PAD_CTL_DRV_VOT_HIGH are now clearly wrong:
"Bit 13:
High / Low Output Voltage Range. This bit selects the output voltage mode for SD2_CMD. 0 High output voltage mode
1 Low output voltage mode"
The values are currently negated in code - fixed.
--- arch/arm/include/asm/arch-mx5/iomux.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/include/asm/arch-mx5/iomux.h +2 -2
@@ -66,8 +66,8 @@ typedef enum iomux_pad_config {PAD_CTL_HYS_ENABLE =0x1 <<8 ,/* Hysteresis enabled */ PAD_CTL_DDR_INPUT_CMOS =0x0 <<9 ,/* DDR input CMOS */ PAD_CTL_DDR_INPUT_DDR =0x1 <<9 ,/* DDR input DDR */ -PAD_CTL_DRV_VOT_LOW =0x0 <<13 ,/* Low voltage mode */ -PAD_CTL_DRV_VOT_HIGH =0x1 <<13 ,/* High voltage mode */ +PAD_CTL_DRV_VOT_LOW =0x1 <<13 ,/* Low voltage mode */ +PAD_CTL_DRV_VOT_HIGH =0x0 <<13 ,/* High voltage mode */ } iomux_pad_config_t;/* various IOMUX input functions */
Signature · 1 line
1.7.9.5
PATCH 1/1 MX5: PAD_CTL_DRV_VOT_LOW and PAD_CTL_DRV_VOT_HIGH exchanged
Quoted 24 lines · On Wed, 9 May 2012 12:13:04 +0200 Stefano Babic <[email protected]> wrote:
After an update to the MX51 reference manual (Rev. 5), the values of the
PAD_CTL_DRV_VOT_LOWandPAD_CTL_DRV_VOT_HIGHare now clearly wrong:"Bit 13:
High / Low Output Voltage Range. This bit selects the output voltage mode forSD2_CMD. 0 High output voltage mode
1 Low output voltage mode"The values are currently negated in code - fixed.
Reported-by David Jander <[email protected]>Signed-off-by Stefano Babic <[email protected]>CC Marek Vasut <[email protected]>CC David Jander <[email protected]>--- arch/arm/include/asm/arch-mx5/iomux.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/include/asm/arch-mx5/iomux.h +0
-0
arch/arm/include/asm/arch-mx5/iomux.h typedef enum iomux_pad_config { · line 73
Quoted 10 lines
arch/arm/include/asm/arch-mx5/iomux.h +2
-2@@ -66,8 +66,8 @@ typedef enum iomux_pad_config {PAD_CTL_HYS_ENABLE =0x1 <<8 ,/* Hysteresis enabled */ PAD_CTL_DDR_INPUT_CMOS =0x0 <<9 ,/* DDR input CMOS */ PAD_CTL_DDR_INPUT_DDR =0x1 <<9 ,/* DDR input DDR */ -PAD_CTL_DRV_VOT_LOW =0x0 <<13 ,/* Low voltage mode */ -PAD_CTL_DRV_VOT_HIGH =0x1 <<13 ,/* High voltage mode */ +PAD_CTL_DRV_VOT_LOW =0x1 <<13 ,/* Low voltage mode */ +PAD_CTL_DRV_VOT_HIGH =0x0 <<13 ,/* High voltage mode */ } iomux_pad_config_t;/* various IOMUX input functions */
Acked!
thanks.
Best regards,
Signature · 2 lines
David Jander Protonic Holland.
PATCH 1/1 MX5: PAD_CTL_DRV_VOT_LOW and PAD_CTL_DRV_VOT_HIGH exchanged
Dear David Jander,
Quoted 38 lines
On Wed, 9 May 2012 12:13:04 +0200
Quoted 35 lines · Stefano Babic
After an update to the MX51 reference manual (Rev. 5), the values of the
PAD_CTL_DRV_VOT_LOWandPAD_CTL_DRV_VOT_HIGHare now clearly wrong:"Bit 13:
High / Low Output Voltage Range. This bit selects the output voltage mode forSD2_CMD. 0 High output voltage mode
1 Low output voltage mode"The values are currently negated in code - fixed.
Reported-by David Jander <[email protected]>Signed-off-by Stefano Babic <[email protected]>CC Marek Vasut <[email protected]>CC David Jander <[email protected]>---
arch/arm/include/asm/arch-mx5/iomux.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/arch/arm/include/asm/arch-mx5/iomux.hindex 760371b..e3765a3 100644arch/arm/include/asm/arch-mx5/iomux.h +2
-2@@ -66,8 +66,8 @@ typedef enum iomux_pad_config {PAD_CTL_HYS_ENABLE =0x1 <<8 ,/* Hysteresis enabled */ PAD_CTL_DDR_INPUT_CMOS =0x0 <<9 ,/* DDR input CMOS */ PAD_CTL_DDR_INPUT_DDR =0x1 <<9 ,/* DDR input DDR */ -PAD_CTL_DRV_VOT_LOW =0x0 <<13 ,/* Low voltage mode */ - PAD_CTL_DRV_VOT_HIGH = 0x1 << 13,/* High voltage mode */ +PAD_CTL_DRV_VOT_LOW =0x1 <<13 ,/* Low voltage mode */ + PAD_CTL_DRV_VOT_HIGH = 0x0 << 13,/* High voltage mode */
Quoted 5 lines
Quoted 3 lines
}
iomux_pad_config_t;/* various IOMUX input functions */
Acked!
Fine by me.
Quoted 4 lines
thanks.
Best regards,
Best regards,
Marek Vasut