Skip to contentSkip to conversation

ASoC: fsl: remove unneeded AUDMUX register setting from imx-sgtl5000

PATCH Applied Shawn Guo 2 participants 2 messages Jul 5, 2012 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Shawn Guo

author Acked-by
#1 lore raw
Quoted 7 lines · Hui Wang

If we don't set IMX_AUDMUX_V2_PTCR_TCLKDIR in the AUDMUX PTCR register (means Tx clock pin is input), we don't need to set IMX_AUDMUX_V2_PTCR_TCSEL as well. Since both i.MX35, i.MX51 and i.MX6 datasheet says "When Tx clock pin set as an input, the TCSEL settings are ignored".

Quoted 21 lines
---
 sound/soc/fsl/imx-sgtl5000.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
sound/soc/fsl/imx-sgtl5000.c +1 -2
index 3a729ca..fb21b17 100644
@@ -95,8 +95,7 @@ static int __devinit imx_sgtl5000_probe(struct platform_device *pdev)
 		return ret;
 	}
 	imx_audmux_v2_configure_port(ext_port,
-			IMX_AUDMUX_V2_PTCR_SYN |
-			IMX_AUDMUX_V2_PTCR_TCSEL(int_port),
+			IMX_AUDMUX_V2_PTCR_SYN,
 			IMX_AUDMUX_V2_PDCR_RXDSEL(int_port));
 	if (ret) {
 		dev_err(&pdev->dev, "audmux external port setup failed\n");
Signature · 1 line
1.7.6
Applied
#2 lore raw
In reply to a message not in the archive
Quoted 5 lines · Hui Wang

If we don't set IMX_AUDMUX_V2_PTCR_TCLKDIR in the AUDMUX PTCR register (means Tx clock pin is input), we don't need to set IMX_AUDMUX_V2_PTCR_TCSEL as well. Since both i.MX35, i.MX51 and i.MX6 datasheet says "When Tx clock pin set as an input, the TCSEL settings are ignored".

Applied, thanks.