ASoC: fsl: remove unneeded AUDMUX register setting from imx-sgtl5000
A message that is not in the archive (sent off-list or not yet received): [email protected]
Shawn Guo
Acked-byQuoted 7 lines · Hui Wang
If we don't set
IMX_AUDMUX_V2_PTCR_TCLKDIRin the AUDMUX PTCR register (means Tx clock pin is input), we don't need to setIMX_AUDMUX_V2_PTCR_TCSELas well. Since both i.MX35, i.MX51 and i.MX6 datasheet says "When Tx clock pin set as an input, the TCSEL settings are ignored".Signed-off-by Hui Wang <[email protected]>
Acked-by Shawn Guo <[email protected]>
Quoted 21 lines
--- sound/soc/fsl/imx-sgtl5000.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)sound/soc/fsl/imx-sgtl5000.c +1
-2@@ -95,8 +95,7 @@ static int __devinit imx_sgtl5000_probe(struct platform_device *pdev)return ret; }imx_audmux_v2_configure_port (ext_port, -IMX_AUDMUX_V2_PTCR_SYN | -IMX_AUDMUX_V2_PTCR_TCSEL (int_port), +IMX_AUDMUX_V2_PTCR_SYN ,IMX_AUDMUX_V2_PDCR_RXDSEL (int_port));if (ret) {dev_err (&pdev->dev,"audmux external port setup failed\n" );Signature · 1 line
1.7.6
Mark Brown
AppliedQuoted 5 lines · Hui Wang
If we don't set
IMX_AUDMUX_V2_PTCR_TCLKDIRin the AUDMUX PTCR register (means Tx clock pin is input), we don't need to setIMX_AUDMUX_V2_PTCR_TCSELas well. Since both i.MX35, i.MX51 and i.MX6 datasheet says "When Tx clock pin set as an input, the TCSEL settings are ignored".
Applied, thanks.