qt1010: signedness bug in qt1010_init_meas1()
Subsystems (2)
PATCH 1/1 qt1010: signedness bug in qt1010_init_meas1()
qt1010_init_meas2() returns zero on success and negative error codes on failure so the return type should be int instead of u8.
Signed-off-by Dan Carpenter <[email protected]>
drivers/media/common/tuners/qt1010.c +1 -1
@@ -288,7 +288,7 @@ static int qt1010_init_meas1(struct qt1010_priv *priv,return qt1010_writereg (priv,0x1e ,0x00 ); } -static u8 qt1010_init_meas2 (struct qt1010_priv *priv, +static int qt1010_init_meas2 (struct qt1010_priv *priv,u8 reg_init_val,u8 *retval) {u8 i, val;
Quoted 4 lines · Dan Carpenter
qt1010_init_meas2()returns zero on success and negative error codes on failure so the return type should be int instead of u8.Signed-off-by Dan Carpenter <[email protected]>
Acked-by Antti Palosaari <[email protected]>
Quoted 15 lines
drivers/media/common/tuners/qt1010.c +1
-1@@ -288,7 +288,7 @@ static int qt1010_init_meas1(struct qt1010_priv *priv,return qt1010_writereg (priv,0x1e ,0x00 ); } -static u8 qt1010_init_meas2 (struct qt1010_priv *priv, +static int qt1010_init_meas2 (struct qt1010_priv *priv,u8 reg_init_val,u8 *retval) {u8 i, val;
Signature · 1 line
http://palosaari.fi/