Skip to contentSkip to conversation

qt1010: signedness bug in qt1010_init_meas1()

PATCH In review Dan Carpenter 2 participants 2 messages Aug 10, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qt1010: signedness bug in qt1010_init_meas1()

qt1010_init_meas2() returns zero on success and negative error codes on failure so the return type should be int instead of u8.

drivers/media/common/tuners/qt1010.c +1 -1
index 2d79b1f..bdc39e1 100644
@@ -288,7 +288,7 @@ static int qt1010_init_meas1(struct qt1010_priv *priv,
 	return qt1010_writereg(priv, 0x1e, 0x00);
 }
 
-static u8 qt1010_init_meas2(struct qt1010_priv *priv,
+static int qt1010_init_meas2(struct qt1010_priv *priv,
 			    u8 reg_init_val, u8 *retval)
 {
 	u8 i, val;
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Dan Carpenter

qt1010_init_meas2() returns zero on success and negative error codes on failure so the return type should be int instead of u8.

Quoted 15 lines
drivers/media/common/tuners/qt1010.c +1 -1
index 2d79b1f..bdc39e1 100644
@@ -288,7 +288,7 @@ static int qt1010_init_meas1(struct qt1010_priv *priv,
  	return qt1010_writereg(priv, 0x1e, 0x00);
  }
 
-static u8 qt1010_init_meas2(struct qt1010_priv *priv,
+static int qt1010_init_meas2(struct qt1010_priv *priv,
  			    u8 reg_init_val, u8 *retval)
  {
  	u8 i, val;
Signature · 1 line
http://palosaari.fi/