mx28evk: Remove unneeded 'undef'
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/2 mx28evk: Remove unneeded 'undef'
From: Fabio Estevam <[email protected]>
There is no need to undef an option that is not enabled by default.
--- include/configs/mx28evk.h | 1 - 1 file changed, 1 deletion(-)
include/configs/mx28evk.h +0 -1
@@ -215,7 +215,6 @@#define CONFIG_SF_DEFAULT_SPEED 24000000/* (redundant) environemnt in SPI flash */ -#undef CONFIG_ENV_IS_IN_SPI_FLASH#ifdef CONFIG_ENV_IS_IN_SPI_FLASH #define CONFIG_SYS_REDUNDAND_ENVIRONMENT #define CONFIG_ENV_SIZE 0x1000/* 4KB */
Signature · 1 line
1.7.9.5
Fabio Estevam
reviewerPATCH 2/2 mxs: Use correct function name to initialize dram
From: Fabio Estevam <[email protected]>
commit d92591a (mxs: Convert sys_proto.h prefixes to 'mxs') introduced a mxs_dram_init() function, which is not used anywhere.
Fix it, so that the following warning goes away:
mx28evk.c: In function ?dram_init?:
mx28evk.c:67:2: warning: implicit declaration of function ?mx28_dram_init? [-Wimplicit-function-declaration]
--- arch/arm/include/asm/arch-mxs/sys_proto.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/include/asm/arch-mxs/sys_proto.h +1 -1
@@ -69,6 +69,6 @@ struct mxs_spl_data { uint32_t mem_dram_size; }; -int mxs_dram_init (void ); +int mx28_dram_init (void );#endif /* __SYS_PROTO_H__ */
Signature · 1 line
1.7.9.5
PATCH 2/2 mxs: Use correct function name to initialize dram
Dear Fabio Estevam,
Quoted 21 lines
From: Fabio Estevam <[email protected]>
commit d92591a (mxs: Convert
sys_proto.hprefixes to 'mxs') introduced amxs_dram_init()function, which is not used anywhere.Fix it, so that the following warning goes away:
mx28evk.c: In function ?dram_init?:
mx28evk.c:67:2: warning: implicit declaration of function ?mx28_dram_init? [-Wimplicit-function-declaration]Signed-off-by Fabio Estevam <[email protected]>--- arch/arm/include/asm/arch-mxs/sys_proto.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/arch/arm/include/asm/arch-mxs/sys_proto.hindex 9d1e599..4610363 100644
arch/arm/include/asm/arch-mxs/sys_proto.h struct mxs_spl_data { · line 74
Quoted 7 lines
arch/arm/include/asm/arch-mxs/sys_proto.h +1
-1@@ -69,6 +69,6 @@ struct mxs_spl_data { uint32_t mem_dram_size; }; -int mxs_dram_init (void ); +int mx28_dram_init (void );#endif /* __SYS_PROTO_H__ */
Best regards,
Marek Vasut
PATCH 2/2 mxs: Use correct function name to initialize dram
In reply to Fabio EstevamQuoted 11 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
commit d92591a (mxs: Convert
sys_proto.hprefixes to 'mxs') introduced amxs_dram_init()function, which is not used anywhere.Fix it, so that the following warning goes away:
mx28evk.c: In function ?dram_init?:
mx28evk.c:67:2: warning: implicit declaration of function ?mx28_dram_init? [-Wimplicit-function-declaration]Signed-off-by Fabio Estevam <[email protected]>
Signature · 3 lines
Otavio Salvador O.S. Systems E-mail: otavio at ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
Fabio Estevam
reviewerPATCH 2/2 mxs: Use correct function name to initialize dram
In reply to Fabio EstevamHi Stefano,
Quoted 11 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
commit d92591a (mxs: Convert
sys_proto.hprefixes to 'mxs') introduced amxs_dram_init()function, which is not used anywhere.Fix it, so that the following warning goes away:
mx28evk.c: In function ?dram_init?:
mx28evk.c:67:2: warning: implicit declaration of function ?mx28_dram_init? [-Wimplicit-function-declaration]Signed-off-by Fabio Estevam <[email protected]>
Please discard this patch.
Otavio fixed it in another patch related to mx23 series.
Regards,
Fabio Estevam
Fabio Estevam
reviewerPATCH 2/2 mxs: Use correct function name to initialize dram
Quoted 3 lines · Fabio Estevam
Please discard this patch.
Otavio fixed it in another patch related to mx23 series.
Ops, sorry. Otavio based his patch on top of mine, so this one needs to be applied.
Thanks,
Fabio Estevam
PATCH 2/2 mxs: Use correct function name to initialize dram
Quoted 8 lines · Fabio Estevam
Quoted 3 lines · Fabio Estevam
Please discard this patch.
Otavio fixed it in another patch related to mx23 series.
Ops, sorry. Otavio based his patch on top of mine, so this one needs to be applied.
It shouldn't matter; GIT will do a 3way merge and apply I think.
Signature · 3 lines
Otavio Salvador O.S. Systems E-mail: otavio at ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
PATCH 2/2 mxs: Use correct function name to initialize dram
In reply to Fabio EstevamQuoted 21 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
commit d92591a (mxs: Convert
sys_proto.hprefixes to 'mxs') introduced amxs_dram_init()function, which is not used anywhere.Fix it, so that the following warning goes away:
mx28evk.c: In function ?dram_init?:
mx28evk.c:67:2: warning: implicit declaration of function ?mx28_dram_init? [-Wimplicit-function-declaration]Signed-off-by Fabio Estevam <[email protected]>--- arch/arm/include/asm/arch-mxs/sys_proto.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/include/asm/arch-mxs/sys_proto.h +0
-0
arch/arm/include/asm/arch-mxs/sys_proto.h struct mxs_spl_data { · line 74
Quoted 7 lines
arch/arm/include/asm/arch-mxs/sys_proto.h +1
-1@@ -69,6 +69,6 @@ struct mxs_spl_data { uint32_t mem_dram_size; }; -int mxs_dram_init (void ); +int mx28_dram_init (void );#endif /* __SYS_PROTO_H__ */
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 1/2 mx28evk: Remove unneeded 'undef'
In reply to Fabio EstevamDear Fabio Estevam,
Quoted 14 lines
From: Fabio Estevam <[email protected]>
There is no need to undef an option that is not enabled by default.
Signed-off-by Fabio Estevam <[email protected]>--- include/configs/mx28evk.h | 1 - 1 file changed, 1 deletion(-)include/configs/mx28evk.h +0
-0
include/configs/mx28evk.h line 220
Quoted 7 lines
include/configs/mx28evk.h +0
-1@@ -215,7 +215,6 @@#define CONFIG_SF_DEFAULT_SPEED 24000000/* (redundant) environemnt in SPI flash */ -#undef CONFIG_ENV_IS_IN_SPI_FLASH#ifdef CONFIG_ENV_IS_IN_SPI_FLASH #define CONFIG_SYS_REDUNDAND_ENVIRONMENT #define CONFIG_ENV_SIZE 0x1000/* 4KB */
Best regards,
Marek Vasut
PATCH 1/2 mx28evk: Remove unneeded 'undef'
In reply to Fabio EstevamQuoted 15 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
There is no need to undef an option that is not enabled by default.
Signed-off-by Fabio Estevam <[email protected]>--- include/configs/mx28evk.h | 1 - 1 file changed, 1 deletion(-)include/configs/mx28evk.h +0
-0
include/configs/mx28evk.h line 220
Quoted 7 lines
include/configs/mx28evk.h +0
-1@@ -215,7 +215,6 @@#define CONFIG_SF_DEFAULT_SPEED 24000000/* (redundant) environemnt in SPI flash */ -#undef CONFIG_ENV_IS_IN_SPI_FLASH#ifdef CONFIG_ENV_IS_IN_SPI_FLASH #define CONFIG_SYS_REDUNDAND_ENVIRONMENT #define CONFIG_ENV_SIZE 0x1000/* 4KB */
Regards,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 1/2 mx28evk: Remove unneeded 'undef'
In reply to Fabio EstevamQuoted 15 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
There is no need to undef an option that is not enabled by default.
Signed-off-by Fabio Estevam <[email protected]>--- include/configs/mx28evk.h | 1 - 1 file changed, 1 deletion(-)include/configs/mx28evk.h +0
-0
include/configs/mx28evk.h line 220
Quoted 7 lines
include/configs/mx28evk.h +0
-1@@ -215,7 +215,6 @@#define CONFIG_SF_DEFAULT_SPEED 24000000/* (redundant) environemnt in SPI flash */ -#undef CONFIG_ENV_IS_IN_SPI_FLASH#ifdef CONFIG_ENV_IS_IN_SPI_FLASH #define CONFIG_SYS_REDUNDAND_ENVIRONMENT #define CONFIG_ENV_SIZE 0x1000/* 4KB */
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================