Skip to contentSkip to conversation

mx28evk: Remove unneeded 'undef'

PATCH New Fabio Estevam 4 participants 11 messages Aug 18, 2012 – Aug 20, 2012

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/2 mx28evk: Remove unneeded 'undef'

From: Fabio Estevam <[email protected]>

There is no need to undef an option that is not enabled by default.

---
 include/configs/mx28evk.h |    1 -
 1 file changed, 1 deletion(-)
include/configs/mx28evk.h +0 -1
index 4e70617..b677e51 100644
@@ -215,7 +215,6 @@
 #define CONFIG_SF_DEFAULT_SPEED		24000000
 
 /* (redundant) environemnt in SPI flash */
-#undef CONFIG_ENV_IS_IN_SPI_FLASH
 #ifdef CONFIG_ENV_IS_IN_SPI_FLASH
 #define CONFIG_SYS_REDUNDAND_ENVIRONMENT
 #define CONFIG_ENV_SIZE			0x1000		/* 4KB */
Signature · 1 line
1.7.9.5
author reviewer
#1 lore raw

PATCH 2/2 mxs: Use correct function name to initialize dram

From: Fabio Estevam <[email protected]>

commit d92591a (mxs: Convert sys_proto.h prefixes to 'mxs') introduced a mxs_dram_init() function, which is not used anywhere.

Fix it, so that the following warning goes away:

mx28evk.c: In function ?dram_init?:
mx28evk.c:67:2: warning: implicit declaration of function ?mx28_dram_init? [-Wimplicit-function-declaration]

---
 arch/arm/include/asm/arch-mxs/sys_proto.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/include/asm/arch-mxs/sys_proto.h +1 -1
index 9d1e599..4610363 100644
@@ -69,6 +69,6 @@ struct mxs_spl_data {
 	uint32_t	mem_dram_size;
 };
 
-int mxs_dram_init(void);
+int mx28_dram_init(void);
 
 #endif	/* __SYS_PROTO_H__ */
Signature · 1 line
1.7.9.5
#8 lore raw

PATCH 1/2 mx28evk: Remove unneeded 'undef'

In reply to Fabio Estevam

Dear Fabio Estevam,

Quoted 14 lines

From: Fabio Estevam <[email protected]>

There is no need to undef an option that is not enabled by default.

---
 include/configs/mx28evk.h |    1 -
 1 file changed, 1 deletion(-)
include/configs/mx28evk.h +0 -0
index 4e70617..b677e51 100644

include/configs/mx28evk.h line 220

Quoted 7 lines
include/configs/mx28evk.h +0 -1
@@ -215,7 +215,6 @@
 #define CONFIG_SF_DEFAULT_SPEED		24000000
 
 /* (redundant) environemnt in SPI flash */
-#undef CONFIG_ENV_IS_IN_SPI_FLASH
 #ifdef CONFIG_ENV_IS_IN_SPI_FLASH
 #define CONFIG_SYS_REDUNDAND_ENVIRONMENT
 #define CONFIG_ENV_SIZE			0x1000		/* 4KB */

Best regards,
Marek Vasut

#2 lore raw

PATCH 2/2 mxs: Use correct function name to initialize dram

In reply to Fabio Estevam

Dear Fabio Estevam,

Quoted 21 lines

From: Fabio Estevam <[email protected]>

commit d92591a (mxs: Convert sys_proto.h prefixes to 'mxs') introduced a mxs_dram_init() function, which is not used anywhere.

Fix it, so that the following warning goes away:

mx28evk.c: In function ?dram_init?:
mx28evk.c:67:2: warning: implicit declaration of function ?mx28_dram_init? [-Wimplicit-function-declaration]

---
 arch/arm/include/asm/arch-mxs/sys_proto.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/arch/arm/include/asm/arch-mxs/sys_proto.h index 9d1e599..4610363 100644

arch/arm/include/asm/arch-mxs/sys_proto.h struct mxs_spl_data { · line 74

Quoted 7 lines
arch/arm/include/asm/arch-mxs/sys_proto.h +1 -1
@@ -69,6 +69,6 @@ struct mxs_spl_data {
 	uint32_t	mem_dram_size;
 };
 
-int mxs_dram_init(void);
+int mx28_dram_init(void);
 
 #endif	/* __SYS_PROTO_H__ */

Best regards,
Marek Vasut

#9 lore raw

PATCH 1/2 mx28evk: Remove unneeded 'undef'

In reply to Fabio Estevam
Quoted 15 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

There is no need to undef an option that is not enabled by default.

---
 include/configs/mx28evk.h |    1 -
 1 file changed, 1 deletion(-)
include/configs/mx28evk.h +0 -0
index 4e70617..b677e51 100644

include/configs/mx28evk.h line 220

Quoted 7 lines
include/configs/mx28evk.h +0 -1
@@ -215,7 +215,6 @@
 #define CONFIG_SF_DEFAULT_SPEED		24000000
 
 /* (redundant) environemnt in SPI flash */
-#undef CONFIG_ENV_IS_IN_SPI_FLASH
 #ifdef CONFIG_ENV_IS_IN_SPI_FLASH
 #define CONFIG_SYS_REDUNDAND_ENVIRONMENT
 #define CONFIG_ENV_SIZE			0x1000		/* 4KB */

Regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH 2/2 mxs: Use correct function name to initialize dram

In reply to Fabio Estevam
Quoted 11 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

commit d92591a (mxs: Convert sys_proto.h prefixes to 'mxs') introduced a mxs_dram_init() function, which is not used anywhere.

Fix it, so that the following warning goes away:

mx28evk.c: In function ?dram_init?:
mx28evk.c:67:2: warning: implicit declaration of function ?mx28_dram_init? [-Wimplicit-function-declaration]

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
author reviewer
#4 lore raw

PATCH 2/2 mxs: Use correct function name to initialize dram

In reply to Fabio Estevam

Hi Stefano,

Quoted 11 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

commit d92591a (mxs: Convert sys_proto.h prefixes to 'mxs') introduced a mxs_dram_init() function, which is not used anywhere.

Fix it, so that the following warning goes away:

mx28evk.c: In function ?dram_init?:
mx28evk.c:67:2: warning: implicit declaration of function ?mx28_dram_init? [-Wimplicit-function-declaration]

Please discard this patch.

Otavio fixed it in another patch related to mx23 series.

Regards,

Fabio Estevam

author reviewer
#5 lore raw

PATCH 2/2 mxs: Use correct function name to initialize dram

Quoted 3 lines · Fabio Estevam

Please discard this patch.

Otavio fixed it in another patch related to mx23 series.

Ops, sorry. Otavio based his patch on top of mine, so this one needs to be applied.

Thanks,

Fabio Estevam

#6 lore raw

PATCH 2/2 mxs: Use correct function name to initialize dram

Quoted 8 lines · Fabio Estevam
Quoted 3 lines · Fabio Estevam

Please discard this patch.

Otavio fixed it in another patch related to mx23 series.

Ops, sorry. Otavio based his patch on top of mine, so this one needs to be applied.

It shouldn't matter; GIT will do a 3way merge and apply I think.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
#10 lore raw

PATCH 1/2 mx28evk: Remove unneeded 'undef'

In reply to Fabio Estevam
Quoted 15 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

There is no need to undef an option that is not enabled by default.

---
 include/configs/mx28evk.h |    1 -
 1 file changed, 1 deletion(-)
include/configs/mx28evk.h +0 -0
index 4e70617..b677e51 100644

include/configs/mx28evk.h line 220

Quoted 7 lines
include/configs/mx28evk.h +0 -1
@@ -215,7 +215,6 @@
 #define CONFIG_SF_DEFAULT_SPEED		24000000
 
 /* (redundant) environemnt in SPI flash */
-#undef CONFIG_ENV_IS_IN_SPI_FLASH
 #ifdef CONFIG_ENV_IS_IN_SPI_FLASH
 #define CONFIG_SYS_REDUNDAND_ENVIRONMENT
 #define CONFIG_ENV_SIZE			0x1000		/* 4KB */

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#7 lore raw

PATCH 2/2 mxs: Use correct function name to initialize dram

In reply to Fabio Estevam
Quoted 21 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

commit d92591a (mxs: Convert sys_proto.h prefixes to 'mxs') introduced a mxs_dram_init() function, which is not used anywhere.

Fix it, so that the following warning goes away:

mx28evk.c: In function ?dram_init?:
mx28evk.c:67:2: warning: implicit declaration of function ?mx28_dram_init? [-Wimplicit-function-declaration]

---
 arch/arm/include/asm/arch-mxs/sys_proto.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/include/asm/arch-mxs/sys_proto.h +0 -0
index 9d1e599..4610363 100644

arch/arm/include/asm/arch-mxs/sys_proto.h struct mxs_spl_data { · line 74

Quoted 7 lines
arch/arm/include/asm/arch-mxs/sys_proto.h +1 -1
@@ -69,6 +69,6 @@ struct mxs_spl_data {
 	uint32_t	mem_dram_size;
 };
 
-int mxs_dram_init(void);
+int mx28_dram_init(void);
 
 #endif	/* __SYS_PROTO_H__ */

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================