Skip to contentSkip to conversation

pulse: Support 24-bit formats

PATCH In review Andrew Eikum 2 participants 5 messages Aug 17, 2012 – Aug 20, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pulse: Support 24-bit formats

These formats were introduced in PulseAudio 0.9.15. There aren't any new formats supported since then, so this also brings the PulseAudio plugin in sync with current PulseAudio.

---

There was a problem once before with a patch I submitted. This is using format-patch and imap-send, so hopefully it goes through better than it did before :)

 pulse/pcm_pulse.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
pulse/pcm_pulse.c +20 -0
index e0fbd4c..24fd4da 100644
@@ -820,6 +820,26 @@ static int pulse_hw_params(snd_pcm_ioplug_t * io,
 		pcm->ss.format = PA_SAMPLE_S32BE;
 		break;
 #endif
+#ifdef PA_SAMPLE_S24LE
+	case SND_PCM_FORMAT_S24_3LE:
+		pcm->ss.format = PA_SAMPLE_S24LE;
+		break;
+#endif
+#ifdef PA_SAMPLE_S24BE
+	case SND_PCM_FORMAT_S24_3BE:
+		pcm->ss.format = PA_SAMPLE_S24BE;
+		break;
+#endif
+#ifdef PA_SAMPLE_S24_32LE
+	case SND_PCM_FORMAT_S24_LE:
+		pcm->ss.format = PA_SAMPLE_S24_32LE;
+		break;
+#endif
+#ifdef PA_SAMPLE_S24_32BE
+	case SND_PCM_FORMAT_S24_BE:
+		pcm->ss.format = PA_SAMPLE_S24_32BE;
+		break;
+#endif
 	default:
 		SNDERR("PulseAudio: Unsupported format %s\n",
 			snd_pcm_format_name(io->format));
#1 lore raw

At Fri, 17 Aug 2012 15:41:07 -0500,

Quoted 11 lines · Andrew Eikum

These formats were introduced in PulseAudio 0.9.15. There aren't any new formats supported since then, so this also brings the PulseAudio plugin in sync with current PulseAudio.

---

There was a problem once before with a patch I submitted. This is using format-patch and imap-send, so hopefully it goes through better than it did before :)

Well, unfortunately it's not a preferred form of the patch. The patch commit log must be embedded in the patch itself. That is, the text above including your sign-off must be in the git commit log, then generate the patch via git-format-patch or git show --pretty=email.

In anyway, I applied your patch manually now.
Please try the right way at the next time.

thanks,

Takashi

Quoted 41 lines
 pulse/pcm_pulse.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

[2 0001-pulse-Support-24-bit-formats.patch <text/x-patch; us-ascii (8bit)>]

pulse/pcm_pulse.c +20 -0
index e0fbd4c..24fd4da 100644
@@ -820,6 +820,26 @@ static int pulse_hw_params(snd_pcm_ioplug_t * io,
 		pcm->ss.format = PA_SAMPLE_S32BE;
 		break;
 #endif
+#ifdef PA_SAMPLE_S24LE
+	case SND_PCM_FORMAT_S24_3LE:
+		pcm->ss.format = PA_SAMPLE_S24LE;
+		break;
+#endif
+#ifdef PA_SAMPLE_S24BE
+	case SND_PCM_FORMAT_S24_3BE:
+		pcm->ss.format = PA_SAMPLE_S24BE;
+		break;
+#endif
+#ifdef PA_SAMPLE_S24_32LE
+	case SND_PCM_FORMAT_S24_LE:
+		pcm->ss.format = PA_SAMPLE_S24_32LE;
+		break;
+#endif
+#ifdef PA_SAMPLE_S24_32BE
+	case SND_PCM_FORMAT_S24_BE:
+		pcm->ss.format = PA_SAMPLE_S24_32BE;
+		break;
+#endif
 	default:
 		SNDERR("PulseAudio: Unsupported format %s\n",
 			snd_pcm_format_name(io->format));

[3 <text/plain; us-ascii (7bit)>]
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#2 lore raw
Quoted 13 lines · Takashi Iwai

At Fri, 17 Aug 2012 15:41:07 -0500,

Quoted 10 lines · Andrew Eikum

These formats were introduced in PulseAudio 0.9.15. There aren't any new formats supported since then, so this also brings the PulseAudio plugin in sync with current PulseAudio.

---

There was a problem once before with a patch I submitted. This is using format-patch and imap-send, so hopefully it goes through better than it did before :)

Quoted 8 lines

Well, unfortunately it's not a preferred form of the patch. The patch commit log must be embedded in the patch itself. That is, the text above including your sign-off must be in the git commit log, then generate the patch via git-format-patch or git show --pretty=email.

In anyway, I applied your patch manually now.
Please try the right way at the next time.

I guess I'm used to how the Git project and the Wine maintainer do it. They import the entire mbox file with 'git am'. This works properly for the mail I sent, including putting the message and S-o-b line into the commit log and ignoring the bit between the --- and the patch.

I'll make sure the attachment itself contains all of those details next time.

Thanks for applying,
Andrew

#3 lore raw

At Mon, 20 Aug 2012 07:42:05 -0500,

Quoted 20 lines · Andrew Eikum
Quoted 18 lines · Takashi Iwai

At Fri, 17 Aug 2012 15:41:07 -0500,

Quoted 10 lines · Andrew Eikum

These formats were introduced in PulseAudio 0.9.15. There aren't any new formats supported since then, so this also brings the PulseAudio plugin in sync with current PulseAudio.

---

There was a problem once before with a patch I submitted. This is using format-patch and imap-send, so hopefully it goes through better than it did before :)

Well, unfortunately it's not a preferred form of the patch. The patch commit log must be embedded in the patch itself. That is, the text above including your sign-off must be in the git commit log, then generate the patch via git-format-patch or git show --pretty=email.

Quoted 8 lines
Quoted 3 lines

In anyway, I applied your patch manually now.
Please try the right way at the next time.

I guess I'm used to how the Git project and the Wine maintainer do it. They import the entire mbox file with 'git am'. This works properly for the mail I sent, including putting the message and S-o-b line into the commit log and ignoring the bit between the --- and the patch.

git-am isn't designed for a separate patch with attachment. It's for an embedded patch. It might work with attachment casually but it's not the intended workflow.

Takashi

#4 lore raw
Quoted 26 lines · Takashi Iwai

At Mon, 20 Aug 2012 07:42:05 -0500,

Quoted 24 lines · Andrew Eikum
Quoted 21 lines · Takashi Iwai

At Fri, 17 Aug 2012 15:41:07 -0500,

Quoted 10 lines · Andrew Eikum

These formats were introduced in PulseAudio 0.9.15. There aren't any new formats supported since then, so this also brings the PulseAudio plugin in sync with current PulseAudio.

---

There was a problem once before with a patch I submitted. This is using format-patch and imap-send, so hopefully it goes through better than it did before :)

Well, unfortunately it's not a preferred form of the patch. The patch commit log must be embedded in the patch itself. That is, the text above including your sign-off must be in the git commit log, then generate the patch via git-format-patch or git show --pretty=email.

In anyway, I applied your patch manually now.
Please try the right way at the next time.

Quoted 9 lines
Quoted 4 lines

I guess I'm used to how the Git project and the Wine maintainer do it. They import the entire mbox file with 'git am'. This works properly for the mail I sent, including putting the message and S-o-b line into the commit log and ignoring the bit between the --- and the patch.

git-am isn't designed for a separate patch with attachment. It's for an embedded patch. It might work with attachment casually but it's not the intended workflow.

Ah, I didn't know that. Thanks for the info.

Andrew