Per sub-architecture SMP operations
Subsystems (11)
v9 cover Per sub-architecture SMP operations
As I promised at the ARM mini summit, I've updated Marc's series for smp operations according to my complaints. Unfortunately, I could not find version 7 of the patches when I started this, so I based my work on version 6 and had to redo the same changes.
The patches are also available on
git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git testing/smp_ops
Arnd
Changelog:
Quoted 1 line
From v8:
- removed the string concatenating macros
- consolidated structures into a single smp_operations
- removed trivial instances of platform_cpu_kill and platform_cpu_disable, now handled by the default case
- split shmobile_cpu_kill into three separate functions, per soc
Quoted 1 line
From v7:
- Dropped soc_desc, and focussed only on smp_ops
- Fixed CONFIG_HOTPLUG_CPU typo (courtesy of Shawn Guo)
- Marked {realview,vexpress}_cpu_die() as __cpuinit
- Added support for spear13xx
- Added pen_release consolidation (based on Arnd Bergman's patch)
Quoted 1 line
From v6:
- Dropped the dummy_* stuff
- Support for a number of new platforms
- Added the soc_hotplug_ops() macro to hide some #ifdef-ery away
- More exynos[ 45] churn
- Fixed section mismatches
Quoted 1 line
From v5:
- Added support for highbank and imx6q
- Added support for new shmobile SMP platform
- Add dummy_cpu_kill, dummy_cpu_disable and cpu_lowpower
Quoted 1 line
From v4:
- Added an SMP registration interface and moved all SMP structures to smp.c. The end result is much cleaner.
- Cleaned up patch 2 (leftovers from a previous rework)
- NVIDIA/EXYNOS4 naming cleanup.
Quoted 1 line
From v3:
- Converted all SMP platforms
- Added some cleanup as a last patch
Quoted 1 line
From v2:
- Split the SMP ops between init and runtime operations in order to have separate lifetimes for the different structures. This is not perfect though, as it still allows an __init function to make it to a runtime structure (all smp_*_ops structures are __initdata in order to be able to discard them). Thanks to Nico for pointing this out.
- Use macros to hide the #ifdef-ery in the SoC descriptor init, courtesy of Arnd.
Quoted 1 line
From v1:
- Move the SMP ops out of the descriptor, which makes the structure init a bit cleaner (thanks to Arnd).
- Mark all structures __initdata and keep a copy of the used ones.
- Keep a global pointer for the SMP ops.
Arnd Bergmann (1):
ARM: SoC: convert spear13xx to SoC descriptor
Marc Zyngier (12):
ARM: SoC: add per-platform SMP operations
ARM: SoC: convert VExpress/RealView to SoC descriptor
ARM: SoC: convert OMAP4 to SoC descriptor
ARM: SoC: convert Tegra to SoC descriptor
ARM: SoC: convert Exynos4 to SoC descriptor
ARM: SoC: convert MSM SMP to SoC descriptor
ARM: SoC: convert ux500 to SoC descriptor
ARM: SoC: convert shmobile SMP to SoC descriptor
ARM: SoC: convert highbank to SoC descriptor
ARM: SoC: convert imx6q to SoC descriptor
ARM: smp: Make SoC descriptor mandatory for SMP platforms
ARM: consolidate pen_release instead of having per platform
definitions
arch/arm/include/asm/mach/arch.h | 7 ++ arch/arm/include/asm/smp.h | 48 ++++++++---- arch/arm/kernel/setup.c | 5 +- arch/arm/kernel/smp.c | 72 +++++++++++++++++- arch/arm/mach-exynos/common.h | 5 ++ arch/arm/mach-exynos/hotplug.c | 18 +---- arch/arm/mach-exynos/mach-armlex4210.c | 1 + arch/arm/mach-exynos/mach-exynos5-dt.c | 1 + arch/arm/mach-exynos/mach-nuri.c | 1 + arch/arm/mach-exynos/mach-origen.c | 1 + arch/arm/mach-exynos/mach-smdk4x12.c | 2 + arch/arm/mach-exynos/mach-smdkv310.c | 2 + arch/arm/mach-exynos/mach-universal_c210.c | 1 + arch/arm/mach-exynos/platsmp.c | 27 ++++--- arch/arm/mach-highbank/core.h | 3 + arch/arm/mach-highbank/highbank.c | 1 + arch/arm/mach-highbank/hotplug.c | 16 +--- arch/arm/mach-highbank/platsmp.c | 18 ++++- arch/arm/mach-imx/hotplug.c | 16 +--- arch/arm/mach-imx/mach-imx6q.c | 1 + arch/arm/mach-imx/platsmp.c | 18 ++++- arch/arm/mach-msm/board-msm8960.c | 3 + arch/arm/mach-msm/board-msm8x60.c | 7 ++ arch/arm/mach-msm/core.h | 2 + arch/arm/mach-msm/hotplug.c | 18 +---- arch/arm/mach-msm/platsmp.c | 24 +++--- arch/arm/mach-omap2/board-4430sdp.c | 1 + arch/arm/mach-omap2/board-generic.c | 2 + arch/arm/mach-omap2/board-omap4panda.c | 1 + arch/arm/mach-omap2/common.h | 5 ++ arch/arm/mach-omap2/omap-hotplug.c | 16 +--- arch/arm/mach-omap2/omap-smp.c | 18 ++++- arch/arm/mach-realview/core.h | 3 + arch/arm/mach-realview/hotplug.c | 18 +---- arch/arm/mach-realview/platsmp.c | 18 ++++- arch/arm/mach-realview/realview_pb11mp.c | 1 + arch/arm/mach-realview/realview_pbx.c | 1 + arch/arm/mach-shmobile/board-ag5evm.c | 1 + arch/arm/mach-shmobile/board-kota2.c | 1 + arch/arm/mach-shmobile/board-kzm9d.c | 1 + arch/arm/mach-shmobile/board-kzm9g.c | 1 + arch/arm/mach-shmobile/board-marzen.c | 1 + arch/arm/mach-shmobile/hotplug.c | 31 +++----- arch/arm/mach-shmobile/include/mach/common.h | 24 +++--- arch/arm/mach-shmobile/include/mach/emev2.h | 7 +- arch/arm/mach-shmobile/include/mach/r8a7779.h | 2 + arch/arm/mach-shmobile/include/mach/sh73a0.h | 2 + arch/arm/mach-shmobile/platsmp.c | 96 +----------------------- arch/arm/mach-shmobile/setup-emev2.c | 1 + arch/arm/mach-shmobile/smp-emev2.c | 47 ++++++++++-- arch/arm/mach-shmobile/smp-r8a7779.c | 48 ++++++++++-- arch/arm/mach-shmobile/smp-sh73a0.c | 48 +++++++++++- arch/arm/mach-spear13xx/hotplug.c | 22 +----- arch/arm/mach-spear13xx/include/mach/generic.h | 3 + arch/arm/mach-spear13xx/platsmp.c | 25 +++--- arch/arm/mach-spear13xx/spear1310.c | 1 + arch/arm/mach-spear13xx/spear1340.c | 1 + arch/arm/mach-tegra/board-dt-tegra20.c | 2 + arch/arm/mach-tegra/board-dt-tegra30.c | 2 + arch/arm/mach-tegra/board-harmony.c | 2 + arch/arm/mach-tegra/board-paz00.c | 2 + arch/arm/mach-tegra/board-trimslice.c | 2 + arch/arm/mach-tegra/common.c | 1 + arch/arm/mach-tegra/common.h | 3 + arch/arm/mach-tegra/hotplug.c | 16 +--- arch/arm/mach-tegra/platsmp.c | 20 ++++- arch/arm/mach-ux500/board-mop500.c | 4 + arch/arm/mach-ux500/hotplug.c | 36 ++------- arch/arm/mach-ux500/include/mach/setup.h | 3 + arch/arm/mach-ux500/platsmp.c | 24 +++--- arch/arm/mach-vexpress/core.h | 4 + arch/arm/mach-vexpress/hotplug.c | 18 +---- arch/arm/mach-vexpress/platsmp.c | 18 ++++- arch/arm/mach-vexpress/v2m.c | 4 + arch/arm/plat-mxc/include/mach/common.h | 4 + arch/arm/plat-versatile/include/plat/platsmp.h | 14 ++++ arch/arm/plat-versatile/platsmp.c | 10 +-- 77 files changed, 545 insertions(+), 409 deletions(-) create mode 100644 arch/arm/mach-msm/core.h create mode 100644 arch/arm/mach-tegra/common.h create mode 100644 arch/arm/plat-versatile/include/plat/platsmp.h
Signature · 1 line
1.7.10
PATCH v9 1/13 ARM: SoC: add per-platform SMP operations
From: Marc Zyngier <[email protected]>
This adds a 'struct smp_operations' to abstract the CPU initialization and hot plugging functions on SMP systems, which otherwise conflict in a multiplatform kernel. This also helps shmobile and potentially others that have more than one method to do these.
To allow the kernel to continue building, the platform hooks are defined as weak symbols which are overrided by the platform code. Once all platforms are converted, the "weak" attribute will be removed and the function made static.
Unlike the original version from Marc, this new version from Arnd does not use a generalized abstraction for per-soc data structures but only tries to solve the problem for the SMP operations. This way, we can collapse the previous four data structures into a single struct, which is less systematic but also easier to follow as a causal reader.
--- arch/arm/include/asm/mach/arch.h | 7 +++++ arch/arm/include/asm/smp.h | 33 ++++++++++++++++++++ arch/arm/kernel/setup.c | 5 ++- arch/arm/kernel/smp.c | 62 +++++++++++++++++++++++++++++++++++++- 4 files changed, 105 insertions(+), 2 deletions(-)
arch/arm/include/asm/mach/arch.h +7 -0
@@ -14,6 +14,12 @@ struct tag;struct meminfo ;struct sys_timer ;struct pt_regs ; +struct smp_operations ; +#ifdef CONFIG_SMP +#define smp_ops (ops) (&(ops)) +#else +#define smp_ops (ops) (struct smp_operations *)NULL +#endif struct machine_desc {unsigned int nr;/* architecture number */
@@ -35,6 +41,7 @@ struct machine_desc { unsigned char reserve_lp1 :1; /* never has lp1 */ unsigned char reserve_lp2 :1; /* never has lp2 */char restart_mode;/* default restart mode */ +struct smp_operations *smp;/* SMP operations */ void (*fixup)(struct tag *,char **,struct meminfo *);void (*reserve)(void );/* reserve mem blocks */
arch/arm/include/asm/smp.h +33 -0
@@ -93,4 +93,37 @@ extern void platform_cpu_enable(unsigned int cpu);extern void arch_send_call_function_single_ipi (int cpu);extern void arch_send_call_function_ipi_mask (const struct cpumask *mask); +struct smp_operations { +#ifdef CONFIG_SMP +/* +* Setup the set of possible CPUs (via set_cpu_possible) +*/ +void (*smp_init_cpus)(void ); +/* +* Initialize cpu_possible map, and enable coherency +*/ +void (*smp_prepare_cpus)(unsigned int max_cpus); + +/* +* Perform platform specific initialisation of the specified CPU. +*/ +void (*smp_secondary_init)(unsigned int cpu); +/* +* Boot a secondary CPU, and assign it the specified idle task. +* This also gives us the initial stack to use for this CPU. +*/ +int (*smp_boot_secondary)(unsigned int cpu,struct task_struct *idle); +#ifdef CONFIG_HOTPLUG_CPU +int (*cpu_kill)(unsigned int cpu); +void (*cpu_die)(unsigned int cpu); +int (*cpu_disable)(unsigned int cpu); +#endif +#endif +}; + +/* +* set platform specific SMP operations +*/ +extern void smp_set_ops (struct smp_operations *); +#endif /* ifndef __ASM_ARM_SMP_H */
arch/arm/kernel/setup.c +4 -1
@@ -144,6 +144,7 @@ static const char *cpu_name;static const char *machine_name;static char __initdata cmd_line[COMMAND_LINE_SIZE ];struct machine_desc *machine_desc__initdata ; +static const struct smp_operations *smp_ops__initdata ;static char default_command_line[COMMAND_LINE_SIZE ]__initdata =CONFIG_CMDLINE ;static union {char c[4 ];unsigned long l; } endian_test__initdata = { {'l' ,'?' ,'?' ,'b' } };
@@ -977,8 +978,10 @@ void __init setup_arch(char **cmdline_p)unflatten_device_tree ();#ifdef CONFIG_SMP -if (is_smp ()) +if (is_smp ()) { +smp_set_ops (mdesc->smp);smp_init_cpus (); + }#endif reserve_crashkernel ();
arch/arm/kernel/smp.c +61 -1
95 lines not on this page · raw message
Signature · 1 line
1.7.10
PATCH v9 2/13 ARM: SoC: convert VExpress/RealView to SoC descriptor
In reply to Arnd BergmannFrom: Marc Zyngier <[email protected]>
Convert both Realview and VExpress to use the SoC descriptor to provide their SMP and CPU hotplug operation.
--- arch/arm/mach-realview/core.h | 3 +++ arch/arm/mach-realview/hotplug.c | 16 +--------------- arch/arm/mach-realview/platsmp.c | 18 ++++++++++++++---- arch/arm/mach-realview/realview_pb11mp.c | 1 + arch/arm/mach-realview/realview_pbx.c | 1 + arch/arm/mach-vexpress/core.h | 4 ++++ arch/arm/mach-vexpress/hotplug.c | 16 +--------------- arch/arm/mach-vexpress/platsmp.c | 18 ++++++++++++++---- arch/arm/mach-vexpress/v2m.c | 4 ++++ arch/arm/plat-versatile/include/plat/platsmp.h | 14 ++++++++++++++ arch/arm/plat-versatile/platsmp.c | 4 ++-- 11 files changed, 59 insertions(+), 40 deletions(-) create mode 100644 arch/arm/plat-versatile/include/plat/platsmp.h
arch/arm/mach-realview/core.h +3 -0
@@ -56,4 +56,7 @@ extern void realview_init_early(void);extern void realview_fixup (struct tag *tags,char **from,struct meminfo *meminfo); +extern struct smp_operations realview_smp_ops; +extern void realview_cpu_die (unsigned int cpu); +#endif
arch/arm/mach-realview/hotplug.c +1 -15
@@ -89,17 +89,12 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious) } } -int platform_cpu_kill (unsigned int cpu) -{ -return 1 ; -} -/* * platform-specific code to shutdown a CPU * * Called with IRQs disabled */ -void platform_cpu_die (unsigned int cpu) +void realview_cpu_die (unsigned int cpu) {int spurious =0 ;
@@ -118,12 +113,3 @@ void platform_cpu_die(unsigned int cpu)if (spurious)pr_warn ("CPU%u: %u spurious wakeup calls\n" , cpu, spurious); } - -int platform_cpu_disable (unsigned int cpu) -{ -/* -* we don't allow CPU 0 to be shutdown (it is still too special -* e.g. clock tick interrupts) -*/ -return cpu ==0 ? -EPERM :0 ; -}
arch/arm/mach-realview/platsmp.c +14 -4
@@ -22,9 +22,9 @@#include <mach/board-pb11mp.h> #include <mach/board-pbx.h> -#include "core.h" +#include <plat/platsmp.h> -extern void versatile_secondary_startup (void ); +#include "core.h" static void __iomem *scu_base_addr (void ) {
@@ -43,7 +43,7 @@ static void __iomem *scu_base_addr(void)* Initialise the CPU possible map early - this describes the CPUs * which may be present or become present in the system. */ -void __init smp_init_cpus (void ) +static void __init realview_smp_init_cpus (void ) {void __iomem *scu_base =scu_base_addr ();unsigned int i, ncores;
@@ -63,7 +63,7 @@ void __init smp_init_cpus(void)set_smp_cross_call (gic_raise_softirq); } -void __init platform_smp_prepare_cpus (unsigned int max_cpus) +static void __init realview_smp_prepare_cpus (unsigned int max_cpus) {scu_enable (scu_base_addr ());
@@ -77,3 +77,13 @@ void __init platform_smp_prepare_cpus(unsigned int max_cpus)__raw_writel (virt_to_phys (versatile_secondary_startup),__io_address (REALVIEW_SYS_FLAGSSET )); } + +struct smp_operations realview_smp_ops__initdata = { + .smp_init_cpus = realview_smp_init_cpus, + .smp_prepare_cpus = realview_smp_prepare_cpus, + .smp_secondary_init = versatile_secondary_init, + .smp_boot_secondary = versatile_boot_secondary, +#ifdef CONFIG_HOTPLUG_CPU + .cpu_die = realview_cpu_die, +#endif +};
arch/arm/mach-realview/realview_pb11mp.c +1 -0
@@ -366,6 +366,7 @@ static void __init realview_pb11mp_init(void)MACHINE_START (REALVIEW_PB11MP ,"ARM-RealView PB11MPCore" )/* Maintainer: ARM Ltd/Deep Blue Solutions Ltd */ .atag_offset = 0x100, + .smp = smp_ops(realview_smp_ops), .fixup = realview_fixup, .map_io = realview_pb11mp_map_io, .init_early = realview_init_early,
arch/arm/mach-realview/realview_pbx.c +1 -0
@@ -403,6 +403,7 @@ static void __init realview_pbx_init(void)MACHINE_START (REALVIEW_PBX ,"ARM-RealView PBX" )/* Maintainer: ARM Ltd/Deep Blue Solutions Ltd */ .atag_offset = 0x100, + .smp = smp_ops(realview_smp_ops), .fixup = realview_pbx_fixup, .map_io = realview_pbx_map_io, .init_early = realview_init_early,
arch/arm/mach-vexpress/core.h +4 -0
@@ -5,3 +5,7 @@#define V2T_PERIPH 0xf8200000void vexpress_dt_smp_map_io (void ); + +extern struct smp_operations vexpress_smp_ops; + +extern void vexpress_cpu_die (unsigned int cpu);
arch/arm/mach-vexpress/hotplug.c +1 -15
@@ -84,17 +84,12 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious) } } -int platform_cpu_kill (unsigned int cpu) -{ -return 1 ; -} -/* * platform-specific code to shutdown a CPU * * Called with IRQs disabled */ -void platform_cpu_die (unsigned int cpu) +void __cpuinit vexpress_cpu_die (unsigned int cpu) {int spurious =0 ;
@@ -113,12 +108,3 @@ void platform_cpu_die(unsigned int cpu)if (spurious)pr_warn ("CPU%u: %u spurious wakeup calls\n" , cpu, spurious); } - -int platform_cpu_disable (unsigned int cpu) -{ -/* -* we don't allow CPU 0 to be shutdown (it is still too special -* e.g. clock tick interrupts) -*/ -return cpu ==0 ? -EPERM :0 ; -}
arch/arm/mach-vexpress/platsmp.c +14 -4
@@ -20,9 +20,9 @@#include <mach/motherboard.h> -#include "core.h" +#include <plat/platsmp.h> -extern void versatile_secondary_startup (void ); +#include "core.h" #if defined(CONFIG_OF )
@@ -167,7 +167,7 @@ void __init vexpress_dt_smp_prepare_cpus(unsigned int max_cpus)* Initialise the CPU possible map early - this describes the CPUs * which may be present or become present in the system. */ -void __init smp_init_cpus (void ) +static void __init vexpress_smp_init_cpus (void ) {if (ct_desc) ct_desc->init_cpu_map ();
@@ -176,7 +176,7 @@ void __init smp_init_cpus(void) } -void __init platform_smp_prepare_cpus (unsigned int max_cpus) +static void __init vexpress_smp_prepare_cpus (unsigned int max_cpus) {/* * Initialise the present map, which describes the set of CPUs
@@ -195,3 +195,13 @@ void __init platform_smp_prepare_cpus(unsigned int max_cpus)*/ v2m_flags_set (virt_to_phys (versatile_secondary_startup)); } + +struct smp_operations __initdata vexpress_smp_ops = { + .smp_init_cpus = vexpress_smp_init_cpus, + .smp_prepare_cpus = vexpress_smp_prepare_cpus, + .smp_secondary_init = versatile_secondary_init, + .smp_boot_secondary = versatile_boot_secondary, +#ifdef CONFIG_HOTPLUG_CPU + .cpu_die = vexpress_cpu_die, +#endif +};
arch/arm/mach-vexpress/v2m.c +4 -0
@@ -5,6 +5,7 @@#include <linux/amba/bus.h> #include <linux/amba/mmci.h> #include <linux/io.h> +#include <linux/smp.h> #include <linux/init.h> #include <linux/of_address.h> #include <linux/of_fdt.h>
@@ -38,6 +39,7 @@#include <mach/motherboard.h> #include <plat/sched_clock.h> +#include <plat/platsmp.h> #include "core.h"
@@ -530,6 +532,7 @@ static void __init v2m_init(void)MACHINE_START (VEXPRESS ,"ARM-Versatile Express" ) .atag_offset = 0x100, + .smp = smp_ops(vexpress_smp_ops), .map_io = v2m_map_io, .init_early = v2m_init_early, .init_irq = v2m_init_irq,
@@ -663,6 +666,7 @@ const static char *v2m_dt_match[] __initconst = {DT_MACHINE_START (VEXPRESS_DT ,"ARM-Versatile Express" ) .dt_compat = v2m_dt_match, + .smp = smp_ops(vexpress_smp_ops), .map_io = v2m_dt_map_io, .init_early = v2m_dt_init_early, .init_irq = v2m_dt_init_irq,
arch/arm/plat-versatile/include/plat/platsmp.h new file +14 -0
@@ -0,0 +1,14 @@ +/* +* linux/arch/arm/plat-versatile/include/plat/platsmp.h +* +* Copyright (C) 2011 ARM Ltd. +* All Rights Reserved +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License version 2 as +* published by the Free Software Foundation. +*/ + +extern void versatile_secondary_startup (void ); +extern void versatile_secondary_init (unsigned int cpu); +extern int versatile_boot_secondary (unsigned int cpu,struct task_struct *idle);
arch/arm/plat-versatile/platsmp.c +2 -2
@@ -40,7 +40,7 @@ static void __cpuinit write_pen_release(int val)static DEFINE_SPINLOCK (boot_lock); -void __cpuinit platform_secondary_init (unsigned int cpu) +void __cpuinit versatile_secondary_init (unsigned int cpu) {/* * if any interrupts are already enabled for the primary
@@ -62,7 +62,7 @@ void __cpuinit platform_secondary_init(unsigned int cpu)spin_unlock (&boot_lock); } -int __cpuinit boot_secondary (unsigned int cpu,struct task_struct *idle) +int __cpuinit versatile_boot_secondary (unsigned int cpu,struct task_struct *idle) {unsigned long timeout;
Signature · 1 line
1.7.10
PATCH v9 3/13 ARM: SoC: convert OMAP4 to SoC descriptor
In reply to Arnd BergmannFrom: Marc Zyngier <[email protected]>
Convert OMAP4 to use the SoC descriptor to provide its SMP and CPU hotplug operations.
Tested on both Panda and IGEPv2 (MULTI_OMAP kernel)
--- arch/arm/mach-omap2/board-4430sdp.c | 1 + arch/arm/mach-omap2/board-generic.c | 2 ++ arch/arm/mach-omap2/board-omap4panda.c | 1 + arch/arm/mach-omap2/common.h | 5 +++++ arch/arm/mach-omap2/omap-hotplug.c | 16 +--------------- arch/arm/mach-omap2/omap-smp.c | 18 ++++++++++++++---- 6 files changed, 24 insertions(+), 19 deletions(-)
arch/arm/mach-omap2/board-4430sdp.c +1 -0
@@ -909,6 +909,7 @@ static void __init omap_4430sdp_init(void)MACHINE_START (OMAP_4430SDP ,"OMAP4430 4430SDP board" )/* Maintainer: Santosh Shilimkar - Texas Instruments Inc */ .atag_offset = 0x100, + .smp = smp_ops(omap4_smp_ops), .reserve = omap_reserve, .map_io = omap4_map_io, .init_early = omap4430_init_early,
arch/arm/mach-omap2/board-generic.c +2 -0
@@ -127,6 +127,7 @@ static const char *omap4_boards_compat[] __initdata = {DT_MACHINE_START (OMAP4_DT ,"Generic OMAP4 (Flattened Device Tree)" ) .reserve = omap_reserve, + .smp = smp_ops(omap4_smp_ops), .map_io = omap4_map_io, .init_early = omap4430_init_early, .init_irq = omap_gic_of_init,
@@ -147,6 +148,7 @@ static const char *omap5_boards_compat[] __initdata = {DT_MACHINE_START (OMAP5_DT ,"Generic OMAP5 (Flattened Device Tree)" ) .reserve = omap_reserve, + .smp = smp_ops(omap4_smp_ops), .map_io = omap5_map_io, .init_early = omap5_init_early, .init_irq = omap_gic_of_init,
arch/arm/mach-omap2/board-omap4panda.c +1 -0
@@ -518,6 +518,7 @@ static void __init omap4_panda_init(void)MACHINE_START (OMAP4_PANDA ,"OMAP4 Panda board" )/* Maintainer: David Anders - Texas Instruments Inc */ .atag_offset = 0x100, + .smp = smp_ops(omap4_smp_ops), .reserve = omap_reserve, .map_io = omap4_map_io, .init_early = omap4430_init_early,
arch/arm/mach-omap2/common.h +5 -0
@@ -278,6 +278,11 @@ extern void omap_secondary_startup(void);extern u32 omap_modify_auxcoreboot0 (u32 set_mask,u32 clear_mask);extern void omap_auxcoreboot_addr (u32 cpu_addr);extern u32 omap_read_auxcoreboot0 (void ); + +extern void omap4_cpu_die (unsigned int cpu); + +extern struct smp_operations omap4_smp_ops; +extern void omap5_secondary_startup (void );#endif
arch/arm/mach-omap2/omap-hotplug.c +1 -15
@@ -26,16 +26,11 @@#include "powerdomain.h" -int platform_cpu_kill (unsigned int cpu) -{ -return 1 ; -} -/* * platform-specific code to shutdown a CPU * Called with IRQs disabled */ -void __ref platform_cpu_die (unsigned int cpu) +void __ref omap4_cpu_die (unsigned int cpu) {unsigned int boot_cpu =0 ;void __iomem *base =omap_get_wakeupgen_base ();
@@ -75,12 +70,3 @@ void __ref platform_cpu_die(unsigned int cpu)pr_debug ("CPU%u: spurious wakeup call\n" , cpu); } } - -int platform_cpu_disable (unsigned int cpu) -{ -/* -* we don't allow CPU 0 to be shutdown (it is still too special -* e.g. clock tick interrupts) -*/ -return cpu ==0 ? -EPERM :0 ; -}
arch/arm/mach-omap2/omap-smp.c +14 -4
@@ -49,7 +49,7 @@ void __iomem *omap4_get_scu_base(void)return scu_base; } -void __cpuinit platform_secondary_init (unsigned int cpu) +static void __cpuinit omap4_secondary_init (unsigned int cpu) {/* * Configure ACTRL and enable NS SMP bit access on CPU1 on HS device.
@@ -77,7 +77,7 @@ void __cpuinit platform_secondary_init(unsigned int cpu)spin_unlock (&boot_lock); } -int __cpuinit boot_secondary (unsigned int cpu,struct task_struct *idle) +static int __cpuinit omap4_boot_secondary (unsigned int cpu,struct task_struct *idle) {static struct clockdomain *cpu1_clkdm;static bool booted;
@@ -165,7 +165,7 @@ static void __init wakeup_secondary(void)* Initialise the CPU possible map early - this describes the CPUs * which may be present or become present in the system. */ -void __init smp_init_cpus (void ) +static void __init omap4_smp_init_cpus (void ) {unsigned int i =0 , ncores =1 , cpu_id;
@@ -196,7 +196,7 @@ void __init smp_init_cpus(void)set_smp_cross_call (gic_raise_softirq); } -void __init platform_smp_prepare_cpus (unsigned int max_cpus) +static void __init omap4_smp_prepare_cpus (unsigned int max_cpus) {/*
@@ -207,3 +207,13 @@ void __init platform_smp_prepare_cpus(unsigned int max_cpus)scu_enable (scu_base);wakeup_secondary (); } + +struct smp_operations omap4_smp_ops__initdata = { + .smp_init_cpus = omap4_smp_init_cpus, + .smp_prepare_cpus = omap4_smp_prepare_cpus, + .smp_secondary_init = omap4_secondary_init, + .smp_boot_secondary = omap4_boot_secondary, +#ifdef CONFIG_HOTPLUG_CPU + .cpu_die = omap4_cpu_die, +#endif +};
Signature · 1 line
1.7.10
PATCH v9 4/13 ARM: SoC: convert Tegra to SoC descriptor
In reply to Arnd BergmannFrom: Marc Zyngier <[email protected]>
Convert Tegra to use the SoC descriptor to provide its SMP and CPU hotplug operations.
Tested on Harmony.
--- arch/arm/mach-tegra/board-dt-tegra20.c | 2 ++ arch/arm/mach-tegra/board-dt-tegra30.c | 2 ++ arch/arm/mach-tegra/board-harmony.c | 2 ++ arch/arm/mach-tegra/board-paz00.c | 2 ++ arch/arm/mach-tegra/board-trimslice.c | 2 ++ arch/arm/mach-tegra/common.c | 1 + arch/arm/mach-tegra/common.h | 3 +++ arch/arm/mach-tegra/hotplug.c | 16 +--------------- arch/arm/mach-tegra/platsmp.c | 20 ++++++++++++++++---- 9 files changed, 31 insertions(+), 19 deletions(-) create mode 100644 arch/arm/mach-tegra/common.h
arch/arm/mach-tegra/board-dt-tegra20.c +2 -0
@@ -45,6 +45,7 @@#include "board-harmony.h" #include "clock.h" #include "devices.h" +#include "common.h" struct of_dev_auxdata tegra20_auxdata_lookup[]__initdata = {OF_DEV_AUXDATA ("nvidia,tegra20-sdhci" ,TEGRA_SDMMC1_BASE ,"sdhci-tegra.0" ,NULL ),
@@ -166,6 +167,7 @@ static const char *tegra20_dt_board_compat[] = {DT_MACHINE_START (TEGRA_DT ,"nVidia Tegra20 (Flattened Device Tree)" ) .map_io = tegra_map_common_io, + .smp = smp_ops(tegra_smp_ops), .init_early = tegra20_init_early, .init_irq = tegra_dt_init_irq, .handle_irq = gic_handle_irq,
arch/arm/mach-tegra/board-dt-tegra30.c +2 -0
@@ -37,6 +37,7 @@#include "board.h" #include "clock.h" +#include "common.h" struct of_dev_auxdata tegra30_auxdata_lookup[]__initdata = {OF_DEV_AUXDATA ("nvidia,tegra20-sdhci" ,0x78000000 ,"sdhci-tegra.0" ,NULL ),
@@ -83,6 +84,7 @@ static const char *tegra30_dt_board_compat[] = { };DT_MACHINE_START (TEGRA30_DT ,"NVIDIA Tegra30 (Flattened Device Tree)" ) + .smp = smp_ops(tegra_smp_ops), .map_io = tegra_map_common_io, .init_early = tegra30_init_early, .init_irq = tegra_dt_init_irq,
arch/arm/mach-tegra/board-harmony.c +2 -0
@@ -45,6 +45,7 @@#include "clock.h" #include "devices.h" #include "gpio-names.h" +#include "common.h" static struct plat_serial8250_port debug_uart_platform_data[] = { {
@@ -185,6 +186,7 @@ static void __init tegra_harmony_init(void)MACHINE_START (HARMONY ,"harmony" ) .atag_offset = 0x100, + .smp = smp_ops(tegra_smp_ops), .fixup = tegra_harmony_fixup, .map_io = tegra_map_common_io, .init_early = tegra20_init_early,
arch/arm/mach-tegra/board-paz00.c +2 -0
@@ -47,6 +47,7 @@#include "clock.h" #include "devices.h" #include "gpio-names.h" +#include "common.h" static struct plat_serial8250_port debug_uart_platform_data[] = { {
@@ -223,6 +224,7 @@ static void __init tegra_paz00_init(void)MACHINE_START (PAZ00 ,"Toshiba AC100 / Dynabook AZ" ) .atag_offset = 0x100, + .smp = smp_ops(tegra_smp_ops), .fixup = tegra_paz00_fixup, .map_io = tegra_map_common_io, .init_early = tegra20_init_early,
arch/arm/mach-tegra/board-trimslice.c +2 -0
@@ -40,6 +40,7 @@#include "clock.h" #include "devices.h" #include "gpio-names.h" +#include "common.h" #include "board-trimslice.h"
@@ -171,6 +172,7 @@ static void __init tegra_trimslice_init(void)MACHINE_START (TRIMSLICE ,"trimslice" ) .atag_offset = 0x100, + .smp = smp_ops(tegra_smp_ops), .fixup = tegra_trimslice_fixup, .map_io = tegra_map_common_io, .init_early = tegra20_init_early,
arch/arm/mach-tegra/common.c +1 -0
@@ -31,6 +31,7 @@#include "board.h" #include "clock.h" +#include "common.h" #include "fuse.h" #include "pmc.h" #include "apbio.h"
arch/arm/mach-tegra/common.h new file +3 -0
@@ -0,0 +1,3 @@ +extern struct smp_operations tegra_smp_ops; + +extern void tegra_cpu_die (unsigned int cpu);
arch/arm/mach-tegra/hotplug.c +1 -15
@@ -87,17 +87,12 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious) } } -int platform_cpu_kill (unsigned int cpu) -{ -return 1 ; -} -/* * platform-specific code to shutdown a CPU * * Called with IRQs disabled */ -void platform_cpu_die (unsigned int cpu) +void tegra_cpu_die (unsigned int cpu) {int spurious =0 ;
@@ -116,12 +111,3 @@ void platform_cpu_die(unsigned int cpu)if (spurious)pr_warn ("CPU%u: %u spurious wakeup calls\n" , cpu, spurious); } - -int platform_cpu_disable (unsigned int cpu) -{ -/* -* we don't allow CPU 0 to be shutdown (it is still too special -* e.g. clock tick interrupts) -*/ -return cpu ==0 ? -EPERM :0 ; -}
arch/arm/mach-tegra/platsmp.c +16 -4
@@ -32,6 +32,8 @@#include "flowctrl.h" #include "reset.h" +#include "common.h" +extern void tegra_secondary_startup (void );static void __iomem *scu_base =IO_ADDRESS (TEGRA_ARM_PERIF_BASE );
@@ -50,7 +52,7 @@ static void __iomem *scu_base = IO_ADDRESS(TEGRA_ARM_PERIF_BASE);#define CPU_CLOCK (cpu) (0x1<<(8+cpu))#define CPU_RESET (cpu) (0x1111ul<<(cpu)) -void __cpuinit platform_secondary_init (unsigned int cpu) +static void __cpuinit tegra_secondary_init (unsigned int cpu) {/* * if any interrupts are already enabled for the primary
@@ -117,7 +119,7 @@ static int tegra30_power_up_cpu(unsigned int cpu)return 0 ; } -int __cpuinit boot_secondary (unsigned int cpu,struct task_struct *idle) +static int __cpuinit tegra_boot_secondary (unsigned int cpu,struct task_struct *idle) {int status;
@@ -165,7 +167,7 @@ done:* Initialise the CPU possible map early - this describes the CPUs * which may be present or become present in the system. */ -void __init smp_init_cpus (void ) +static void __init tegra_smp_init_cpus (void ) {unsigned int i, ncores =scu_get_core_count (scu_base);
@@ -181,8 +183,18 @@ void __init smp_init_cpus(void)set_smp_cross_call (gic_raise_softirq); } -void __init platform_smp_prepare_cpus (unsigned int max_cpus) +static void __init tegra_smp_prepare_cpus (unsigned int max_cpus) {tegra_cpu_reset_handler_init ();scu_enable (scu_base); } + +struct smp_operations tegra_smp_ops__initdata = { + .smp_init_cpus = tegra_smp_init_cpus, + .smp_prepare_cpus = tegra_smp_prepare_cpus, + .smp_secondary_init = tegra_secondary_init, + .smp_boot_secondary = tegra_boot_secondary, +#ifdef CONFIG_HOTPLUG_CPU + .cpu_die = tegra_cpu_die, +#endif +};
Signature · 1 line
1.7.10
PATCH v9 5/13 ARM: SoC: convert Exynos4 to SoC descriptor
In reply to Arnd BergmannFrom: Marc Zyngier <[email protected]>
Convert Exynos4 to use the SoC descriptor to provide its SMP and CPU hotplug operations.
--- arch/arm/mach-exynos/common.h | 5 +++++ arch/arm/mach-exynos/hotplug.c | 18 +++--------------- arch/arm/mach-exynos/mach-armlex4210.c | 1 + arch/arm/mach-exynos/mach-exynos5-dt.c | 1 + arch/arm/mach-exynos/mach-nuri.c | 1 + arch/arm/mach-exynos/mach-origen.c | 1 + arch/arm/mach-exynos/mach-smdk4x12.c | 2 ++ arch/arm/mach-exynos/mach-smdkv310.c | 2 ++ arch/arm/mach-exynos/mach-universal_c210.c | 1 + arch/arm/mach-exynos/platsmp.c | 20 ++++++++++++++++---- 10 files changed, 33 insertions(+), 19 deletions(-)
arch/arm/mach-exynos/common.h +5 -0
@@ -14,6 +14,7 @@extern struct sys_timer exynos4_timer; +struct map_desc ;void exynos_init_io (struct map_desc *mach_desc,int size);void exynos4_init_irq (void );void exynos5_init_irq (void );
@@ -59,4 +60,8 @@ void exynos4212_register_clocks(void);#define exynos4212_register_clocks ()#endif +extern struct smp_operations exynos_smp_ops; + +extern void exynos_cpu_die (unsigned int cpu); +#endif /* __ARCH_ARM_MACH_EXYNOS_COMMON_H */
arch/arm/mach-exynos/hotplug.c +3 -15
@@ -21,6 +21,8 @@#include <mach/regs-pmu.h> +#include "common.h" +extern volatile int pen_release;static inline void cpu_enter_lowpower (void )
@@ -95,17 +97,12 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious) } } -int platform_cpu_kill (unsigned int cpu) -{ -return 1 ; -} -/* * platform-specific code to shutdown a CPU * * Called with IRQs disabled */ -void platform_cpu_die (unsigned int cpu) +void __cpuinit exynos_cpu_die (unsigned int cpu) {int spurious =0 ;
@@ -124,12 +121,3 @@ void platform_cpu_die(unsigned int cpu)if (spurious)pr_warn ("CPU%u: %u spurious wakeup calls\n" , cpu, spurious); } - -int platform_cpu_disable (unsigned int cpu) -{ -/* -* we don't allow CPU 0 to be shutdown (it is still too special -* e.g. clock tick interrupts) -*/ -return cpu ==0 ? -EPERM :0 ; -}
arch/arm/mach-exynos/mach-armlex4210.c +1 -0
@@ -199,6 +199,7 @@ static void __init armlex4210_machine_init(void)MACHINE_START (ARMLEX4210 ,"ARMLEX4210" )/* Maintainer: Alim Akhtar <[email protected]> */ .atag_offset = 0x100, + .smp = smp_ops(exynos_smp_ops), .init_irq = exynos4_init_irq, .map_io = armlex4210_map_io, .handle_irq = gic_handle_irq,
arch/arm/mach-exynos/mach-exynos5-dt.c +1 -0
@@ -79,6 +79,7 @@ static char const *exynos5250_dt_compat[] __initdata = {DT_MACHINE_START (EXYNOS5_DT ,"SAMSUNG EXYNOS5 (Flattened Device Tree)" )/* Maintainer: Kukjin Kim <[email protected]> */ .init_irq = exynos5_init_irq, + .smp = smp_ops(exynos_smp_ops), .map_io = exynos5250_dt_map_io, .handle_irq = gic_handle_irq, .init_machine = exynos5250_dt_machine_init,
arch/arm/mach-exynos/mach-nuri.c +1 -0
@@ -1383,6 +1383,7 @@ static void __init nuri_machine_init(void)MACHINE_START (NURI ,"NURI" )/* Maintainer: Kyungmin Park <[email protected]> */ .atag_offset = 0x100, + .smp = smp_ops(exynos_smp_ops), .init_irq = exynos4_init_irq, .map_io = nuri_map_io, .handle_irq = gic_handle_irq,
arch/arm/mach-exynos/mach-origen.c +1 -0
@@ -806,6 +806,7 @@ static void __init origen_machine_init(void)MACHINE_START (ORIGEN ,"ORIGEN" )/* Maintainer: JeongHyeon Kim <[email protected]> */ .atag_offset = 0x100, + .smp = smp_ops(exynos_smp_ops), .init_irq = exynos4_init_irq, .map_io = origen_map_io, .handle_irq = gic_handle_irq,
arch/arm/mach-exynos/mach-smdk4x12.c +2 -0
@@ -370,6 +370,7 @@ static void __init smdk4x12_machine_init(void)MACHINE_START (SMDK4212 ,"SMDK4212" )/* Maintainer: Kukjin Kim <[email protected]> */ .atag_offset = 0x100, + .smp = smp_ops(exynos_smp_ops), .init_irq = exynos4_init_irq, .map_io = smdk4x12_map_io, .handle_irq = gic_handle_irq,
@@ -383,6 +384,7 @@ MACHINE_START(SMDK4412, "SMDK4412")/* Maintainer: Kukjin Kim <[email protected]> */ /* Maintainer: Changhwan Youn <[email protected]> */ .atag_offset = 0x100, + .smp = smp_ops(exynos_smp_ops), .init_irq = exynos4_init_irq, .map_io = smdk4x12_map_io, .handle_irq = gic_handle_irq,
arch/arm/mach-exynos/mach-smdkv310.c +2 -0
@@ -417,6 +417,7 @@ MACHINE_START(SMDKV310, "SMDKV310")/* Maintainer: Kukjin Kim <[email protected]> */ /* Maintainer: Changhwan Youn <[email protected]> */ .atag_offset = 0x100, + .smp = smp_ops(exynos_smp_ops), .init_irq = exynos4_init_irq, .map_io = smdkv310_map_io, .handle_irq = gic_handle_irq,
@@ -429,6 +430,7 @@ MACHINE_ENDMACHINE_START (SMDKC210 ,"SMDKC210" )/* Maintainer: Kukjin Kim <[email protected]> */ .atag_offset = 0x100, + .smp = smp_ops(exynos_smp_ops), .init_irq = exynos4_init_irq, .map_io = smdkv310_map_io, .handle_irq = gic_handle_irq,
arch/arm/mach-exynos/mach-universal_c210.c +1 -0
@@ -1155,6 +1155,7 @@ static void __init universal_machine_init(void)MACHINE_START (UNIVERSAL_C210 ,"UNIVERSAL_C210" )/* Maintainer: Kyungmin Park <[email protected]> */ .atag_offset = 0x100, + .smp = smp_ops(exynos_smp_ops), .init_irq = exynos4_init_irq, .map_io = universal_map_io, .handle_irq = gic_handle_irq,
arch/arm/mach-exynos/platsmp.c +16 -4
@@ -32,6 +32,8 @@#include <plat/cpu.h> +#include "common.h" +extern void exynos4_secondary_startup (void );#define CPU1_BOOT_REG (samsung_rev() == EXYNOS4210_REV_1_1 ? \
@@ -64,7 +66,7 @@ static void __iomem *scu_base_addr(void)static DEFINE_SPINLOCK (boot_lock); -void __cpuinit platform_secondary_init (unsigned int cpu) +static void __cpuinit exynos_secondary_init (unsigned int cpu) {/* * if any interrupts are already enabled for the primary
@@ -86,7 +88,7 @@ void __cpuinit platform_secondary_init(unsigned int cpu)spin_unlock (&boot_lock); } -int __cpuinit boot_secondary (unsigned int cpu,struct task_struct *idle) +static int __cpuinit exynos_boot_secondary (unsigned int cpu,struct task_struct *idle) {unsigned long timeout;
@@ -161,7 +163,7 @@ int __cpuinit boot_secondary(unsigned int cpu, struct task_struct *idle)* which may be present or become present in the system. */ -void __init smp_init_cpus (void ) +static void __init exynos_smp_init_cpus (void ) {void __iomem *scu_base =scu_base_addr ();unsigned int i, ncores;
@@ -184,7 +186,7 @@ void __init smp_init_cpus(void)set_smp_cross_call (gic_raise_softirq); } -void __init platform_smp_prepare_cpus (unsigned int max_cpus) +static void __init exynos_smp_prepare_cpus (unsigned int max_cpus) {if (!soc_is_exynos5250 ())scu_enable (scu_base_addr ());
@@ -198,3 +200,13 @@ void __init platform_smp_prepare_cpus(unsigned int max_cpus)__raw_writel (virt_to_phys (exynos4_secondary_startup),CPU1_BOOT_REG ); } + +struct smp_operations exynos_smp_ops__initdata = { + .smp_init_cpus = exynos_smp_init_cpus, + .smp_prepare_cpus = exynos_smp_prepare_cpus, + .smp_secondary_init = exynos_secondary_init, + .smp_boot_secondary = exynos_boot_secondary, +#ifdef CONFIG_HOTPLUG_CPU + .cpu_die = exynos_cpu_die, +#endif +};
Signature · 1 line
1.7.10
Re: [PATCH v9 05/13] ARM: SoC: convert Exynos4 to SoC descriptor
Quoted 7 lines · Arnd Bergmann
From: Marc Zyngier <[email protected]>
Convert Exynos4 to use the SoC descriptor to provide its SMP and CPU hotplug operations.
Cc Kukjin Kim <[email protected]>Tested-by Kyungmin Park <[email protected]>
Quoted 266 lines
Signed-off-by Marc Zyngier <[email protected]>Signed-off-by Arnd Bergmann <[email protected]>--- arch/arm/mach-exynos/common.h | 5 +++++ arch/arm/mach-exynos/hotplug.c | 18 +++--------------- arch/arm/mach-exynos/mach-armlex4210.c | 1 + arch/arm/mach-exynos/mach-exynos5-dt.c | 1 + arch/arm/mach-exynos/mach-nuri.c | 1 + arch/arm/mach-exynos/mach-origen.c | 1 + arch/arm/mach-exynos/mach-smdk4x12.c | 2 ++ arch/arm/mach-exynos/mach-smdkv310.c | 2 ++ arch/arm/mach-exynos/mach-universal_c210.c | 1 + arch/arm/mach-exynos/platsmp.c | 20 ++++++++++++++++---- 10 files changed, 33 insertions(+), 19 deletions(-)arch/arm/mach-exynos/common.h +5
-0@@ -14,6 +14,7 @@extern struct sys_timer exynos4_timer; +struct map_desc ;void exynos_init_io (struct map_desc *mach_desc,int size);void exynos4_init_irq (void );void exynos5_init_irq (void );@@ -59,4 +60,8 @@ void exynos4212_register_clocks(void);#define exynos4212_register_clocks ()#endif +extern struct smp_operations exynos_smp_ops; + +extern void exynos_cpu_die (unsigned int cpu); +#endif /* __ARCH_ARM_MACH_EXYNOS_COMMON_H */ arch/arm/mach-exynos/hotplug.c +3
-15@@ -21,6 +21,8 @@#include <mach/regs-pmu.h> +#include "common.h" +extern volatile int pen_release;static inline void cpu_enter_lowpower (void )@@ -95,17 +97,12 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious) } } -int platform_cpu_kill (unsigned int cpu) -{ -return 1 ; -} -/* * platform-specific code to shutdown a CPU * * Called with IRQs disabled */ -void platform_cpu_die (unsigned int cpu) +void __cpuinit exynos_cpu_die (unsigned int cpu) {int spurious =0 ;@@ -124,12 +121,3 @@ void platform_cpu_die(unsigned int cpu)if (spurious)pr_warn ("CPU%u: %u spurious wakeup calls\n" , cpu, spurious); } - -int platform_cpu_disable (unsigned int cpu) -{ -/* -* we don't allow CPU 0 to be shutdown (it is still too special -* e.g. clock tick interrupts) -*/ -return cpu ==0 ? -EPERM :0 ; -}arch/arm/mach-exynos/mach-armlex4210.c +1
-0@@ -199,6 +199,7 @@ static void __init armlex4210_machine_init(void)MACHINE_START (ARMLEX4210 ,"ARMLEX4210" )/* Maintainer: Alim Akhtar <[email protected]> */ .atag_offset = 0x100, + .smp = smp_ops(exynos_smp_ops), .init_irq = exynos4_init_irq, .map_io = armlex4210_map_io, .handle_irq = gic_handle_irq,arch/arm/mach-exynos/mach-exynos5-dt.c +1
-0@@ -79,6 +79,7 @@ static char const *exynos5250_dt_compat[] __initdata = {DT_MACHINE_START (EXYNOS5_DT ,"SAMSUNG EXYNOS5 (Flattened Device Tree)" )/* Maintainer: Kukjin Kim <[email protected]> */ .init_irq = exynos5_init_irq, + .smp = smp_ops(exynos_smp_ops), .map_io = exynos5250_dt_map_io, .handle_irq = gic_handle_irq, .init_machine = exynos5250_dt_machine_init,arch/arm/mach-exynos/mach-nuri.c +1
-0@@ -1383,6 +1383,7 @@ static void __init nuri_machine_init(void)MACHINE_START (NURI ,"NURI" )/* Maintainer: Kyungmin Park <[email protected]> */ .atag_offset = 0x100, + .smp = smp_ops(exynos_smp_ops), .init_irq = exynos4_init_irq, .map_io = nuri_map_io, .handle_irq = gic_handle_irq,arch/arm/mach-exynos/mach-origen.c +1
-0@@ -806,6 +806,7 @@ static void __init origen_machine_init(void)MACHINE_START (ORIGEN ,"ORIGEN" )/* Maintainer: JeongHyeon Kim <[email protected]> */ .atag_offset = 0x100, + .smp = smp_ops(exynos_smp_ops), .init_irq = exynos4_init_irq, .map_io = origen_map_io, .handle_irq = gic_handle_irq,arch/arm/mach-exynos/mach-smdk4x12.c +2
-0@@ -370,6 +370,7 @@ static void __init smdk4x12_machine_init(void)MACHINE_START (SMDK4212 ,"SMDK4212" )/* Maintainer: Kukjin Kim <[email protected]> */ .atag_offset = 0x100, + .smp = smp_ops(exynos_smp_ops), .init_irq = exynos4_init_irq, .map_io = smdk4x12_map_io, .handle_irq = gic_handle_irq,@@ -383,6 +384,7 @@ MACHINE_START(SMDK4412, "SMDK4412")/* Maintainer: Kukjin Kim <[email protected]> */ /* Maintainer: Changhwan Youn <[email protected]> */ .atag_offset = 0x100, + .smp = smp_ops(exynos_smp_ops), .init_irq = exynos4_init_irq, .map_io = smdk4x12_map_io, .handle_irq = gic_handle_irq,arch/arm/mach-exynos/mach-smdkv310.c +2
-0@@ -417,6 +417,7 @@ MACHINE_START(SMDKV310, "SMDKV310")/* Maintainer: Kukjin Kim <[email protected]> */ /* Maintainer: Changhwan Youn <[email protected]> */ .atag_offset = 0x100, + .smp = smp_ops(exynos_smp_ops), .init_irq = exynos4_init_irq, .map_io = smdkv310_map_io, .handle_irq = gic_handle_irq,@@ -429,6 +430,7 @@ MACHINE_ENDMACHINE_START (SMDKC210 ,"SMDKC210" )/* Maintainer: Kukjin Kim <[email protected]> */ .atag_offset = 0x100, + .smp = smp_ops(exynos_smp_ops), .init_irq = exynos4_init_irq, .map_io = smdkv310_map_io, .handle_irq = gic_handle_irq,arch/arm/mach-exynos/mach-universal_c210.c +1
-0@@ -1155,6 +1155,7 @@ static void __init universal_machine_init(void)MACHINE_START (UNIVERSAL_C210 ,"UNIVERSAL_C210" )/* Maintainer: Kyungmin Park <[email protected]> */ .atag_offset = 0x100, + .smp = smp_ops(exynos_smp_ops), .init_irq = exynos4_init_irq, .map_io = universal_map_io, .handle_irq = gic_handle_irq,arch/arm/mach-exynos/platsmp.c +5
-3@@ -32,6 +32,8 @@#include <plat/cpu.h> +#include "common.h" +extern void exynos4_secondary_startup (void );#define CPU1_BOOT_REG (samsung_rev() == EXYNOS4210_REV_1_1 ? \@@ -64,7 +66,7 @@ static void __iomem *scu_base_addr(void)static DEFINE_SPINLOCK (boot_lock); -void __cpuinit platform_secondary_init (unsigned int cpu) +static void __cpuinit exynos_secondary_init (unsigned int cpu) {/* * if any interrupts are already enabled for the primary @@ -86,7 +88,7 @@ void __cpuinit platform_secondary_init(unsigned int cpu)spin_unlock (&boot_lock); } -int __cpuinit boot_secondary (unsigned int cpu,struct task_struct *idle) +static int __cpuinit exynos_boot_secondary (unsigned int cpu,struct task_struct *idle) {unsigned long timeout;@@ -161,7 +163,7 @@ int __cpuinit boot_secondary(unsigned int cpu, structtask_struct *idle) * which may be present or become present in the system. */ -void __init smp_init_cpus (void ) +static void __init exynos_smp_init_cpus (void ) {void __iomem *scu_base =scu_base_addr ();arch/arm/mach-exynos/platsmp.c +11
-2unsigned int i, ncores;@@ -184,7 +186,7 @@ void __init smp_init_cpus(void)set_smp_cross_call (gic_raise_softirq); } -void __init platform_smp_prepare_cpus (unsigned int max_cpus) +static void __init exynos_smp_prepare_cpus (unsigned int max_cpus) {if (!soc_is_exynos5250 ())scu_enable (scu_base_addr ());@@ -198,3 +200,13 @@ void __init platform_smp_prepare_cpus(unsigned int max_cpus)__raw_writel (virt_to_phys (exynos4_secondary_startup ),CPU1_BOOT_REG ); } + +struct smp_operations exynos_smp_ops__initdata = { + .smp_init_cpus = exynos_smp_init_cpus, + .smp_prepare_cpus = exynos_smp_prepare_cpus, + .smp_secondary_init = exynos_secondary_init, + .smp_boot_secondary = exynos_boot_secondary, +#ifdef CONFIG_HOTPLUG_CPU + .cpu_die = exynos_cpu_die, +#endif +}; --1.7.10
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v9 05/13] ARM: SoC: convert Exynos4 to SoC descriptor
In reply to Arnd BergmannQuoted 7 lines · Arnd Bergmann
From: Marc Zyngier <[email protected]>
Convert Exynos4 to use the SoC descriptor to provide its SMP and CPU hotplug operations.
Cc Kukjin Kim <[email protected]>
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
Quoted 15 lines
Tested-by Kyungmin Park <[email protected]>Signed-off-by Marc Zyngier <[email protected]>Signed-off-by Arnd Bergmann <[email protected]>--- arch/arm/mach-exynos/common.h | 5 +++++ arch/arm/mach-exynos/hotplug.c | 18 +++--------------- arch/arm/mach-exynos/mach-armlex4210.c | 1 + arch/arm/mach-exynos/mach-exynos5-dt.c | 1 + arch/arm/mach-exynos/mach-nuri.c | 1 + arch/arm/mach-exynos/mach-origen.c | 1 + arch/arm/mach-exynos/mach-smdk4x12.c | 2 ++ arch/arm/mach-exynos/mach-smdkv310.c | 2 ++ arch/arm/mach-exynos/mach-universal_c210.c | 1 + arch/arm/mach-exynos/platsmp.c | 20 ++++++++++++++++---- 10 files changed, 33 insertions(+), 19 deletions(-)
PATCH v9 6/13 ARM: SoC: convert MSM SMP to SoC descriptor
In reply to Arnd BergmannFrom: Marc Zyngier <[email protected]>
Convert MSM SMP platforms to use the SoC descriptor to provide their SMP and CPU hotplug operations.
--- arch/arm/mach-msm/board-msm8960.c | 3 +++ arch/arm/mach-msm/board-msm8x60.c | 7 +++++++ arch/arm/mach-msm/core.h | 2 ++ arch/arm/mach-msm/hotplug.c | 18 +++--------------- arch/arm/mach-msm/platsmp.c | 19 +++++++++++++++---- 5 files changed, 30 insertions(+), 19 deletions(-) create mode 100644 arch/arm/mach-msm/core.h
arch/arm/mach-msm/board-msm8960.c +3 -0
@@ -30,6 +30,7 @@#include <mach/board.h> #include <mach/msm_iomap.h> +#include "core.h" #include "devices.h" static void __init msm8960_fixup(struct tag *tag, char **cmdline,
@@ -99,6 +100,7 @@ static void __init msm8960_init_late(void) }MACHINE_START (MSM8960_SIM ,"QCT MSM8960 SIMULATOR" ) + .smp = smp_ops(msm_smp_ops), .fixup = msm8960_fixup, .reserve = msm8960_reserve, .map_io = msm8960_map_io,
@@ -110,6 +112,7 @@ MACHINE_START(MSM8960_SIM, "QCT MSM8960 SIMULATOR") MACHINE_END MACHINE_START(MSM8960_RUMI3, "QCT MSM8960 RUMI3") + .smp = smp_ops(msm_smp_ops), .fixup = msm8960_fixup, .reserve = msm8960_reserve, .map_io = msm8960_map_io,
arch/arm/mach-msm/board-msm8x60.c +7 -0
@@ -29,6 +29,8 @@#include <mach/board.h> #include <mach/msm_iomap.h> +#include "core.h" +static void __init msm8x60_fixup (struct tag *tag,char **cmdline,struct meminfo *mi) {
@@ -110,6 +112,7 @@ static const char *msm8x60_fluid_match[] __initdata = {#endif /* CONFIG_OF */ MACHINE_START (MSM8X60_RUMI3 ,"QCT MSM8X60 RUMI3" ) + .smp = smp_ops(msm_smp_ops), .fixup = msm8x60_fixup, .reserve = msm8x60_reserve, .map_io = msm8x60_map_io,
@@ -121,6 +124,7 @@ MACHINE_START(MSM8X60_RUMI3, "QCT MSM8X60 RUMI3") MACHINE_END MACHINE_START(MSM8X60_SURF, "QCT MSM8X60 SURF") + .smp = smp_ops(msm_smp_ops), .fixup = msm8x60_fixup, .reserve = msm8x60_reserve, .map_io = msm8x60_map_io,
@@ -132,6 +136,7 @@ MACHINE_START(MSM8X60_SURF, "QCT MSM8X60 SURF") MACHINE_END MACHINE_START(MSM8X60_SIM, "QCT MSM8X60 SIMULATOR") + .smp = smp_ops(msm_smp_ops), .fixup = msm8x60_fixup, .reserve = msm8x60_reserve, .map_io = msm8x60_map_io,
@@ -143,6 +148,7 @@ MACHINE_START(MSM8X60_SIM, "QCT MSM8X60 SIMULATOR") MACHINE_END MACHINE_START(MSM8X60_FFA, "QCT MSM8X60 FFA") + .smp = smp_ops(msm_smp_ops), .fixup = msm8x60_fixup, .reserve = msm8x60_reserve, .map_io = msm8x60_map_io,
@@ -156,6 +162,7 @@ MACHINE_END#ifdef CONFIG_OF /* TODO: General device tree support for all MSM. */ DT_MACHINE_START (MSM_DT ,"Qualcomm MSM (Flattened Device Tree)" ) + .smp = smp_ops(msm_smp_ops), .map_io = msm8x60_map_io, .init_irq = msm8x60_init_irq, .init_machine = msm8x60_dt_init,
arch/arm/mach-msm/core.h new file +2 -0
@@ -0,0 +1,2 @@ +extern struct smp_operations msm_smp_ops; +extern void msm_cpu_die (unsigned int cpu);
arch/arm/mach-msm/hotplug.c +3 -15
@@ -13,6 +13,8 @@#include <asm/cacheflush.h> #include <asm/smp_plat.h> +#include "core.h" +extern volatile int pen_release;static inline void cpu_enter_lowpower (void )
@@ -57,17 +59,12 @@ static inline void platform_do_lowpower(unsigned int cpu) } } -int platform_cpu_kill (unsigned int cpu) -{ -return 1 ; -} -/* * platform-specific code to shutdown a CPU * * Called with IRQs disabled */ -void platform_cpu_die (unsigned int cpu) +void msm_cpu_die (unsigned int cpu) {/* * we're ready for shutdown now, so do it
@@ -81,12 +78,3 @@ void platform_cpu_die(unsigned int cpu)*/ cpu_leave_lowpower (); } - -int platform_cpu_disable (unsigned int cpu) -{ -/* -* we don't allow CPU 0 to be shutdown (it is still too special -* e.g. clock tick interrupts) -*/ -return cpu ==0 ? -EPERM :0 ; -}
arch/arm/mach-msm/platsmp.c +15 -4
@@ -25,6 +25,7 @@#include <mach/msm_iomap.h> #include "scm-boot.h" +#include "core.h" #define VDD_SC1_ARRAY_CLAMP_GFS_CTL 0x15A0#define SCSS_CPU1CORE_RESET 0xD80
@@ -48,7 +49,7 @@ static inline int get_core_count(void)return ((read_cpuid_id () >>4 ) &3 ) +1 ; } -void __cpuinit platform_secondary_init (unsigned int cpu) +static void __cpuinit msm_secondary_init (unsigned int cpu) {/* Configure edge-triggered PPIs */ writel (GIC_PPI_EDGE_MASK ,MSM_QGIC_DIST_BASE +GIC_DIST_CONFIG +4 );
@@ -93,7 +94,7 @@ static __cpuinit void prepare_cold_cpu(unsigned int cpu) "address\n"); } -int __cpuinit boot_secondary (unsigned int cpu,struct task_struct *idle) +static int __cpuinit msm_boot_secondary (unsigned int cpu,struct task_struct *idle) {unsigned long timeout;static int cold_boot_done;
@@ -153,7 +154,7 @@ int __cpuinit boot_secondary(unsigned int cpu, struct task_struct *idle)* does not support the ARM SCU, so just set the possible cpu mask to * NR_CPUS. */ -void __init smp_init_cpus (void ) +static void __init msm_smp_init_cpus (void ) {unsigned int i, ncores =get_core_count ();
@@ -169,6 +170,16 @@ void __init smp_init_cpus(void)set_smp_cross_call (gic_raise_softirq); } -void __init platform_smp_prepare_cpus (unsigned int max_cpus) +static void __init msm_smp_prepare_cpus (unsigned int max_cpus) { } + +struct smp_operations msm_smp_ops__initdata = { + .smp_init_cpus = msm_smp_init_cpus, + .smp_prepare_cpus = msm_smp_prepare_cpus, + .smp_secondary_init = msm_secondary_init, + .smp_boot_secondary = msm_boot_secondary, +#ifdef CONFIG_HOTPLUG_CPU + .cpu_die = msm_cpu_die, +#endif +};
Signature · 1 line
1.7.10
Re: [PATCH v9 06/13] ARM: SoC: convert MSM SMP to SoC descriptor
Quoted 11 lines · Arnd Bergmann
From: Marc Zyngier <[email protected]>
Convert MSM SMP platforms to use the SoC descriptor to provide their SMP and CPU hotplug operations.
Cc David Brown <[email protected]>Signed-off-by Marc Zyngier <[email protected]>Signed-off-by Arnd Bergmann <[email protected]>--- arch/arm/mach-msm/board-msm8960.c | 3 +++ arch/arm/mach-msm/board-msm8x60.c | 7 +++++++
Stephen Boyd recently sent out a patch series that remove the non-DT support for these two targets, which naturally generates a bunch of conflicts.
I'm about to send out a pull request including these changes, and after that, I'll rework this patch for the new board files, and give it a try.
David Brown
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Re: [PATCH v9 06/13] ARM: SoC: convert MSM SMP to SoC descriptor
Quoted 12 lines · David Brown
Quoted 11 lines · Arnd Bergmann
From: Marc Zyngier <[email protected]>
Convert MSM SMP platforms to use the SoC descriptor to provide their SMP and CPU hotplug operations.
Cc David Brown <[email protected]>Signed-off-by Marc Zyngier <[email protected]>Signed-off-by Arnd Bergmann <[email protected]>--- arch/arm/mach-msm/board-msm8960.c | 3 +++ arch/arm/mach-msm/board-msm8x60.c | 7 +++++++
Quoted 7 lines
Stephen Boyd recently sent out a patch series that remove the non-DT support for these two targets, which naturally generates a bunch of conflicts.
I'm about to send out a pull request including these changes, and after that, I'll rework this patch for the new board files, and give it a try.
It would also be nice if you used the common.h file instead of adding a core.h. common.h is a new file in the patch series you mention.
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
PATCH 1/2 ARM: SoC: convert MSM SMP to SoC descriptor
In reply to Arnd BergmannFrom: Marc Zyngier <[email protected]>
Convert MSM SMP platforms to use the SoC descriptor to provide their SMP and CPU hotplug operations.
---
This is an adaptation of this change on top of the msm-for-3.7 tree I recently sent out a pull request for. The only real change is to resolve the conflicts with the simplified board files.
arch/arm/mach-msm/board-dt-8660.c | 2 ++ arch/arm/mach-msm/board-dt-8960.c | 2 ++ arch/arm/mach-msm/core.h | 2 ++ arch/arm/mach-msm/hotplug.c | 18 +++--------------- arch/arm/mach-msm/platsmp.c | 19 +++++++++++++++---- 5 files changed, 24 insertions(+), 19 deletions(-) create mode 100644 arch/arm/mach-msm/core.h
arch/arm/mach-msm/board-dt-8660.c +2 -0
@@ -20,6 +20,7 @@#include <mach/board.h> #include "common.h" +#include "core.h" static const struct of_device_id msm_dt_gic_match[]__initconst = { { .compatible ="qcom,msm-8660-qgic" , .data = gic_of_init },
@@ -53,6 +54,7 @@ static const char *msm8x60_fluid_match[] __initdata = { };DT_MACHINE_START (MSM_DT ,"Qualcomm MSM (Flattened Device Tree)" ) + .smp = smp_ops(msm_smp_ops), .map_io = msm_map_msm8x60_io, .init_irq = msm8x60_init_irq, .handle_irq = gic_handle_irq,
arch/arm/mach-msm/board-dt-8960.c +2 -0
@@ -18,6 +18,7 @@#include <asm/mach/arch.h> #include "common.h" +#include "core.h" static const struct of_device_id msm_dt_gic_match[]__initconst = { { .compatible ="qcom,msm-qgic2" , .data = gic_of_init },
@@ -40,6 +41,7 @@ static const char * const msm8960_dt_match[] __initconst = { };DT_MACHINE_START (MSM8960_DT ,"Qualcomm MSM (Flattened Device Tree)" ) + .smp = smp_ops(msm_smp_ops), .map_io = msm_map_msm8960_io, .init_irq = msm_dt_init_irq, .timer = &msm_dt_timer,
arch/arm/mach-msm/core.h new file +2 -0
@@ -0,0 +1,2 @@ +extern struct smp_operations msm_smp_ops; +extern void msm_cpu_die (unsigned int cpu);
arch/arm/mach-msm/hotplug.c +3 -15
@@ -13,6 +13,8 @@#include <asm/cacheflush.h> #include <asm/smp_plat.h> +#include "core.h" +extern volatile int pen_release;static inline void cpu_enter_lowpower (void )
@@ -57,17 +59,12 @@ static inline void platform_do_lowpower(unsigned int cpu) } } -int platform_cpu_kill (unsigned int cpu) -{ -return 1 ; -} -/* * platform-specific code to shutdown a CPU * * Called with IRQs disabled */ -void platform_cpu_die (unsigned int cpu) +void msm_cpu_die (unsigned int cpu) {/* * we're ready for shutdown now, so do it
@@ -81,12 +78,3 @@ void platform_cpu_die(unsigned int cpu)*/ cpu_leave_lowpower (); } - -int platform_cpu_disable (unsigned int cpu) -{ -/* -* we don't allow CPU 0 to be shutdown (it is still too special -* e.g. clock tick interrupts) -*/ -return cpu ==0 ? -EPERM :0 ; -}
arch/arm/mach-msm/platsmp.c +15 -4
@@ -23,6 +23,7 @@#include <asm/smp_plat.h> #include "scm-boot.h" +#include "core.h" #define VDD_SC1_ARRAY_CLAMP_GFS_CTL 0x15A0#define SCSS_CPU1CORE_RESET 0xD80
@@ -43,7 +44,7 @@ static inline int get_core_count(void)return ((read_cpuid_id () >>4 ) &3 ) +1 ; } -void __cpuinit platform_secondary_init (unsigned int cpu) +static void __cpuinit msm_secondary_init (unsigned int cpu) {/* * if any interrupts are already enabled for the primary
@@ -85,7 +86,7 @@ static __cpuinit void prepare_cold_cpu(unsigned int cpu) "address\n"); } -int __cpuinit boot_secondary (unsigned int cpu,struct task_struct *idle) +static int __cpuinit msm_boot_secondary (unsigned int cpu,struct task_struct *idle) {unsigned long timeout;static int cold_boot_done;
@@ -145,7 +146,7 @@ int __cpuinit boot_secondary(unsigned int cpu, struct task_struct *idle)* does not support the ARM SCU, so just set the possible cpu mask to * NR_CPUS. */ -void __init smp_init_cpus (void ) +static void __init msm_smp_init_cpus (void ) {unsigned int i, ncores =get_core_count ();
@@ -161,6 +162,16 @@ void __init smp_init_cpus(void)set_smp_cross_call (gic_raise_softirq); } -void __init platform_smp_prepare_cpus (unsigned int max_cpus) +static void __init msm_smp_prepare_cpus (unsigned int max_cpus) { } + +struct smp_operations msm_smp_ops__initdata = { + .smp_init_cpus = msm_smp_init_cpus, + .smp_prepare_cpus = msm_smp_prepare_cpus, + .smp_secondary_init = msm_secondary_init, + .smp_boot_secondary = msm_boot_secondary, +#ifdef CONFIG_HOTPLUG_CPU + .cpu_die = msm_cpu_die, +#endif +};
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH 2/2 ARM: msm: Move core.h contents into common.h
No real need to have a separate core.h from the common.h file. Fold these two prototypes into the common header file.
---
This is Stephen Boyd's suggestion to not have a separate core.h. It is probably best to just fold this into the previous patch.
arch/arm/mach-msm/board-dt-8660.c | 1 - arch/arm/mach-msm/board-dt-8960.c | 1 - arch/arm/mach-msm/common.h | 2 ++ arch/arm/mach-msm/core.h | 2 -- arch/arm/mach-msm/hotplug.c | 2 +- arch/arm/mach-msm/platsmp.c | 2 +- 6 files changed, 4 insertions(+), 6 deletions(-) delete mode 100644 arch/arm/mach-msm/core.h
arch/arm/mach-msm/board-dt-8660.c +0 -1
@@ -20,7 +20,6 @@#include <mach/board.h> #include "common.h" -#include "core.h" static const struct of_device_id msm_dt_gic_match[]__initconst = { { .compatible ="qcom,msm-8660-qgic" , .data = gic_of_init },
arch/arm/mach-msm/board-dt-8960.c +0 -1
@@ -18,7 +18,6 @@#include <asm/mach/arch.h> #include "common.h" -#include "core.h" static const struct of_device_id msm_dt_gic_match[]__initconst = { { .compatible ="qcom,msm-qgic2" , .data = gic_of_init },
arch/arm/mach-msm/common.h +2 -0
@@ -26,5 +26,7 @@ extern void msm_map_qsd8x50_io(void);extern void __iomem *__msm_ioremap_caller (unsigned long phys_addr,size_t size,unsigned int mtype,void *caller); +extern struct smp_operations msm_smp_ops; +extern void msm_cpu_die (unsigned int cpu);#endif
arch/arm/mach-msm/core.h deleted +0 -2
@@ -1,2 +0,0 @@ -extern struct smp_operations msm_smp_ops; -extern void msm_cpu_die (unsigned int cpu);
arch/arm/mach-msm/hotplug.c +1 -1
@@ -13,7 +13,7 @@#include <asm/cacheflush.h> #include <asm/smp_plat.h> -#include "core.h" +#include "common.h" extern volatile int pen_release;
arch/arm/mach-msm/platsmp.c +1 -1
@@ -23,7 +23,7 @@#include <asm/smp_plat.h> #include "scm-boot.h" -#include "core.h" +#include "common.h" #define VDD_SC1_ARRAY_CLAMP_GFS_CTL 0x15A0#define SCSS_CPU1CORE_RESET 0xD80
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Re: [PATCH 1/2] ARM: SoC: convert MSM SMP to SoC descriptor
In reply to David BrownQuoted 6 lines · David Brown
From: Marc Zyngier <[email protected]>
Convert MSM SMP platforms to use the SoC descriptor to provide their SMP and CPU hotplug operations.
Quoted 7 lines
Cc David Brown <[email protected]>Signed-off-by Marc Zyngier <[email protected]>Signed-off-by Arnd Bergmann <[email protected]>---
This is an adaptation of this change on top of the msm-for-3.7 tree I recently sent out a pull request for. The only real change is to resolve the conflicts with the simplified board files.
Not sure what I'm supposed to do with this patch, it doesn't apply unless I rebase all of the SMP patches on top of your msm-for-3.7 branch, which would be rather odd.
I'll make sure the branches merge fine and then apply your patch 2/2 on top of the merge, ok?
Arnd
Re: [PATCH 1/2] ARM: SoC: convert MSM SMP to SoC descriptor
Quoted 15 lines · Arnd Bergmann
Quoted 6 lines · David Brown
From: Marc Zyngier <[email protected]>
Convert MSM SMP platforms to use the SoC descriptor to provide their SMP and CPU hotplug operations.
Quoted 7 lines
Cc David Brown <[email protected]>Signed-off-by Marc Zyngier <[email protected]>Signed-off-by Arnd Bergmann <[email protected]>---
This is an adaptation of this change on top of the msm-for-3.7 tree I recently sent out a pull request for. The only real change is to resolve the conflicts with the simplified board files.
Quoted 6 lines
Not sure what I'm supposed to do with this patch, it doesn't apply unless I rebase all of the SMP patches on top of your msm-for-3.7 branch, which would be rather odd.
I'll make sure the branches merge fine and then apply your patch 2/2 on top of the merge, ok?
Yeah, it shouldn't hurt anything to just wait until both get merged in. The patch was mostly a heads up that your series was going to conflict with msm changes coming in.
Olof wanted me to try and split the msm-for-3.7 into a few branches, so I'm going to work on that this morning. I'm not quite sure how well it will work, since, for example, most of the cleanups are preparing the tree for the devicetree changes.
David
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Re: [PATCH 1/2] ARM: SoC: convert MSM SMP to SoC descriptor
Quoted 4 lines · David Brown
Olof wanted me to try and split the msm-for-3.7 into a few branches, so I'm going to work on that this morning. I'm not quite sure how well it will work, since, for example, most of the cleanups are preparing the tree for the devicetree changes.
That is the common scenario. What you should do there is to have one cleanup branch that collects all the cleanups from the other branches, and then base each of the other branches on top of that.
Arnd
PATCH v9 7/13 ARM: SoC: convert ux500 to SoC descriptor
In reply to Arnd BergmannFrom: Marc Zyngier <[email protected]>
Convert ux500 platforms to use the SoC descriptor to provide their SMP and CPU hotplug operations.
--- arch/arm/mach-ux500/board-mop500.c | 4 ++++ arch/arm/mach-ux500/hotplug.c | 36 ++++++++---------------------- arch/arm/mach-ux500/include/mach/setup.h | 3 +++ arch/arm/mach-ux500/platsmp.c | 18 +++++++++++---- 4 files changed, 30 insertions(+), 31 deletions(-)
arch/arm/mach-ux500/board-mop500.c +4 -0
@@ -694,6 +694,7 @@ static void __init hrefv60_init_machine(void)MACHINE_START (U8500 ,"ST-Ericsson MOP500 platform" )/* Maintainer: Srinidhi Kasagar <[email protected]> */ .atag_offset = 0x100, + .smp = smp_ops(ux500_smp_ops), .map_io = u8500_map_io, .init_irq = ux500_init_irq,/* we re-use nomadik timer here */
@@ -705,6 +706,7 @@ MACHINE_ENDMACHINE_START (HREFV60 ,"ST-Ericsson U8500 Platform HREFv60+" ) .atag_offset = 0x100, + .smp = smp_ops(ux500_smp_ops), .map_io = u8500_map_io, .init_irq = ux500_init_irq, .timer = &ux500_timer,
@@ -715,6 +717,7 @@ MACHINE_ENDMACHINE_START (SNOWBALL ,"Calao Systems Snowball platform" ) .atag_offset = 0x100, + .smp = smp_ops(ux500_smp_ops), .map_io = u8500_map_io, .init_irq = ux500_init_irq,/* we re-use nomadik timer here */
@@ -844,6 +847,7 @@ static const char * u8500_dt_board_compat[] = {DT_MACHINE_START (U8500_DT ,"ST-Ericsson U8500 platform (Device Tree Support)" ) + .smp = smp_ops(ux500_smp_ops), .map_io = u8500_map_io, .init_irq = ux500_init_irq,/* we re-use nomadik timer here */
arch/arm/mach-ux500/hotplug.c +9 -27
@@ -15,13 +15,20 @@#include <asm/cacheflush.h> #include <asm/smp_plat.h> +#include <mach/setup.h> +extern volatile int pen_release; -static inline void platform_do_lowpower (unsigned int cpu) +/* +* platform-specific code to shutdown a CPU +* +* Called with IRQs disabled +*/ +void ux500_cpu_die (unsigned int cpu) {flush_cache_all (); -/* we put the platform to just WFI */ +/* directly enter low power state, skipping secure registers */ for (;;) { __asm__ __volatile__("dsb\n\t" "wfi\n\t" : : :"memory" );
@@ -33,28 +40,3 @@ static inline void platform_do_lowpower(unsigned int cpu) } } } - -int platform_cpu_kill (unsigned int cpu) -{ -return 1 ; -} - -/* -* platform-specific code to shutdown a CPU -* -* Called with IRQs disabled -*/ -void platform_cpu_die (unsigned int cpu) -{ -/* directly enter low power state, skipping secure registers */ -platform_do_lowpower (cpu); -} - -int platform_cpu_disable (unsigned int cpu) -{ -/* -* we don't allow CPU 0 to be shutdown (it is still too special -* e.g. clock tick interrupts) -*/ -return cpu ==0 ? -EPERM :0 ; -}
arch/arm/mach-ux500/include/mach/setup.h +3 -0
@@ -45,4 +45,7 @@ extern struct sys_timer ux500_timer; .type = MT_MEMORY, \ } +extern struct smp_operations ux500_smp_ops; +extern void ux500_cpu_die (unsigned int cpu); +#endif /* __ASM_ARCH_SETUP_H */
arch/arm/mach-ux500/platsmp.c +14 -4
@@ -58,7 +58,7 @@ static void __iomem *scu_base_addr(void)static DEFINE_SPINLOCK (boot_lock); -void __cpuinit platform_secondary_init (unsigned int cpu) +static void __cpuinit ux500_secondary_init (unsigned int cpu) {/* * if any interrupts are already enabled for the primary
@@ -80,7 +80,7 @@ void __cpuinit platform_secondary_init(unsigned int cpu)spin_unlock (&boot_lock); } -int __cpuinit boot_secondary (unsigned int cpu,struct task_struct *idle) +static int __cpuinit ux500_boot_secondary (unsigned int cpu,struct task_struct *idle) {unsigned long timeout;
@@ -145,7 +145,7 @@ static void __init wakeup_secondary(void)* Initialise the CPU possible map early - this describes the CPUs * which may be present or become present in the system. */ -void __init smp_init_cpus (void ) +static void __init ux500_smp_init_cpus (void ) {void __iomem *scu_base =scu_base_addr ();unsigned int i, ncores;
@@ -165,9 +165,19 @@ void __init smp_init_cpus(void)set_smp_cross_call (gic_raise_softirq); } -void __init platform_smp_prepare_cpus (unsigned int max_cpus) +static void __init ux500_smp_prepare_cpus (unsigned int max_cpus) {scu_enable (scu_base_addr ());wakeup_secondary (); } + +struct smp_operations ux500_smp_ops__initdata = { + .smp_init_cpus = ux500_smp_init_cpus, + .smp_prepare_cpus = ux500_smp_prepare_cpus, + .smp_secondary_init = ux500_secondary_init, + .smp_boot_secondary = ux500_boot_secondary, +#ifdef CONFIG_HOTPLUG_CPU + .cpu_die = ux500_cpu_die, +#endif +};
Signature · 1 line
1.7.10
A message that is not in the archive (sent off-list or not yet received): CAE2-_9o5gEpEddGLvRRA=pe=vroTnBXmGmoBO1Ojos-hOJXQAQ@mail.gmail.com
Srinidhi Kasagar
Acked-byRe: Fwd: [PATCH v9 07/13] ARM: SoC: convert ux500 to SoC descriptor
[...]
arch/arm/mach-ux500/board-mop500.c MACHINE_END
Quoted 29 lines
From: Marc Zyngier <[email protected]>
Convert ux500 platforms to use the SoC descriptor to provide their SMP and CPU hotplug operations.
Cc Linus Walleij <[email protected]>Signed-off-by Marc Zyngier <[email protected]>Signed-off-by Arnd Bergmann <[email protected]>--- arch/arm/mach-ux500/board-mop500.c | 4 ++++ arch/arm/mach-ux500/hotplug.c | 36 ++++++++---------------------- arch/arm/mach-ux500/include/mach/setup.h | 3 +++ arch/arm/mach-ux500/platsmp.c | 18 +++++++++++---- 4 files changed, 30 insertions(+), 31 deletions(-)arch/arm/mach-ux500/board-mop500.c +1
-0@@ -694,6 +694,7 @@ static void __init hrefv60_init_machine(void)MACHINE_START (U8500 ,"ST-Ericsson MOP500 platform" )/* Maintainer: Srinidhi Kasagar <[email protected]> */ .atag_offset = 0x100, + .smp = smp_ops(ux500_smp_ops), .map_io = u8500_map_io, .init_irq = ux500_init_irq,/* we re-use nomadik timer here */ @@ -705,6 +706,7 @@ MACHINE_END
This looks like mips way doing smp operations.
I have not tested the patch series, will do later.
/srinidhi
PATCH v9 8/13 ARM: SoC: convert shmobile SMP to SoC descriptor
In reply to Arnd BergmannFrom: Marc Zyngier <[email protected]>
Convert shmobile SMP platforms to use the SoC descriptor to provide their SMP and CPU hotplug operations.
--- arch/arm/mach-shmobile/board-ag5evm.c | 1 + arch/arm/mach-shmobile/board-kota2.c | 1 + arch/arm/mach-shmobile/board-kzm9d.c | 1 + arch/arm/mach-shmobile/board-kzm9g.c | 1 + arch/arm/mach-shmobile/board-marzen.c | 1 + arch/arm/mach-shmobile/hotplug.c | 31 +++----- arch/arm/mach-shmobile/include/mach/common.h | 24 +++---- arch/arm/mach-shmobile/include/mach/emev2.h | 7 +- arch/arm/mach-shmobile/include/mach/r8a7779.h | 2 + arch/arm/mach-shmobile/include/mach/sh73a0.h | 2 + arch/arm/mach-shmobile/platsmp.c | 96 +------------------------ arch/arm/mach-shmobile/setup-emev2.c | 1 + arch/arm/mach-shmobile/smp-emev2.c | 47 ++++++++++-- arch/arm/mach-shmobile/smp-r8a7779.c | 48 +++++++++++-- arch/arm/mach-shmobile/smp-sh73a0.c | 48 +++++++++++-- 15 files changed, 165 insertions(+), 146 deletions(-)
arch/arm/mach-shmobile/board-ag5evm.c +1 -0
@@ -650,6 +650,7 @@ static void __init ag5evm_init(void) }MACHINE_START (AG5EVM ,"ag5evm" ) + .smp = smp_ops(sh73a0_smp_ops), .map_io = sh73a0_map_io, .init_early = sh73a0_add_early_devices, .nr_irqs = NR_IRQS_LEGACY,
arch/arm/mach-shmobile/board-kota2.c +1 -0
@@ -545,6 +545,7 @@ static void __init kota2_init(void) }MACHINE_START (KOTA2 ,"kota2" ) + .smp = smp_ops(sh73a0_smp_ops), .map_io = sh73a0_map_io, .init_early = sh73a0_add_early_devices, .nr_irqs = NR_IRQS_LEGACY,
arch/arm/mach-shmobile/board-kzm9d.c +1 -0
@@ -84,6 +84,7 @@ static const char *kzm9d_boards_compat_dt[] __initdata = { };DT_MACHINE_START (KZM9D_DT ,"kzm9d" ) + .smp = smp_ops(emev2_smp_ops), .map_io = emev2_map_io, .init_early = emev2_add_early_devices, .nr_irqs = NR_IRQS_LEGACY,
arch/arm/mach-shmobile/board-kzm9g.c +1 -0
@@ -769,6 +769,7 @@ static const char *kzm9g_boards_compat_dt[] __initdata = { };DT_MACHINE_START (KZM9G_DT ,"kzm9g" ) + .smp = smp_ops(sh73a0_smp_ops), .map_io = sh73a0_map_io, .init_early = sh73a0_add_early_devices, .nr_irqs = NR_IRQS_LEGACY,
arch/arm/mach-shmobile/board-marzen.c +1 -0
@@ -102,6 +102,7 @@ static void __init marzen_init(void) }MACHINE_START (MARZEN ,"marzen" ) + .smp = smp_ops(r8a7779_smp_ops), .map_io = r8a7779_map_io, .init_early = r8a7779_add_early_devices, .nr_irqs = NR_IRQS_LEGACY,
arch/arm/mach-shmobile/hotplug.c +11 -20
@@ -14,30 +14,16 @@#include <linux/smp.h> #include <linux/cpumask.h> #include <linux/delay.h> +#include <linux/of.h> #include <mach/common.h> +#include <mach/r8a7779.h> +#include <mach/emev2.h> #include <asm/cacheflush.h> +#include <asm/mach-types.h> static cpumask_t dead_cpus; -int platform_cpu_kill (unsigned int cpu) -{ -int k; - -/* this function is running on another CPU than the offline target, -* here we need wait for shutdown code in platform_cpu_die() to -* finish before asking SoC-specific code to power off the CPU core. -*/ -for (k =0 ; k <1000 ; k++) { -if (cpumask_test_cpu (cpu, &dead_cpus)) -return shmobile_platform_cpu_kill (cpu); - -mdelay (1 ); - } - -return 0 ; -} - -void platform_cpu_die (unsigned int cpu) +void shmobile_cpu_die (unsigned int cpu) {/* hardware shutdown code running on the CPU that is being offlined */ flush_cache_all ();
@@ -60,7 +46,7 @@ void platform_cpu_die(unsigned int cpu) } } -int platform_cpu_disable (unsigned int cpu) +int shmobile_cpu_disable (unsigned int cpu) {cpumask_clear_cpu (cpu, &dead_cpus);/*
@@ -69,3 +55,8 @@ int platform_cpu_disable(unsigned int cpu)*/ return cpu ==0 ? -EPERM :0 ; } + +int shmobile_cpu_is_dead (unsigned int cpu) +{ +return cpumask_test_cpu (cpu, &dead_cpus); +}
arch/arm/mach-shmobile/include/mach/common.h +12 -12
@@ -4,11 +4,10 @@extern void shmobile_earlytimer_init (void );extern struct sys_timer shmobile_timer;extern void shmobile_setup_delay (unsigned int max_cpu_core_mhz, -unsigned int mult,unsigned int div); +unsigned int mult,unsigned int div);struct twd_local_timer ;extern void shmobile_setup_console (void );extern void shmobile_secondary_vector (void ); -extern int shmobile_platform_cpu_kill (unsigned int cpu);struct clk ;extern int shmobile_clk_init (void );extern void shmobile_handle_irq_intc (struct pt_regs *);
@@ -58,11 +57,6 @@ extern struct clk sh73a0_extal2_clk;extern struct clk sh73a0_extcki_clk;extern struct clk sh73a0_extalr_clk; -extern unsigned int sh73a0_get_core_count (void ); -extern void sh73a0_secondary_init (unsigned int cpu); -extern int sh73a0_boot_secondary (unsigned int cpu); -extern void sh73a0_smp_prepare_cpus (void ); -extern void r8a7740_init_irq (void );extern void r8a7740_map_io (void );extern void r8a7740_add_early_devices (void );
@@ -79,11 +73,6 @@ extern void r8a7779_pinmux_init(void);extern void r8a7779_pm_init (void );extern void r8a7740_meram_workaround (void ); -extern unsigned int r8a7779_get_core_count (void ); -extern int r8a7779_platform_cpu_kill (unsigned int cpu); -extern void r8a7779_secondary_init (unsigned int cpu); -extern int r8a7779_boot_secondary (unsigned int cpu); -extern void r8a7779_smp_prepare_cpus (void );extern void r8a7779_register_twd (void );extern void shmobile_init_late (void );
@@ -100,4 +89,15 @@ int shmobile_cpuidle_init(void);static inline int shmobile_cpuidle_init (void ) {return 0 ; }#endif +extern void shmobile_cpu_die (unsigned int cpu); +extern int shmobile_cpu_disable (unsigned int cpu); + +#ifdef CONFIG_HOTPLUG_CPU +extern int shmobile_cpu_is_dead (unsigned int cpu); +#else +static inline int shmobile_cpu_is_dead (unsigned int cpu) {return 1 ; } +#endif + +extern void shmobile_smp_init_cpus (unsigned int ncores); +#endif /* __ARCH_MACH_COMMON_H */
arch/arm/mach-shmobile/include/mach/emev2.h +2 -5
@@ -7,13 +7,10 @@ extern void emev2_add_early_devices(void);extern void emev2_add_standard_devices (void );extern void emev2_clock_init (void );extern void emev2_set_boot_vector (unsigned long value); -extern unsigned int emev2_get_core_count (void ); -extern int emev2_platform_cpu_kill (unsigned int cpu); -extern void emev2_secondary_init (unsigned int cpu); -extern int emev2_boot_secondary (unsigned int cpu); -extern void emev2_smp_prepare_cpus (void );#define EMEV2_GPIO_BASE 200#define EMEV2_GPIO_IRQ (n) (EMEV2_GPIO_BASE + (n)) +extern struct smp_operations emev2_smp_ops; +#endif /* __ASM_EMEV2_H__ */
arch/arm/mach-shmobile/include/mach/r8a7779.h +2 -0
@@ -360,4 +360,6 @@ extern void r8a7779_add_device_to_domain(struct r8a7779_pm_domain *r8a7779_pd,#define r8a7779_add_device_to_domain (pd, pdev) do { } while (0)#endif /* CONFIG_PM */ +extern struct smp_operations r8a7779_smp_ops; +#endif /* __ASM_R8A7779_H__ */
arch/arm/mach-shmobile/include/mach/sh73a0.h +2 -0
@@ -557,4 +557,6 @@ enum {#define SH73A0_PINT0_IRQ (irq) ((irq) + 700)#define SH73A0_PINT1_IRQ (irq) ((irq) + 732) +extern struct smp_operations sh73a0_smp_ops; +#endif /* __ASM_SH73A0_H__ */
arch/arm/mach-shmobile/platsmp.c +1 -95
109 lines not on this page · raw message
arch/arm/mach-shmobile/setup-emev2.c +1 -0
@@ -440,6 +440,7 @@ void __init emev2_init_irq_dt(void) }DT_MACHINE_START (EMEV2_DT ,"Generic Emma Mobile EV2 (Flattened Device Tree)" ) + .smp = smp_ops(emev2_smp_ops), .init_early = emev2_init_delay, .nr_irqs = NR_IRQS_LEGACY, .init_irq = emev2_init_irq_dt,
arch/arm/mach-shmobile/smp-emev2.c +42 -5
76 lines not on this page · raw message
arch/arm/mach-shmobile/smp-r8a7779.c +43 -5
79 lines not on this page · raw message
arch/arm/mach-shmobile/smp-sh73a0.c +44 -4
81 lines not on this page · raw message
Signature · 1 line
1.7.10
PATCH v9 9/13 ARM: SoC: convert highbank to SoC descriptor
In reply to Arnd BergmannFrom: Marc Zyngier <[email protected]>
Convert the highbank platform to use the SoC descriptor to provide its SMP and CPU hotplug operations.
--- arch/arm/mach-highbank/core.h | 3 +++ arch/arm/mach-highbank/highbank.c | 1 + arch/arm/mach-highbank/hotplug.c | 16 +--------------- arch/arm/mach-highbank/platsmp.c | 18 ++++++++++++++---- 4 files changed, 19 insertions(+), 19 deletions(-)
arch/arm/mach-highbank/core.h +3 -0
@@ -9,3 +9,6 @@ static inline void highbank_lluart_map_io(void) {}#endif extern void highbank_smc1 (int fn,int arg); +extern void highbank_cpu_die (unsigned int cpu); + +extern struct smp_operations highbank_smp_ops;
arch/arm/mach-highbank/highbank.c +1 -0
@@ -162,6 +162,7 @@ static const char *highbank_match[] __initconst = { };DT_MACHINE_START (HIGHBANK ,"Highbank" ) + .smp = smp_ops(highbank_smp_ops), .map_io = highbank_map_io, .init_irq = highbank_init_irq, .timer = &highbank_timer,
arch/arm/mach-highbank/hotplug.c +1 -15
@@ -24,16 +24,11 @@extern void secondary_startup (void ); -int platform_cpu_kill (unsigned int cpu) -{ -return 1 ; -} -/* * platform-specific code to shutdown a CPU * */ -void platform_cpu_die (unsigned int cpu) +void highbank_cpu_die (unsigned int cpu) {flush_cache_all ();
@@ -45,12 +40,3 @@ void platform_cpu_die(unsigned int cpu)/* We should never return from idle */ panic ("highbank: cpu %d unexpectedly exit from shutdown\n" , cpu); } - -int platform_cpu_disable (unsigned int cpu) -{ -/* -* CPU0 should not be shut down via hotplug. cpu_idle can WFI -* or a proper shutdown or hibernate should be used. -*/ -return cpu ==0 ? -EPERM :0 ; -}
arch/arm/mach-highbank/platsmp.c +14 -4
@@ -25,12 +25,12 @@extern void secondary_startup (void ); -void __cpuinit platform_secondary_init (unsigned int cpu) +static void __cpuinit highbank_secondary_init (unsigned int cpu) {gic_secondary_init (0 ); } -int __cpuinit boot_secondary (unsigned int cpu,struct task_struct *idle) +static int __cpuinit highbank_boot_secondary (unsigned int cpu,struct task_struct *idle) {gic_raise_softirq (cpumask_of (cpu),0 );return 0 ;
@@ -40,7 +40,7 @@ int __cpuinit boot_secondary(unsigned int cpu, struct task_struct *idle)* Initialise the CPU possible map early - this describes the CPUs * which may be present or become present in the system. */ -void __init smp_init_cpus (void ) +static void __init highbank_smp_init_cpus (void ) {unsigned int i, ncores;
@@ -61,7 +61,7 @@ void __init smp_init_cpus(void)set_smp_cross_call (gic_raise_softirq); } -void __init platform_smp_prepare_cpus (unsigned int max_cpus) +static void __init highbank_smp_prepare_cpus (unsigned int max_cpus) {int i;
@@ -76,3 +76,13 @@ void __init platform_smp_prepare_cpus(unsigned int max_cpus)for (i =1 ; i < max_cpus; i++)highbank_set_cpu_jump (i, secondary_startup); } + +struct smp_operations highbank_smp_ops__initdata = { + .smp_init_cpus = highbank_smp_init_cpus, + .smp_prepare_cpus = highbank_smp_prepare_cpus, + .smp_secondary_init = highbank_secondary_init, + .smp_boot_secondary = highbank_boot_secondary, +#ifdef CONFIG_HOTPLUG_CPU + .cpu_die = highbank_cpu_die, +#endif +};
Signature · 1 line
1.7.10
Re: [PATCH v9 09/13] ARM: SoC: convert highbank to SoC descriptor
Quoted 9 lines · Arnd Bergmann
From: Marc Zyngier <[email protected]>
Convert the highbank platform to use the SoC descriptor to provide its SMP and CPU hotplug operations.
Cc Rob Herring <[email protected]>Signed-off-by Marc Zyngier <[email protected]>Signed-off-by Arnd Bergmann <[email protected]>---
Thanks for picking this up.
Rob
Quoted 116 lines
arch/arm/mach-highbank/core.h | 3 +++ arch/arm/mach-highbank/highbank.c | 1 + arch/arm/mach-highbank/hotplug.c | 16 +--------------- arch/arm/mach-highbank/platsmp.c | 18 ++++++++++++++---- 4 files changed, 19 insertions(+), 19 deletions(-)arch/arm/mach-highbank/core.h +3
-0@@ -9,3 +9,6 @@ static inline void highbank_lluart_map_io(void) {}#endif extern void highbank_smc1 (int fn,int arg); +extern void highbank_cpu_die (unsigned int cpu); + +extern struct smp_operations highbank_smp_ops;arch/arm/mach-highbank/highbank.c +1
-0@@ -162,6 +162,7 @@ static const char *highbank_match[] __initconst = { };DT_MACHINE_START (HIGHBANK ,"Highbank" ) + .smp = smp_ops(highbank_smp_ops), .map_io = highbank_map_io, .init_irq = highbank_init_irq, .timer = &highbank_timer,arch/arm/mach-highbank/hotplug.c +1
-15@@ -24,16 +24,11 @@extern void secondary_startup (void ); -int platform_cpu_kill (unsigned int cpu) -{ -return 1 ; -} -/* * platform-specific code to shutdown a CPU * */ -void platform_cpu_die (unsigned int cpu) +void highbank_cpu_die (unsigned int cpu) {flush_cache_all ();@@ -45,12 +40,3 @@ void platform_cpu_die(unsigned int cpu)/* We should never return from idle */ panic ("highbank: cpu %d unexpectedly exit from shutdown\n" , cpu); } - -int platform_cpu_disable (unsigned int cpu) -{ -/* -* CPU0 should not be shut down via hotplug. cpu_idle can WFI -* or a proper shutdown or hibernate should be used. -*/ -return cpu ==0 ? -EPERM :0 ; -}arch/arm/mach-highbank/platsmp.c +14
-4@@ -25,12 +25,12 @@extern void secondary_startup (void ); -void __cpuinit platform_secondary_init (unsigned int cpu) +static void __cpuinit highbank_secondary_init (unsigned int cpu) {gic_secondary_init (0 ); } -int __cpuinit boot_secondary (unsigned int cpu,struct task_struct *idle) +static int __cpuinit highbank_boot_secondary (unsigned int cpu,struct task_struct *idle) {gic_raise_softirq (cpumask_of (cpu),0 );return 0 ;@@ -40,7 +40,7 @@ int __cpuinit boot_secondary(unsigned int cpu, struct task_struct *idle)* Initialise the CPU possible map early - this describes the CPUs * which may be present or become present in the system. */ -void __init smp_init_cpus (void ) +static void __init highbank_smp_init_cpus (void ) {unsigned int i, ncores;@@ -61,7 +61,7 @@ void __init smp_init_cpus(void)set_smp_cross_call (gic_raise_softirq); } -void __init platform_smp_prepare_cpus (unsigned int max_cpus) +static void __init highbank_smp_prepare_cpus (unsigned int max_cpus) {int i;@@ -76,3 +76,13 @@ void __init platform_smp_prepare_cpus(unsigned int max_cpus)for (i =1 ; i < max_cpus; i++)highbank_set_cpu_jump (i, secondary_startup); } + +struct smp_operations highbank_smp_ops__initdata = { + .smp_init_cpus = highbank_smp_init_cpus, + .smp_prepare_cpus = highbank_smp_prepare_cpus, + .smp_secondary_init = highbank_secondary_init, + .smp_boot_secondary = highbank_boot_secondary, +#ifdef CONFIG_HOTPLUG_CPU + .cpu_die = highbank_cpu_die, +#endif +};
PATCH v9 10/13 ARM: SoC: convert imx6q to SoC descriptor
In reply to Arnd BergmannFrom: Marc Zyngier <[email protected]>
Convert the imx6q platform to use the SoC descriptor to provide its SMP and CPU hotplug operations.
--- arch/arm/mach-imx/hotplug.c | 16 +--------------- arch/arm/mach-imx/mach-imx6q.c | 1 + arch/arm/mach-imx/platsmp.c | 18 ++++++++++++++---- arch/arm/plat-mxc/include/mach/common.h | 4 ++++ 4 files changed, 20 insertions(+), 19 deletions(-)
arch/arm/mach-imx/hotplug.c +1 -15
@@ -15,11 +15,6 @@#include <asm/cp15.h> #include <mach/common.h> -int platform_cpu_kill (unsigned int cpu) -{ -return 1 ; -} -static inline void cpu_enter_lowpower (void ) {unsigned int v;
@@ -47,7 +42,7 @@ static inline void cpu_enter_lowpower(void)* * Called with IRQs disabled */ -void platform_cpu_die (unsigned int cpu) +void imx_cpu_die (unsigned int cpu) {cpu_enter_lowpower ();imx_enable_cpu (cpu, false);
@@ -56,12 +51,3 @@ void platform_cpu_die(unsigned int cpu)while (1 ) ; } - -int platform_cpu_disable (unsigned int cpu) -{ -/* -* we don't allow CPU 0 to be shutdown (it is still too special -* e.g. clock tick interrupts) -*/ -return cpu ==0 ? -EPERM :0 ; -}
arch/arm/mach-imx/mach-imx6q.c +1 -0
@@ -226,6 +226,7 @@ static const char *imx6q_dt_compat[] __initdata = { };DT_MACHINE_START (IMX6Q ,"Freescale i.MX6 Quad (Device Tree)" ) + .smp = smp_ops(imx6q_soc_desc), .map_io = imx6q_map_io, .init_irq = imx6q_init_irq, .handle_irq = imx6q_handle_irq,
arch/arm/mach-imx/platsmp.c +14 -4
@@ -41,7 +41,7 @@ void __init imx_scu_map_io(void) scu_base =IMX_IO_ADDRESS (base); } -void __cpuinit platform_secondary_init (unsigned int cpu) +static void __cpuinit imx_secondary_init (unsigned int cpu) {/* * if any interrupts are already enabled for the primary
@@ -51,7 +51,7 @@ void __cpuinit platform_secondary_init(unsigned int cpu)gic_secondary_init (0 ); } -int __cpuinit boot_secondary (unsigned int cpu,struct task_struct *idle) +static int __cpuinit imx_boot_secondary (unsigned int cpu,struct task_struct *idle) {imx_set_cpu_jump (cpu, v7_secondary_startup);imx_enable_cpu (cpu, true);
@@ -62,7 +62,7 @@ int __cpuinit boot_secondary(unsigned int cpu, struct task_struct *idle)* Initialise the CPU possible map early - this describes the CPUs * which may be present or become present in the system. */ -void __init smp_init_cpus (void ) +static void __init imx_smp_init_cpus (void ) {int i, ncores;
@@ -79,7 +79,17 @@ void imx_smp_prepare(void)scu_enable (scu_base); } -void __init platform_smp_prepare_cpus (unsigned int max_cpus) +static void __init imx_smp_prepare_cpus (unsigned int max_cpus) {imx_smp_prepare (); } + +struct smp_operations imx_smp_ops__initdata = { + .smp_init_cpus = imx_smp_init_cpus, + .smp_prepare_cpus = imx_smp_prepare_cpus, + .smp_secondary_init = imx_secondary_init, + .smp_boot_secondary = imx_boot_secondary, +#ifdef CONFIG_HOTPLUG_CPU + .cpu_die = imx_cpu_die, +#endif +};
arch/arm/plat-mxc/include/mach/common.h +4 -0
@@ -145,6 +145,8 @@ extern void imx53_smd_common_init(void);extern int imx6q_set_lpm (enum mxc_cpu_pwr_mode mode);extern void imx6q_clock_map_io (void ); +extern void imx_cpu_die (unsigned int cpu); +#ifdef CONFIG_PM extern void imx6q_pm_init (void );extern void imx51_pm_init (void );
@@ -161,4 +163,6 @@ extern int mx51_neon_fixup(void);static inline int mx51_neon_fixup (void ) {return 0 ; }#endif +extern struct smp_operations imx_smp_ops; +#endif
Signature · 1 line
1.7.10
Re: [PATCH v9 10/13] ARM: SoC: convert imx6q to SoC descriptor
Quoted 58 lines · Arnd Bergmann
From: Marc Zyngier <[email protected]>
Convert the imx6q platform to use the SoC descriptor to provide its SMP and CPU hotplug operations.
Cc Shawn Guo <[email protected]>Signed-off-by Marc Zyngier <[email protected]>Signed-off-by Arnd Bergmann <[email protected]>--- arch/arm/mach-imx/hotplug.c | 16 +--------------- arch/arm/mach-imx/mach-imx6q.c | 1 + arch/arm/mach-imx/platsmp.c | 18 ++++++++++++++---- arch/arm/plat-mxc/include/mach/common.h | 4 ++++ 4 files changed, 20 insertions(+), 19 deletions(-)arch/arm/mach-imx/hotplug.c +1
-15@@ -15,11 +15,6 @@#include <asm/cp15.h> #include <mach/common.h> -int platform_cpu_kill (unsigned int cpu) -{ -return 1 ; -} -static inline void cpu_enter_lowpower (void ) {unsigned int v;@@ -47,7 +42,7 @@ static inline void cpu_enter_lowpower(void)* * Called with IRQs disabled */ -void platform_cpu_die (unsigned int cpu) +void imx_cpu_die (unsigned int cpu) {cpu_enter_lowpower ();imx_enable_cpu (cpu, false);@@ -56,12 +51,3 @@ void platform_cpu_die(unsigned int cpu)while (1 ) ; } - -int platform_cpu_disable (unsigned int cpu) -{ -/* -* we don't allow CPU 0 to be shutdown (it is still too special -* e.g. clock tick interrupts) -*/ -return cpu ==0 ? -EPERM :0 ; -}arch/arm/mach-imx/mach-imx6q.c +0
-0
arch/arm/mach-imx/mach-imx6q.c static const char *imx6q_dt_compat[] __initdata = { · line 229
Quoted 4 lines
arch/arm/mach-imx/mach-imx6q.c +1
-0@@ -226,6 +226,7 @@ static const char *imx6q_dt_compat[] __initdata = { };DT_MACHINE_START (IMX6Q ,"Freescale i.MX6 Quad (Device Tree)" ) + .smp = smp_ops(imx6q_soc_desc),
s/imx6q_soc_desc/imx_smp_ops
Otherwise,
Regards,
Shawn
Quoted 76 lines
arch/arm/mach-imx/mach-imx6q.c +0
-0.map_io = imx6q_map_io, .init_irq = imx6q_init_irq, .handle_irq = imx6q_handle_irq,arch/arm/mach-imx/platsmp.c +14
-4@@ -41,7 +41,7 @@ void __init imx_scu_map_io(void) scu_base =IMX_IO_ADDRESS (base); } -void __cpuinit platform_secondary_init (unsigned int cpu) +static void __cpuinit imx_secondary_init (unsigned int cpu) {/* * if any interrupts are already enabled for the primary @@ -51,7 +51,7 @@ void __cpuinit platform_secondary_init(unsigned int cpu)gic_secondary_init (0 ); } -int __cpuinit boot_secondary (unsigned int cpu,struct task_struct *idle) +static int __cpuinit imx_boot_secondary (unsigned int cpu,struct task_struct *idle) {imx_set_cpu_jump (cpu, v7_secondary_startup);imx_enable_cpu (cpu, true);@@ -62,7 +62,7 @@ int __cpuinit boot_secondary(unsigned int cpu, struct task_struct *idle)* Initialise the CPU possible map early - this describes the CPUs * which may be present or become present in the system. */ -void __init smp_init_cpus (void ) +static void __init imx_smp_init_cpus (void ) {int i, ncores;@@ -79,7 +79,17 @@ void imx_smp_prepare(void)scu_enable (scu_base); } -void __init platform_smp_prepare_cpus (unsigned int max_cpus) +static void __init imx_smp_prepare_cpus (unsigned int max_cpus) {imx_smp_prepare (); } + +struct smp_operations imx_smp_ops__initdata = { + .smp_init_cpus = imx_smp_init_cpus, + .smp_prepare_cpus = imx_smp_prepare_cpus, + .smp_secondary_init = imx_secondary_init, + .smp_boot_secondary = imx_boot_secondary, +#ifdef CONFIG_HOTPLUG_CPU + .cpu_die = imx_cpu_die, +#endif +};arch/arm/plat-mxc/include/mach/common.h +4
-0@@ -145,6 +145,8 @@ extern void imx53_smd_common_init(void);extern int imx6q_set_lpm (enum mxc_cpu_pwr_mode mode);extern void imx6q_clock_map_io (void ); +extern void imx_cpu_die (unsigned int cpu); +#ifdef CONFIG_PM extern void imx6q_pm_init (void );extern void imx51_pm_init (void );@@ -161,4 +163,6 @@ extern int mx51_neon_fixup(void);static inline int mx51_neon_fixup (void ) {return 0 ; }#endif +extern struct smp_operations imx_smp_ops; +#endif Signature · 1 line
1.7.10
Re: [PATCH v9 10/13] ARM: SoC: convert imx6q to SoC descriptor
Quoted 5 lines · Shawn Guo
Quoted 3 lines
DT_MACHINE_START(IMX6Q, "Freescale i.MX6 Quad (Device Tree)")
+ .smp =smp_ops(imx6q_soc_desc),s/imx6q_soc_desc/imx_smp_ops
Yes, just noticed this myself when testing the series together with other patches.
Quoted 3 lines
Otherwise,
Acked-by Shawn Guo <[email protected]>
Thanks,
Arnd
PATCH v9 11/13 ARM: SoC: convert spear13xx to SoC descriptor
In reply to Arnd BergmannConvert the spear13xx platform to use the SoC descriptor to provide its SMP and CPU hotplug operations.
--- arch/arm/mach-spear13xx/hotplug.c | 20 +++----------------- arch/arm/mach-spear13xx/include/mach/generic.h | 3 +++ arch/arm/mach-spear13xx/platsmp.c | 20 +++++++++++++++----- arch/arm/mach-spear13xx/spear1310.c | 1 + arch/arm/mach-spear13xx/spear1340.c | 1 + 5 files changed, 23 insertions(+), 22 deletions(-)
arch/arm/mach-spear13xx/hotplug.c +3 -17
@@ -56,7 +56,7 @@ static inline void cpu_leave_lowpower(void) : "cc"); } -static inline void platform_do_lowpower (unsigned int cpu,int *spurious) +static inline void spear13xx_do_lowpower (unsigned int cpu,int *spurious) {for (;;) {wfi ();
@@ -79,17 +79,12 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious) } } -int platform_cpu_kill (unsigned int cpu) -{ -return 1 ; -} -/* * platform-specific code to shutdown a CPU * * Called with IRQs disabled */ -void __cpuinit platform_cpu_die (unsigned int cpu) +void __cpuinit spear13xx_cpu_die (unsigned int cpu) {int spurious =0 ;
@@ -97,7 +92,7 @@ void __cpuinit platform_cpu_die(unsigned int cpu)* we're ready for shutdown now, so do it */ cpu_enter_lowpower (); -platform_do_lowpower (cpu, &spurious); +spear13xx_do_lowpower (cpu, &spurious);/* * bring this CPU back into the world of cache
@@ -108,12 +103,3 @@ void __cpuinit platform_cpu_die(unsigned int cpu)if (spurious)pr_warn ("CPU%u: %u spurious wakeup calls\n" , cpu, spurious); } - -int platform_cpu_disable (unsigned int cpu) -{ -/* -* we don't allow CPU 0 to be shutdown (it is still too special -* e.g. clock tick interrupts) -*/ -return cpu ==0 ? -EPERM :0 ; -}
arch/arm/mach-spear13xx/include/mach/generic.h +3 -0
@@ -33,6 +33,9 @@ void __init spear13xx_l2x0_init(void);bool dw_dma_filter (struct dma_chan *chan,void *slave);void spear_restart (char ,const char *);void spear13xx_secondary_startup (void ); +void __cpuinit spear13xx_cpu_die (unsigned int cpu); + +extern struct smp_operations spear13xx_smp_ops;#ifdef CONFIG_MACH_SPEAR1310 void __init spear1310_clk_init (void );
arch/arm/mach-spear13xx/platsmp.c +15 -5
@@ -19,6 +19,7 @@#include <asm/hardware/gic.h> #include <asm/smp_scu.h> #include <mach/spear.h> +#include <mach/generic.h> /* * control for which core is the next to come out of the secondary
@@ -28,9 +29,8 @@ volatile int __cpuinitdata pen_release = -1;static DEFINE_SPINLOCK (boot_lock);static void __iomem *scu_base =IOMEM (VA_SCU_BASE ); -extern void spear13xx_secondary_startup (void ); -void __cpuinit platform_secondary_init (unsigned int cpu) +static void __cpuinit spear13xx_secondary_init (unsigned int cpu) {/* * if any interrupts are already enabled for the primary
@@ -53,7 +53,7 @@ void __cpuinit platform_secondary_init(unsigned int cpu)spin_unlock (&boot_lock); } -int __cpuinit boot_secondary (unsigned int cpu,struct task_struct *idle) +static int __cpuinit spear13xx_boot_secondary (unsigned int cpu,struct task_struct *idle) {unsigned long timeout;
@@ -97,7 +97,7 @@ int __cpuinit boot_secondary(unsigned int cpu, struct task_struct *idle)* Initialise the CPU possible map early - this describes the CPUs * which may be present or become present in the system. */ -void __init smp_init_cpus (void ) +static void __init spear13xx_smp_init_cpus (void ) {unsigned int i, ncores =scu_get_core_count (scu_base);
@@ -113,7 +113,7 @@ void __init smp_init_cpus(void)set_smp_cross_call (gic_raise_softirq); } -void __init platform_smp_prepare_cpus (unsigned int max_cpus) +static void __init spear13xx_smp_prepare_cpus (unsigned int max_cpus) {scu_enable (scu_base);
@@ -125,3 +125,13 @@ void __init platform_smp_prepare_cpus(unsigned int max_cpus)*/ __raw_writel (virt_to_phys (spear13xx_secondary_startup),SYS_LOCATION ); } + +struct smp_operations spear13xx_smp_ops__initdata = { + .smp_init_cpus = spear13xx_smp_init_cpus, + .smp_prepare_cpus = spear13xx_smp_prepare_cpus, + .smp_secondary_init = spear13xx_secondary_init, + .smp_boot_secondary = spear13xx_boot_secondary, +#ifdef CONFIG_HOTPLUG_CPU + .cpu_die = spear13xx_cpu_die, +#endif +};
arch/arm/mach-spear13xx/spear1310.c +1 -0
@@ -78,6 +78,7 @@ static void __init spear1310_map_io(void) }DT_MACHINE_START (SPEAR1310_DT ,"ST SPEAr1310 SoC with Flattened Device Tree" ) + .smp = smp_ops(spear13xx_smp_ops), .map_io = spear1310_map_io, .init_irq = spear13xx_dt_init_irq, .handle_irq = gic_handle_irq,
arch/arm/mach-spear13xx/spear1340.c +1 -0
@@ -182,6 +182,7 @@ static const char * const spear1340_dt_board_compat[] = { };DT_MACHINE_START (SPEAR1340_DT ,"ST SPEAr1340 SoC with Flattened Device Tree" ) + .smp = smp_ops(spear13xx_smp_ops), .map_io = spear13xx_map_io, .init_irq = spear13xx_dt_init_irq, .handle_irq = gic_handle_irq,
Signature · 1 line
1.7.10
Re: [PATCH v9 11/13] ARM: SoC: convert spear13xx to SoC descriptor
Quoted 8 lines · Arnd Bergmann
Convert the spear13xx platform to use the SoC descriptor to provide its SMP and CPU hotplug operations.
Cc Viresh Kumar <[email protected]>Cc Shiraz Hashim <[email protected]>Cc spear-devel at list.st.comSigned-off-by Marc Zyngier <[email protected]>Signed-off-by Arnd Bergmann <[email protected]>
PATCH v9 12/13 ARM: smp: Make SoC descriptor mandatory for SMP platforms
In reply to Arnd BergmannFrom: Marc Zyngier <[email protected]>
Now that all SMP platforms have been converted to the SOC descriptor and its SMP operations, remove the "weak" attribute from the hooks in smp.c, and make the functions static wherever possible.
--- arch/arm/include/asm/smp.h | 14 -------------- arch/arm/kernel/smp.c | 18 +++++++++--------- 2 files changed, 9 insertions(+), 23 deletions(-)
arch/arm/include/asm/smp.h +0 -14
@@ -60,15 +60,6 @@ extern int boot_secondary(unsigned int cpu, struct task_struct *);*/ asmlinkage void secondary_start_kernel(void); -/* -* Perform platform specific initialisation of the specified CPU. -*/ -extern void platform_secondary_init (unsigned int cpu); - -/* -* Initialize cpu_possible map, and enable coherency -*/ -extern void platform_smp_prepare_cpus (unsigned int );/* * Initial data for bringing up a secondary CPU.
@@ -81,15 +72,10 @@ struct secondary_data {extern struct secondary_data secondary_data;extern int __cpu_disable (void ); -extern int platform_cpu_disable (unsigned int cpu);extern void __cpu_die (unsigned int cpu);extern void cpu_die (void ); -extern void platform_cpu_die (unsigned int cpu); -extern int platform_cpu_kill (unsigned int cpu); -extern void platform_cpu_enable (unsigned int cpu); -extern void arch_send_call_function_single_ipi (int cpu);extern void arch_send_call_function_ipi_mask (const struct cpumask *mask);
arch/arm/kernel/smp.c +9 -9
@@ -110,25 +110,25 @@ int __cpuinit __cpu_up(unsigned int cpu, struct task_struct *idle) }/* platform specific SMP operations */ -void __attribute__((weak))__init smp_init_cpus (void ) +void __init smp_init_cpus (void ) {if (smp_ops.smp_init_cpus) smp_ops.smp_init_cpus (); } -void __attribute__((weak))__init platform_smp_prepare_cpus (unsigned int max_cpus) +static void __init platform_smp_prepare_cpus (unsigned int max_cpus) {if (smp_ops.smp_prepare_cpus) smp_ops.smp_prepare_cpus (max_cpus); } -void __attribute__((weak))__cpuinit platform_secondary_init (unsigned int cpu) +static void __cpuinit platform_secondary_init (unsigned int cpu) {if (smp_ops.smp_secondary_init) smp_ops.smp_secondary_init (cpu); } -int __attribute__((weak))__cpuinit boot_secondary (unsigned int cpu,struct task_struct *idle) +int __cpuinit boot_secondary (unsigned int cpu,struct task_struct *idle) {if (smp_ops.smp_boot_secondary)return smp_ops.smp_boot_secondary (cpu, idle);
@@ -138,20 +138,20 @@ int __attribute__((weak)) __cpuinit boot_secondary(unsigned int cpu, struct task#ifdef CONFIG_HOTPLUG_CPU static void percpu_timer_stop (void ); -int __attribute__((weak))platform_cpu_kill (unsigned int cpu) +static int platform_cpu_kill (unsigned int cpu) {if (smp_ops.cpu_kill)return smp_ops.cpu_kill (cpu);return 1 ; } -void __attribute__((weak))platform_cpu_die (unsigned int cpu) +static void platform_cpu_die (unsigned int cpu) {if (smp_ops.cpu_die) smp_ops.cpu_die (cpu); } -int __attribute__((weak))platform_cpu_disable (unsigned int cpu) +static int platform_cpu_disable (unsigned int cpu) {if (smp_ops.cpu_disable)return smp_ops.cpu_disable (cpu);
@@ -166,7 +166,7 @@ int __attribute__((weak)) platform_cpu_disable(unsigned int cpu)/* * __cpu_disable runs on the processor to be shutdown. */ -int __cpu_disable (void ) +int __cpuinit __cpu_disable (void ) {unsigned int cpu =smp_processor_id ();int ret;
@@ -209,7 +209,7 @@ static DECLARE_COMPLETION(cpu_died);* called on the thread which is asking for a CPU to be shutdown - * waits until shutdown has completed, or it is timed out. */ -void __cpu_die (unsigned int cpu) +void __cpuinit __cpu_die (unsigned int cpu) {if (!wait_for_completion_timeout (&cpu_died,msecs_to_jiffies (5000 ))) {pr_err ("CPU%u: cpu didn't die\n" , cpu);
Signature · 1 line
1.7.10
PATCH v9 13/13 ARM: consolidate pen_release instead of having per platform definitions
In reply to Arnd BergmannFrom: Marc Zyngier <[email protected]>
Almost each SMP platform defines pen_release to manage booting secondary CPUs. This of course clashes with the single zImage effort.
Add the pen_release definition to the ARM SMP code, and remove all others. This should only be used by platforms which lack any kind of CPU power management...
--- arch/arm/include/asm/smp.h | 1 + arch/arm/kernel/smp.c | 6 ++++++ arch/arm/mach-exynos/hotplug.c | 2 -- arch/arm/mach-exynos/platsmp.c | 7 ------- arch/arm/mach-msm/hotplug.c | 2 -- arch/arm/mach-msm/platsmp.c | 5 ----- arch/arm/mach-realview/hotplug.c | 2 -- arch/arm/mach-spear13xx/hotplug.c | 2 -- arch/arm/mach-spear13xx/platsmp.c | 5 ----- arch/arm/mach-ux500/hotplug.c | 2 -- arch/arm/mach-ux500/platsmp.c | 6 ------ arch/arm/mach-vexpress/hotplug.c | 2 -- arch/arm/plat-versatile/platsmp.c | 6 ------ 13 files changed, 7 insertions(+), 41 deletions(-)
arch/arm/include/asm/smp.h +1 -0
@@ -70,6 +70,7 @@ struct secondary_data {void *stack; };extern struct secondary_data secondary_data; +extern volatile int pen_release;extern int __cpu_disable (void );
arch/arm/kernel/smp.c +6 -0
@@ -51,6 +51,12 @@*/ struct secondary_data secondary_data; +/* +* control for which core is the next to come out of the secondary +* boot "holding pen" +*/ +volatile int __cpuinitdata pen_release =-1 ; +enum ipi_msg_type {IPI_TIMER =2 ,IPI_RESCHEDULE ,
arch/arm/mach-exynos/hotplug.c +0 -2
@@ -23,8 +23,6 @@#include "common.h" -extern volatile int pen_release; -static inline void cpu_enter_lowpower (void ) {unsigned int v;
arch/arm/mach-exynos/platsmp.c +0 -7
@@ -40,13 +40,6 @@ extern void exynos4_secondary_startup(void); S5P_INFORM5 : S5P_VA_SYSRAM)/* -* control for which core is the next to come out of the secondary -* boot "holding pen" -*/ - -volatile int __cpuinitdata pen_release = -1; - -/* * Write pen_release in a way that is guaranteed to be visible to all * observers, irrespective of whether they're taking part in coherency * or not. This is necessary for the hotplug code to work reliably.
arch/arm/mach-msm/hotplug.c +0 -2
@@ -15,8 +15,6 @@#include "core.h" -extern volatile int pen_release; -static inline void cpu_enter_lowpower (void ) {/* Just flush the cache. Changing the coherency is not yet
arch/arm/mach-msm/platsmp.c +0 -5
@@ -35,11 +35,6 @@#define GIC_PPI_EDGE_MASK 0xFFFFD7FFextern void msm_secondary_startup (void ); -/* -* control for which core is the next to come out of the secondary -* boot "holding pen". -*/ -volatile int pen_release =-1 ;static DEFINE_SPINLOCK (boot_lock);
arch/arm/mach-realview/hotplug.c +0 -2
@@ -16,8 +16,6 @@#include <asm/cp15.h> #include <asm/smp_plat.h> -extern volatile int pen_release; -static inline void cpu_enter_lowpower (void ) {unsigned int v;
arch/arm/mach-spear13xx/hotplug.c +0 -2
@@ -17,8 +17,6 @@#include <asm/cp15.h> #include <asm/smp_plat.h> -extern volatile int pen_release; -static inline void cpu_enter_lowpower (void ) {unsigned int v;
arch/arm/mach-spear13xx/platsmp.c +0 -5
@@ -21,11 +21,6 @@#include <mach/spear.h> #include <mach/generic.h> -/* -* control for which core is the next to come out of the secondary -* boot "holding pen" -*/ -volatile int __cpuinitdata pen_release =-1 ;static DEFINE_SPINLOCK (boot_lock);static void __iomem *scu_base =IOMEM (VA_SCU_BASE );
arch/arm/mach-ux500/hotplug.c +0 -2
@@ -17,8 +17,6 @@#include <mach/setup.h> -extern volatile int pen_release; -/* * platform-specific code to shutdown a CPU *
arch/arm/mach-ux500/platsmp.c +0 -6
@@ -28,12 +28,6 @@extern void u8500_secondary_startup (void );/* -* control for which core is the next to come out of the secondary -* boot "holding pen" -*/ -volatile int pen_release =-1 ; - -/* * Write pen_release in a way that is guaranteed to be visible to all * observers, irrespective of whether they're taking part in coherency * or not. This is necessary for the hotplug code to work reliably.
arch/arm/mach-vexpress/hotplug.c +0 -2
@@ -16,8 +16,6 @@#include <asm/smp_plat.h> #include <asm/cp15.h> -extern volatile int pen_release; -static inline void cpu_enter_lowpower (void ) {unsigned int v;
arch/arm/plat-versatile/platsmp.c +0 -6
@@ -20,12 +20,6 @@#include <asm/hardware/gic.h> /* -* control for which core is the next to come out of the secondary -* boot "holding pen" -*/ -volatile int __cpuinitdata pen_release =-1 ; - -/* * Write pen_release in a way that is guaranteed to be visible to all * observers, irrespective of whether they're taking part in coherency * or not. This is necessary for the hotplug code to work reliably.
Signature · 1 line
1.7.10
Re: [PATCH v9 13/13] ARM: consolidate pen_release instead of having per platform definitions
Quoted 5 lines · Arnd Bergmann
From: Marc Zyngier <[email protected]>
Almost each SMP platform defines
pen_releaseto manage booting secondary CPUs. This of course clashes with the single zImage effort.
Quoted 7 lines
Add the
pen_releasedefinition to the ARM SMP code, and remove all others. This should only be used by platforms which lack any kind of CPU power management...Reported-by Arnd Bergmann <[email protected]>Signed-off-by Marc Zyngier <[email protected]>Signed-off-by Arnd Bergmann <[email protected]>
Quoted 216 lines
--- arch/arm/include/asm/smp.h | 1 + arch/arm/kernel/smp.c | 6 ++++++ arch/arm/mach-exynos/hotplug.c | 2 -- arch/arm/mach-exynos/platsmp.c | 7 ------- arch/arm/mach-msm/hotplug.c | 2 -- arch/arm/mach-msm/platsmp.c | 5 ----- arch/arm/mach-realview/hotplug.c | 2 -- arch/arm/mach-spear13xx/hotplug.c | 2 -- arch/arm/mach-spear13xx/platsmp.c | 5 ----- arch/arm/mach-ux500/hotplug.c | 2 -- arch/arm/mach-ux500/platsmp.c | 6 ------ arch/arm/mach-vexpress/hotplug.c | 2 -- arch/arm/plat-versatile/platsmp.c | 6 ------ 13 files changed, 7 insertions(+), 41 deletions(-)arch/arm/include/asm/smp.h +1
-0@@ -70,6 +70,7 @@ struct secondary_data {void *stack; };extern struct secondary_data secondary_data; +extern volatile int pen_release;extern int __cpu_disable (void );arch/arm/kernel/smp.c +6
-0@@ -51,6 +51,12 @@*/ struct secondary_data secondary_data; +/* +* control for which core is the next to come out of the secondary +* boot "holding pen" +*/ +volatile int __cpuinitdata pen_release =-1 ; +enum ipi_msg_type {IPI_TIMER =2 ,IPI_RESCHEDULE ,arch/arm/mach-exynos/hotplug.c +0
-2@@ -23,8 +23,6 @@#include "common.h" -extern volatile int pen_release; -static inline void cpu_enter_lowpower (void ) {unsigned int v;arch/arm/mach-exynos/platsmp.c +0
-7@@ -40,13 +40,6 @@ extern void exynos4_secondary_startup(void); S5P_INFORM5 : S5P_VA_SYSRAM)/* -* control for which core is the next to come out of the secondary -* boot "holding pen" -*/ - -volatile int __cpuinitdata pen_release = -1; - -/* * Write pen_release in a way that is guaranteed to be visible to all * observers, irrespective of whether they're taking part in coherency * or not. This is necessary for the hotplug code to work reliably. arch/arm/mach-msm/hotplug.c +0
-2@@ -15,8 +15,6 @@#include "core.h" -extern volatile int pen_release; -static inline void cpu_enter_lowpower (void ) {/* Just flush the cache. Changing the coherency is not yet arch/arm/mach-msm/platsmp.c +0
-5@@ -35,11 +35,6 @@#define GIC_PPI_EDGE_MASK 0xFFFFD7FFextern void msm_secondary_startup (void ); -/* -* control for which core is the next to come out of the secondary -* boot "holding pen". -*/ -volatile int pen_release =-1 ;static DEFINE_SPINLOCK (boot_lock);arch/arm/mach-realview/hotplug.c +0
-2@@ -16,8 +16,6 @@#include <asm/cp15.h> #include <asm/smp_plat.h> -extern volatile int pen_release; -static inline void cpu_enter_lowpower (void ) {unsigned int v;arch/arm/mach-spear13xx/hotplug.c +0
-2@@ -17,8 +17,6 @@#include <asm/cp15.h> #include <asm/smp_plat.h> -extern volatile int pen_release; -static inline void cpu_enter_lowpower (void ) {unsigned int v;arch/arm/mach-spear13xx/platsmp.c +0
-5@@ -21,11 +21,6 @@#include <mach/spear.h> #include <mach/generic.h> -/* -* control for which core is the next to come out of the secondary -* boot "holding pen" -*/ -volatile int __cpuinitdata pen_release =-1 ;static DEFINE_SPINLOCK (boot_lock);static void __iomem *scu_base =IOMEM (VA_SCU_BASE );arch/arm/mach-ux500/hotplug.c +0
-2@@ -17,8 +17,6 @@#include <mach/setup.h> -extern volatile int pen_release; -/* * platform-specific code to shutdown a CPU * arch/arm/mach-ux500/platsmp.c +0
-6@@ -28,12 +28,6 @@extern void u8500_secondary_startup (void );/* -* control for which core is the next to come out of the secondary -* boot "holding pen" -*/ -volatile int pen_release =-1 ; - -/* * Write pen_release in a way that is guaranteed to be visible to all * observers, irrespective of whether they're taking part in coherency * or not. This is necessary for the hotplug code to work reliably. arch/arm/mach-vexpress/hotplug.c +0
-2@@ -16,8 +16,6 @@#include <asm/smp_plat.h> #include <asm/cp15.h> -extern volatile int pen_release; -static inline void cpu_enter_lowpower (void ) {unsigned int v;arch/arm/plat-versatile/platsmp.c +0
-6@@ -20,12 +20,6 @@#include <asm/hardware/gic.h> /* -* control for which core is the next to come out of the secondary -* boot "holding pen" -*/ -volatile int __cpuinitdata pen_release =-1 ; - -/* * Write pen_release in a way that is guaranteed to be visible to all * observers, irrespective of whether they're taking part in coherency * or not. This is necessary for the hotplug code to work reliably. Signature · 7 lines
1.7.10 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Quoted 9 lines · Arnd Bergmann
As I promised at the ARM mini summit, I've updated Marc's series for smp operations according to my complaints. Unfortunately, I could not find version 7 of the patches when I started this, so I based my work on version 6 and had to redo the same changes.
The patches are also available on
git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.gittesting/smp_ops
There are still minor details nagging me, although I did mention them in my previous review of this series. You might have disagreed if I remember correctly. They aren't fundamental, and my insisting on them would only be bikeshedding at this point. Therefore you can add my ACK.
Nicolas
Quoted 5 lines · Arnd Bergmann
As I promised at the ARM mini summit, I've updated Marc's series for smp operations according to my complaints. Unfortunately, I could not find version 7 of the patches when I started this, so I based my work on version 6 and had to redo the same changes.
I'm quite happy with that series. I don't have much to add (my SoB is already all over the place), so if all platform maintainers are willing to give their acks, let's merge the damned thing! :-)
M.
Signature · 1 line
Jazz is not dead. It just smells funny...