Skip to contentSkip to conversation

R-Car SATA driver and platform data

PATCH New Sergei Shtylyov 2 participants 4 messages Feb 16, 2013 – Feb 19, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover R-Car SATA driver and platform data

Hello.

Here's the set of 4 patches against the Simon Horman's renesas.git repo, 'next' branch:

[1/4] ARM: mach-shmobile: r8a7779: SATA DT configuration [2/4] ARM: mach-shmobile: r8a7779: add SATA support [3/4] libata: add R-Car SATA driver
[4/4] ARM: mach-shmobile: marzen: add SATA support

Patch 3 also applies to the 'upstream' branch of Jeff Garzik's libata-dev.git repo.

MBR, Sergei

#1 lore raw

cover R-Car SATA driver and platform data

Quoted 10 lines · Sergei Shtylyov

Hello.

Here's the set of 4 patches against the Simon Horman's renesas.git repo, 'next' branch:

[1/4] ARM: mach-shmobile: r8a7779: SATA DT configuration [2/4] ARM: mach-shmobile: r8a7779: add SATA support [3/4] libata: add R-Car SATA driver
[4/4] ARM: mach-shmobile: marzen: add SATA support

Patch 3 also applies to the 'upstream' branch of Jeff Garzik's libata-dev.git repo.

Hi Sergei, Hi All,

I do not expect patch 3 of this series to got through
the renesas tree, however, I have included it and the other three patches in this series to a topic branch in the renesas tree, topic/r-car-stat.

The base of the topic branch is:
* a merge of renesas.git next and libata-dev.git upstream, and;
* a boot fix for Marzen which I plan to add to next once it is reviewed:
"ARM: shmobile: r8a7779: Correct TMU clock support again" (v3).

With this in place I built a kernel using the marzen_defconfig and booted it. However, I wonder if I am missing a kernel option, or perhaps something else of a minor nature as I see the following:

# dmesg | grep sata
sata_rcar sata_rcar: coherent DMA mask is unset
sata_rcar sata_rcar: failed to start port 0 (errno=-12)
sata_rcar: probe of sata_rcar failed with error -12
#2 lore raw

cover R-Car SATA driver and platform data

Hello.

Quoted 7 lines · Simon Horman
Quoted 6 lines

Here's the set of 4 patches against the Simon Horman's renesas.git repo, 'next' branch:

[1/4] ARM: mach-shmobile: r8a7779: SATA DT configuration [2/4] ARM: mach-shmobile: r8a7779: add SATA support [3/4] libata: add R-Car SATA driver
[4/4] ARM: mach-shmobile: marzen: add SATA support

Quoted 7 lines
Quoted 1 line

Patch 3 also applies to the 'upstream' branch of Jeff Garzik's libata-dev.git repo.

Hi Sergei, Hi All,

I do not expect patch 3 of this series to got through
the renesas tree, however, I have included it and the other three patches in this series to a topic branch in the renesas tree, topic/r-car-stat.

I probably make the patch 3 patch 1 in the next posting.

Quoted 5 lines

The base of the topic branch is:
* a merge of renesas.git next and libata-dev.git upstream, and;
* a boot fix for Marzen which I plan to add to next once it is reviewed:
"ARM: shmobile: r8a7779: Correct TMU clock support again" (v3).

Quoted 8 lines

With this in place I built a kernel using the marzen_defconfig and booted it. However, I wonder if I am missing a kernel option, or perhaps something else of a minor nature as I see the following:

# dmesg | grep sata
sata_rcar sata_rcar: coherent DMA mask is unset
sata_rcar sata_rcar: failed to start port 0 (errno=-12)
sata_rcar: probe of sata_rcar failed with error -12

No, it's entirely our fault -- Vladimir didn't test the driver in non-DT
mode with DMA support added (due to the above mentioned boot fix missing), and I didn't notice the missing intializers for 'sata_device.dev.[coherent_]dma_mask' when reviewing his patches. V2 will be posted soon.

WBR, Sergei

#3 lore raw

cover R-Car SATA driver and platform data

Quoted 35 lines · Sergei Shtylyov

Hello.

Quoted 7 lines · Simon Horman
Quoted 6 lines

Here's the set of 4 patches against the Simon Horman's renesas.git repo, 'next' branch:

[1/4] ARM: mach-shmobile: r8a7779: SATA DT configuration [2/4] ARM: mach-shmobile: r8a7779: add SATA support [3/4] libata: add R-Car SATA driver
[4/4] ARM: mach-shmobile: marzen: add SATA support

Quoted 7 lines
Quoted 1 line

Patch 3 also applies to the 'upstream' branch of Jeff Garzik's libata-dev.git repo.

Hi Sergei, Hi All,

I do not expect patch 3 of this series to got through
the renesas tree, however, I have included it and the other three patches in this series to a topic branch in the renesas tree, topic/r-car-stat.

I probably make the patch 3 patch 1 in the next posting.

Quoted 5 lines

The base of the topic branch is:
* a merge of renesas.git next and libata-dev.git upstream, and;
* a boot fix for Marzen which I plan to add to next once it is reviewed:
"ARM: shmobile: r8a7779: Correct TMU clock support again" (v3).

Quoted 8 lines

With this in place I built a kernel using the marzen_defconfig and booted it. However, I wonder if I am missing a kernel option, or perhaps something else of a minor nature as I see the following:

# dmesg | grep sata
sata_rcar sata_rcar: coherent DMA mask is unset
sata_rcar sata_rcar: failed to start port 0 (errno=-12)
sata_rcar: probe of sata_rcar failed with error -12
Quoted 5 lines

No, it's entirely our fault -- Vladimir didn't test the driver in
non-DT mode with DMA support added (due to the above mentioned boot fix missing), and I didn't notice the missing intializers for 'sata_device.dev.[coherent_]dma_mask' when reviewing his patches. V2 will be posted soon.

Great, thanks.