Skip to contentSkip to conversation

Trivial patches

PATCH In review Stephen Hemminger 4 participants 9 messages Mar 8, 2013 – Mar 9, 2013

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

cover Trivial patches

These are trivial patches to fix some sparse warnings.

#1 lore raw

PATCH 1/5 bna: fix declaration mismatch

The function is declared to take u32 but definition uses enum.

drivers/net/ethernet/brocade/bna/bfa_ioc.c +1 -1
@@ -76,7 +76,7 @@ static void bfa_ioc_pf_disabled(struct b
 static void bfa_ioc_pf_failed(struct bfa_ioc *ioc);
 static void bfa_ioc_pf_hwfailed(struct bfa_ioc *ioc);
 static void bfa_ioc_pf_fwmismatch(struct bfa_ioc *ioc);
-static void bfa_ioc_boot(struct bfa_ioc *ioc, u32 boot_type,
+static void bfa_ioc_boot(struct bfa_ioc *ioc, enum bfi_fwboot_type boot_type,
 			 u32 boot_param);
 static u32 bfa_ioc_smem_pgnum(struct bfa_ioc *ioc, u32 fmaddr);
 static void bfa_ioc_get_adapter_serial_num(struct bfa_ioc *ioc,
#4 lore raw

PATCH 3/5 phy: vitesse make vsc824x_add_skew static

In reply to Stephen Hemminger

Function is only used in this file, should be static and not an exported symbol.

drivers/net/phy/vitesse.c +1 -2
@@ -61,7 +61,7 @@ MODULE_DESCRIPTION("Vitesse PHY driver")
 MODULE_AUTHOR("Kriston Carson");
 MODULE_LICENSE("GPL");
 
-int vsc824x_add_skew(struct phy_device *phydev)
+static int vsc824x_add_skew(struct phy_device *phydev)
 {
 	int err;
 	int extcon;
@@ -81,7 +81,6 @@ int vsc824x_add_skew(struct phy_device *
 
 	return err;
 }
-EXPORT_SYMBOL(vsc824x_add_skew);
 
 static int vsc824x_config_init(struct phy_device *phydev)
 {
#5 lore raw

PATCH 4/5 team: make local function static

In reply to Stephen Hemminger
drivers/net/team/team.c +3 -3
@@ -503,9 +503,9 @@ static bool team_dummy_transmit(struct t
 	return false;
 }
 
-rx_handler_result_t team_dummy_receive(struct team *team,
-				       struct team_port *port,
-				       struct sk_buff *skb)
+static rx_handler_result_t team_dummy_receive(struct team *team,
+					      struct team_port *port,
+					      struct sk_buff *skb)
 {
 	return RX_HANDLER_ANOTHER;
 }
maintainer Acked-by on v1 4/5
#6 lore raw

Re: [PATCH net-next 4/5] team: make local function static

Quoted 10 lines · Fri, Mar 08, 2013 at 08:07:43PM CET, [email protected] wrote:
drivers/net/team/team.c +0 -0
@@ -503,9 +503,9 @@ static bool team_dummy_transmit(struct t
 	return false;
 }

drivers/net/team/team.c static bool team_dummy_transmit(struct t · line 511

Quoted 10 lines
drivers/net/team/team.c +3 -3
 
-rx_handler_result_t team_dummy_receive(struct team *team,
-				       struct team_port *port,
-				       struct sk_buff *skb)
+static rx_handler_result_t team_dummy_receive(struct team *team,
+					      struct team_port *port,
+					      struct sk_buff *skb)
 {
 	return RX_HANDLER_ANOTHER;
 }

Thanks Stephen.