Trivial patches
Subsystems (5)
cover Trivial patches
These are trivial patches to fix some sparse warnings.
PATCH 1/5 bna: fix declaration mismatch
The function is declared to take u32 but definition uses enum.
drivers/net/ethernet/brocade/bna/bfa_ioc.c +1 -1
@@ -76,7 +76,7 @@ static void bfa_ioc_pf_disabled(struct bstatic void bfa_ioc_pf_failed (struct bfa_ioc *ioc);static void bfa_ioc_pf_hwfailed (struct bfa_ioc *ioc);static void bfa_ioc_pf_fwmismatch (struct bfa_ioc *ioc); -static void bfa_ioc_boot (struct bfa_ioc *ioc,u32 boot_type, +static void bfa_ioc_boot (struct bfa_ioc *ioc,enum bfi_fwboot_type boot_type,u32 boot_param);static u32 bfa_ioc_smem_pgnum (struct bfa_ioc *ioc,u32 fmaddr); static void bfa_ioc_get_adapter_serial_num(struct bfa_ioc *ioc,
RE: [PATCH net-next 1/5] bna: fix declaration mismatch
Quoted 6 lines
From: Stephen Hemminger [mailto:[email protected]]
Sent: Friday, March 08, 2013 11:08 AMThe function is declared to take u32 but definition uses enum.
Signed-off-by Stephen Hemminger <[email protected]>
You are right, thanks Stephen!
PATCH 2/5 Supject: phy: make local function static
In reply to Stephen Hemmingerdrivers/net/phy/lxt.c +1 -1
@@ -159,7 +159,7 @@ static int lxt973a2_update_link(struct preturn 0 ; } -int lxt973a2_read_status (struct phy_device *phydev) +static int lxt973a2_read_status (struct phy_device *phydev) {int adv;int err;
PATCH 3/5 phy: vitesse make vsc824x_add_skew static
In reply to Stephen HemmingerFunction is only used in this file, should be static and not an exported symbol.
drivers/net/phy/vitesse.c +1 -2
@@ -61,7 +61,7 @@ MODULE_DESCRIPTION("Vitesse PHY driver")MODULE_AUTHOR ("Kriston Carson" );MODULE_LICENSE ("GPL" ); -int vsc824x_add_skew (struct phy_device *phydev) +static int vsc824x_add_skew (struct phy_device *phydev) {int err;int extcon;
@@ -81,7 +81,6 @@ int vsc824x_add_skew(struct phy_device *return err; } -EXPORT_SYMBOL (vsc824x_add_skew);static int vsc824x_config_init (struct phy_device *phydev) {
PATCH 4/5 team: make local function static
In reply to Stephen Hemmingerdrivers/net/team/team.c +3 -3
@@ -503,9 +503,9 @@ static bool team_dummy_transmit(struct treturn false; } -rx_handler_result_t team_dummy_receive (struct team *team, -struct team_port *port, -struct sk_buff *skb) +static rx_handler_result_t team_dummy_receive (struct team *team, +struct team_port *port, +struct sk_buff *skb) {return RX_HANDLER_ANOTHER ; }
Re: [PATCH net-next 4/5] team: make local function static
Quoted 10 lines · Fri, Mar 08, 2013 at 08:07:43PM CET, [email protected] wrote:
Signed-off-by Stephen Hemminger <[email protected]>drivers/net/team/team.c +0
-0@@ -503,9 +503,9 @@ static bool team_dummy_transmit(struct treturn false; }
drivers/net/team/team.c static bool team_dummy_transmit(struct t · line 511
Quoted 10 lines
drivers/net/team/team.c +3
-3-rx_handler_result_t team_dummy_receive (struct team *team, -struct team_port *port, -struct sk_buff *skb) +static rx_handler_result_t team_dummy_receive (struct team *team, +struct team_port *port, +struct sk_buff *skb) {return RX_HANDLER_ANOTHER ; }
Thanks Stephen.
PATCH 5/5 dcb: fix sparse warnings
In reply to Stephen HemmingerAdd header with function definitions to quiet warnings and avoid future errors.
net/dcb/dcbevent.c +1 -0
@@ -20,6 +20,7 @@#include <linux/rtnetlink.h> #include <linux/notifier.h> #include <linux/export.h> +#include <net/dcbevent.h> static ATOMIC_NOTIFIER_HEAD (dcbevent_notif_chain);
David Miller
maintainerFrom: Stephen Hemminger <[email protected]>
Date: Fri, 08 Mar 2013 11:07:39 -0800
Quoted 1 line
These are trivial patches to fix some sparse warnings.
Series applied, thanks Stephen.