Skip to contentSkip to conversation

sh-pfc: Initial r8a73a4 PFC support

PATCH Superseded Magnus Damm 3 participants 4 messages Mar 18, 2013 – Mar 19, 2013 SuperH

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover sh-pfc: Initial r8a73a4 PFC support

sh-pfc: Initial r8a73a4 PFC support

[PATCH 01/02] sh-pfc: Add r8a73a4 pinmux support [PATCH 02/02] sh-pfc: Add r8a73a4 GPIO IRQ support

This series is V1 of initial PFC support for the r8a73a4 SoC. Nothing out of the ordinary, just similar but different tables to describe the pinmux hardware and GPIOs on r8a73a4.

The header in the mach directory is still used, and in the future this will be removed when fully using PINCTRL. Until then a common location is needed so this series simply follows what other SoCs do. Because of this there is a dependency on the r8a73a4 SoC code.

---

Written against "next" renesas.git 811689afc214564c4a5f238ecf4d8bdc0e52b615 Requires "r8a73a4.h" provided by
[PATCH 00/04] ARM: shmobile: r8a73a4 SoC support V2

 arch/arm/mach-shmobile/include/mach/r8a73a4.h |  918 +++++++
 drivers/pinctrl/sh-pfc/Kconfig                |    5 
 drivers/pinctrl/sh-pfc/Makefile               |    1 
 drivers/pinctrl/sh-pfc/core.c                 |    3 
 drivers/pinctrl/sh-pfc/core.h                 |    1 
 drivers/pinctrl/sh-pfc/pfc-r8a73a4.c          | 2889 +++++++++++++++++++++++++
 6 files changed, 3817 insertions(+)
#1 lore raw
Quoted 5 lines · Magnus Damm

sh-pfc: Initial r8a73a4 PFC support

[PATCH 01/02] sh-pfc: Add r8a73a4 pinmux support [PATCH 02/02] sh-pfc: Add r8a73a4 GPIO IRQ support

Quoted 8 lines

This series is V1 of initial PFC support for the r8a73a4 SoC. Nothing out of the ordinary, just similar but different tables to describe the pinmux hardware and GPIOs on r8a73a4.

The header in the mach directory is still used, and in the future this will be removed when fully using PINCTRL. Until then a common location is needed so this series simply follows what other SoCs do. Because of this there is a dependency on the r8a73a4 SoC code.

Laurent, could you review these and either give me some Acks or
a branch to pull? I assume the base should be the renesas-pinmux-for-v3.10 tag in the renesas tree.

Thanks.

#2 lore raw
In reply to Magnus Damm
Quoted 14 lines · Magnus Damm

sh-pfc: Initial r8a73a4 PFC support

[PATCH 01/02] sh-pfc: Add r8a73a4 pinmux support [PATCH 02/02] sh-pfc: Add r8a73a4 GPIO IRQ support

This series is V1 of initial PFC support for the r8a73a4 SoC. Nothing out of the ordinary, just similar but different tables to describe the pinmux hardware and GPIOs on r8a73a4.

The header in the mach directory is still used, and in the future this will be removed when fully using PINCTRL. Until then a common location is needed so this series simply follows what other SoCs do. Because of this there is a dependency on the r8a73a4 SoC code.

Quoted 6 lines

---

Written against "next" renesas.git 811689afc214564c4a5f238ecf4d8bdc0e52b615 Requires "r8a73a4.h" provided by
[PATCH 00/04] ARM: shmobile: r8a73a4 SoC support V2

For reference, these patches seem to depend on some of
the patches in the pinmux branch, tagged as renesas-pinmux-for-v3.10, but no other patches in next.

Quoted 13 lines
 arch/arm/mach-shmobile/include/mach/r8a73a4.h |  918 +++++++
 drivers/pinctrl/sh-pfc/Kconfig                |    5 
 drivers/pinctrl/sh-pfc/Makefile               |    1 
 drivers/pinctrl/sh-pfc/core.c                 |    3 
 drivers/pinctrl/sh-pfc/core.h                 |    1 
 drivers/pinctrl/sh-pfc/pfc-r8a73a4.c          | 2889 +++++++++++++++++++++++++
 6 files changed, 3817 insertions(+)

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
In reply to Magnus Damm

Hi Simon,

Quoted 10 lines · On Tuesday 19 March 2013 09:26:53 Simon Horman wrote:
Quoted 9 lines · Magnus Damm

sh-pfc: Initial r8a73a4 PFC support

[PATCH 01/02] sh-pfc: Add r8a73a4 pinmux support [PATCH 02/02] sh-pfc: Add r8a73a4 GPIO IRQ support

This series is V1 of initial PFC support for the r8a73a4 SoC. Nothing out of the ordinary, just similar but different tables to describe the pinmux hardware and GPIOs on r8a73a4.

Quoted 8 lines
Quoted 4 lines

The header in the mach directory is still used, and in the future this will be removed when fully using PINCTRL. Until then a common location is needed so this series simply follows what other SoCs do. Because of this there is a dependency on the r8a73a4 SoC code.

Laurent, could you review these and either give me some Acks or a branch to pull? I assume the base should be the renesas-pinmux-for-v3.10 tag in the renesas tree.

I will review the patches. However, following a discussion I've had with Magnus, I won't take the patches without proper pinctrl support. The first patch uses the old API for r8a73a4 support in the PFC driver to make backporting easier, but I don't want to push it to mainline without additional patches to move to the pinctrl API.

Magnus, are you working on that ?

Signature · 3 lines
Regards,

Laurent Pinchart