dosfstools: fix host variant dependencies
PATCH 1/1 dosfstools: fix host variant dependencies
host-dosfstools shouldn't pull host-libiconv in since that's for uClibc-based toolchains and we don't have that package anyway. Fixes:
http://autobuild.buildroot.net/results/7637985bfb0afdd9217c297e9b0ac5de797c137d/
--- package/dosfstools/dosfstools.mk | 3 +++ 1 file changed, 3 insertions(+)
package/dosfstools/dosfstools.mk +3 -0
@@ -10,6 +10,9 @@ DOSFSTOOLS_LICENSE = GPLv3+ DOSFSTOOLS_LICENSE_FILES = COPYING DOSFSTOOLS_LDFLAGS = $(TARGET_LDFLAGS) +# Avoid target dosfstools dependencies, no host-libiconv +HOST_DOSFSTOOLS_DEPENDENCIES = + ifneq ($(BR2_ENABLE_LOCALE),y) DOSFSTOOLS_DEPENDENCIES += libiconv DOSFSTOOLS_LDFLAGS += -liconv
Signature · 1 line
1.8.1.5
PATCH 1/1 dosfstools: fix host variant dependencies
Gustavo, All,
Quoted 15 lines · On Thursday 21 March 2013 13:12:34 Gustavo Zacarias wrote:
host-dosfstools shouldn't pull host-libiconv in since that's for uClibc-based toolchains and we don't have that package anyway. Fixes:
http://autobuild.buildroot.net/results/7637985bfb0afdd9217c297e9b0ac5de797c137d/Signed-off-by Gustavo Zacarias <[email protected]>--- package/dosfstools/dosfstools.mk | 3 +++ 1 file changed, 3 insertions(+)package/dosfstools/dosfstools.mk +0
-0
package/dosfstools/dosfstools.mk DOSFSTOOLS_LICENSE = GPLv3+ · line 15
Quoted 6 lines
package/dosfstools/dosfstools.mk +3
-0@@ -10,6 +10,9 @@ DOSFSTOOLS_LICENSE = GPLv3+ DOSFSTOOLS_LICENSE_FILES = COPYING DOSFSTOOLS_LDFLAGS = $(TARGET_LDFLAGS) +# Avoid target dosfstools dependencies, no host-libiconv +HOST_DOSFSTOOLS_DEPENDENCIES = +
Shouldn't we also do:
HOST_DOSFSTOOLS_LDFLAGS =
package/dosfstools/dosfstools.mk DOSFSTOOLS_LICENSE = GPLv3+ · line 18
Quoted 3 lines
package/dosfstools/dosfstools.mk +0
-0ifneq ($(BR2_ENABLE_LOCALE),y) DOSFSTOOLS_DEPENDENCIES += libiconv DOSFSTOOLS_LDFLAGS += -liconv
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +0/33 662376056 | Software Designer | \ / CAMPAIGN | ^ | | --==< O_o >==-- '------------.-------: X AGAINST | /e\ There is no | | http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL | """ conspiracy. | '------------------------------'-------'------------------'--------------------'
PATCH 1/1 dosfstools: fix host variant dependencies
Quoted 10 lines · Yann E. MORIN
package/dosfstools/dosfstools.mk DOSFSTOOLS_LICENSE = GPLv3+ · line 15
Quoted 3 lines
package/dosfstools/dosfstools.mk +3
-0+# Avoid target dosfstools dependencies, no host-libiconv +HOST_DOSFSTOOLS_DEPENDENCIES = +Shouldn't we also do:
HOST_DOSFSTOOLS_LDFLAGS=Quoted 3 lines
ifneq ($(BR2_ENABLE_LOCALE),y)
DOSFSTOOLS_DEPENDENCIES+= libiconv
DOSFSTOOLS_LDFLAGS+= -liconv
Not really, HOST_LDFLAGS doesn't inherit.
Regards.
PATCH 1/1 dosfstools: fix host variant dependencies
Quoted 9 lines · Gustavo Zacarias
Quoted 7 lines · Yann E. MORIN
package/dosfstools/dosfstools.mk DOSFSTOOLS_LICENSE = GPLv3+ · line 15
Quoted 3 lines
package/dosfstools/dosfstools.mk +3
-0+# Avoid target dosfstools dependencies, no host-libiconv +HOST_DOSFSTOOLS_DEPENDENCIES = +Shouldn't we also do:
HOST_DOSFSTOOLS_LDFLAGS=
Quoted 6 lines
Quoted 3 lines
Quoted 3 lines
ifneq ($(BR2_ENABLE_LOCALE),y)
DOSFSTOOLS_DEPENDENCIES+= libiconv
DOSFSTOOLS_LDFLAGS+= -liconvNot really,
HOST_LDFLAGSdoesn't inherit.
Regards.
And we explicitly use a clean BUILD_CMDS for the host :) Regards.
PATCH 1/1 dosfstools: fix host variant dependencies
In reply to Gustavo ZacariasGustavo, All,
Quoted 6 lines · On Thursday 21 March 2013 Gustavo Zacarias wrote:
host-dosfstools shouldn't pull host-libiconv in since that's for uClibc-based toolchains and we don't have that package anyway. Fixes:
http://autobuild.buildroot.net/results/7637985bfb0afdd9217c297e9b0ac5de797c137d/Signed-off-by Gustavo Zacarias <[email protected]>
Thanks for fixing my breakage! ;-)
Regards,
Yann E. MORIN.
Quoted 27 lines
--- package/dosfstools/dosfstools.mk | 3 +++ 1 file changed, 3 insertions(+)package/dosfstools/dosfstools.mk +3
-0@@ -10,6 +10,9 @@ DOSFSTOOLS_LICENSE = GPLv3+ DOSFSTOOLS_LICENSE_FILES = COPYING DOSFSTOOLS_LDFLAGS = $(TARGET_LDFLAGS) +# Avoid target dosfstools dependencies, no host-libiconv +HOST_DOSFSTOOLS_DEPENDENCIES = + ifneq ($(BR2_ENABLE_LOCALE),y) DOSFSTOOLS_DEPENDENCIES += libiconv DOSFSTOOLS_LDFLAGS += -liconvSignature · 6 lines
1.8.1.5 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 dosfstools: fix host variant dependencies
In reply to Gustavo ZacariasDear Gustavo Zacarias,
Quoted 6 lines · Gustavo Zacarias
host-dosfstools shouldn't pull host-libiconv in since that's for uClibc-based toolchains and we don't have that package anyway. Fixes:
http://autobuild.buildroot.net/results/7637985bfb0afdd9217c297e9b0ac5de797c137d/Signed-off-by Gustavo Zacarias <[email protected]>
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 dosfstools: fix host variant dependencies
In reply to Gustavo ZacariasQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Gustavo" == Gustavo Zacarias <[email protected]> writes:
Gustavo> host-dosfstools shouldn't pull host-libiconv in since that's for Gustavo> uClibc-based toolchains and we don't have that package anyway. Gustavo> Fixes:
Gustavo> http://autobuild.buildroot.net/results/7637985bfb0afdd9217c297e9b0ac5de797c137d/
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard