Skip to contentSkip to conversation

dosfstools: fix host variant dependencies

PATCH New Gustavo Zacarias 4 participants 7 messages Mar 21, 2013 – Mar 24, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dosfstools: fix host variant dependencies

host-dosfstools shouldn't pull host-libiconv in since that's for uClibc-based toolchains and we don't have that package anyway. Fixes:
http://autobuild.buildroot.net/results/7637985bfb0afdd9217c297e9b0ac5de797c137d/

---
 package/dosfstools/dosfstools.mk | 3 +++
 1 file changed, 3 insertions(+)
package/dosfstools/dosfstools.mk +3 -0
index 332f2ee..79d1c7a 100644
@@ -10,6 +10,9 @@ DOSFSTOOLS_LICENSE = GPLv3+
 DOSFSTOOLS_LICENSE_FILES = COPYING
 DOSFSTOOLS_LDFLAGS = $(TARGET_LDFLAGS)
 
+# Avoid target dosfstools dependencies, no host-libiconv
+HOST_DOSFSTOOLS_DEPENDENCIES =
+
 ifneq ($(BR2_ENABLE_LOCALE),y)
 DOSFSTOOLS_DEPENDENCIES += libiconv
 DOSFSTOOLS_LDFLAGS += -liconv
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH 1/1 dosfstools: fix host variant dependencies

Gustavo, All,

Quoted 15 lines · On Thursday 21 March 2013 13:12:34 Gustavo Zacarias wrote:

host-dosfstools shouldn't pull host-libiconv in since that's for uClibc-based toolchains and we don't have that package anyway. Fixes:
http://autobuild.buildroot.net/results/7637985bfb0afdd9217c297e9b0ac5de797c137d/

---
 package/dosfstools/dosfstools.mk | 3 +++
 1 file changed, 3 insertions(+)
package/dosfstools/dosfstools.mk +0 -0
index 332f2ee..79d1c7a 100644

package/dosfstools/dosfstools.mk DOSFSTOOLS_LICENSE = GPLv3+ · line 15

Quoted 6 lines
package/dosfstools/dosfstools.mk +3 -0
@@ -10,6 +10,9 @@ DOSFSTOOLS_LICENSE = GPLv3+
 DOSFSTOOLS_LICENSE_FILES = COPYING
 DOSFSTOOLS_LDFLAGS = $(TARGET_LDFLAGS)
 
+# Avoid target dosfstools dependencies, no host-libiconv
+HOST_DOSFSTOOLS_DEPENDENCIES =
+

Shouldn't we also do:
HOST_DOSFSTOOLS_LDFLAGS =

package/dosfstools/dosfstools.mk DOSFSTOOLS_LICENSE = GPLv3+ · line 18

Quoted 3 lines
package/dosfstools/dosfstools.mk +0 -0
 ifneq ($(BR2_ENABLE_LOCALE),y)
 DOSFSTOOLS_DEPENDENCIES += libiconv
 DOSFSTOOLS_LDFLAGS += -liconv

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software  Designer | \ / CAMPAIGN     |   ^                |
| --==< O_o >==-- '------------.-------:  X  AGAINST      |  /e\  There is no  |
| http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL    |  """  conspiracy.  |
'------------------------------'-------'------------------'--------------------'
#2 lore raw

PATCH 1/1 dosfstools: fix host variant dependencies

Quoted 10 lines · Yann E. MORIN

package/dosfstools/dosfstools.mk DOSFSTOOLS_LICENSE = GPLv3+ · line 15

Quoted 3 lines
package/dosfstools/dosfstools.mk +3 -0
+# Avoid target dosfstools dependencies, no host-libiconv
+HOST_DOSFSTOOLS_DEPENDENCIES =
+

Shouldn't we also do:
HOST_DOSFSTOOLS_LDFLAGS =

Quoted 3 lines

ifneq ($(BR2_ENABLE_LOCALE),y)
DOSFSTOOLS_DEPENDENCIES += libiconv
DOSFSTOOLS_LDFLAGS += -liconv

Not really, HOST_LDFLAGS doesn't inherit.
Regards.

#3 lore raw

PATCH 1/1 dosfstools: fix host variant dependencies

Quoted 9 lines · Gustavo Zacarias
Quoted 7 lines · Yann E. MORIN

package/dosfstools/dosfstools.mk DOSFSTOOLS_LICENSE = GPLv3+ · line 15

Quoted 3 lines
package/dosfstools/dosfstools.mk +3 -0
+# Avoid target dosfstools dependencies, no host-libiconv
+HOST_DOSFSTOOLS_DEPENDENCIES =
+

Shouldn't we also do:
HOST_DOSFSTOOLS_LDFLAGS =

Quoted 6 lines
Quoted 3 lines
Quoted 3 lines

ifneq ($(BR2_ENABLE_LOCALE),y)
DOSFSTOOLS_DEPENDENCIES += libiconv
DOSFSTOOLS_LDFLAGS += -liconv

Not really, HOST_LDFLAGS doesn't inherit.
Regards.

And we explicitly use a clean BUILD_CMDS for the host :) Regards.

#4 lore raw

PATCH 1/1 dosfstools: fix host variant dependencies

In reply to Gustavo Zacarias

Gustavo, All,

Quoted 6 lines · On Thursday 21 March 2013 Gustavo Zacarias wrote:

host-dosfstools shouldn't pull host-libiconv in since that's for uClibc-based toolchains and we don't have that package anyway. Fixes:
http://autobuild.buildroot.net/results/7637985bfb0afdd9217c297e9b0ac5de797c137d/

Thanks for fixing my breakage! ;-)

Regards,
Yann E. MORIN.

Quoted 27 lines
---
 package/dosfstools/dosfstools.mk | 3 +++
 1 file changed, 3 insertions(+)
package/dosfstools/dosfstools.mk +3 -0
index 332f2ee..79d1c7a 100644
@@ -10,6 +10,9 @@ DOSFSTOOLS_LICENSE = GPLv3+
 DOSFSTOOLS_LICENSE_FILES = COPYING
 DOSFSTOOLS_LDFLAGS = $(TARGET_LDFLAGS)
 
+# Avoid target dosfstools dependencies, no host-libiconv
+HOST_DOSFSTOOLS_DEPENDENCIES =
+
 ifneq ($(BR2_ENABLE_LOCALE),y)
 DOSFSTOOLS_DEPENDENCIES += libiconv
 DOSFSTOOLS_LDFLAGS += -liconv
Signature · 6 lines
1.8.1.5

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#5 lore raw

PATCH 1/1 dosfstools: fix host variant dependencies

In reply to Gustavo Zacarias

Dear Gustavo Zacarias,

Quoted 6 lines · Gustavo Zacarias

host-dosfstools shouldn't pull host-libiconv in since that's for uClibc-based toolchains and we don't have that package anyway. Fixes:
http://autobuild.buildroot.net/results/7637985bfb0afdd9217c297e9b0ac5de797c137d/

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#6 lore raw

PATCH 1/1 dosfstools: fix host variant dependencies

In reply to Gustavo Zacarias
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

Gustavo> host-dosfstools shouldn't pull host-libiconv in since that's for Gustavo> uClibc-based toolchains and we don't have that package anyway. Gustavo> Fixes:
Gustavo> http://autobuild.buildroot.net/results/7637985bfb0afdd9217c297e9b0ac5de797c137d/

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard