Skip to contentSkip to conversation

Remove OSS support for OpenBSD

PATCH In review Brad Smith 2 participants 4 messages May 8, 2013 – May 24, 2013

lore
Share & tools
lore

Brad Smith

author
#0 lore raw

PATCH 1/1 Remove OSS support for OpenBSD

Remove the OSS support for OpenBSD. The OSS API has not been usable for quite some time.

audio/ossaudio.c +0 -4
index 00be9c9..007c641 100644
@@ -25,11 +25,7 @@
 #include <sys/mman.h>
 #include <sys/types.h>
 #include <sys/ioctl.h>
-#ifdef __OpenBSD__
-#include <soundcard.h>
-#else
 #include <sys/soundcard.h>
-#endif
 #include "qemu-common.h"
 #include "qemu/main-loop.h"
 #include "qemu/host-utils.h"
configure +1 -2
index 9439f1c..89dda5b 100755
@@ -468,8 +468,7 @@ OpenBSD)
   bsd="yes"
   make="${MAKE-gmake}"
   audio_drv_list="oss"
-  audio_possible_drivers="oss sdl esd"
-  oss_lib="-lossaudio"
+  audio_possible_drivers="sdl esd"
 ;;
 Darwin)
   bsd="yes"
Signature · 3 lines
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
author
#1 lore raw
Quoted 4 lines · Brad Smith

Remove the OSS support for OpenBSD. The OSS API has not been usable for quite some time.

ping.

Quoted 30 lines
audio/ossaudio.c +0 -4
index 00be9c9..007c641 100644
@@ -25,11 +25,7 @@
 #include <sys/mman.h>
 #include <sys/types.h>
 #include <sys/ioctl.h>
-#ifdef __OpenBSD__
-#include <soundcard.h>
-#else
 #include <sys/soundcard.h>
-#endif
 #include "qemu-common.h"
 #include "qemu/main-loop.h"
 #include "qemu/host-utils.h"
configure +1 -2
index 9439f1c..89dda5b 100755
@@ -468,8 +468,7 @@ OpenBSD)
   bsd="yes"
   make="${MAKE-gmake}"
   audio_drv_list="oss"
-  audio_possible_drivers="oss sdl esd"
-  oss_lib="-lossaudio"
+  audio_possible_drivers="sdl esd"
 ;;
 Darwin)
   bsd="yes"
Signature · 3 lines
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
#2 lore raw
In reply to Brad Smith
Quoted 27 lines · Brad Smith

Remove the OSS support for OpenBSD. The OSS API has not been usable for quite some time.

audio/ossaudio.c +0 -4
index 00be9c9..007c641 100644
@@ -25,11 +25,7 @@
 #include <sys/mman.h>
 #include <sys/types.h>
 #include <sys/ioctl.h>
-#ifdef __OpenBSD__
-#include <soundcard.h>
-#else
 #include <sys/soundcard.h>
-#endif
 #include "qemu-common.h"
 #include "qemu/main-loop.h"
 #include "qemu/host-utils.h"
configure +0 -0
index 9439f1c..89dda5b 100755

configure OpenBSD) · line 474

Quoted 9 lines
configure +1 -2
@@ -468,8 +468,7 @@ OpenBSD)
   bsd="yes"
   make="${MAKE-gmake}"
   audio_drv_list="oss"
-  audio_possible_drivers="oss sdl esd"
-  oss_lib="-lossaudio"
+  audio_possible_drivers="sdl esd"
 ;;
 Darwin)
   bsd="yes"

Shouldn't the default audio driver list ($audio_drv_list) be a subset of the possible driver list?

Thanks,
Laszlo

author
#3 lore raw
Quoted 32 lines · Laszlo Ersek
Quoted 31 lines · Brad Smith

Remove the OSS support for OpenBSD. The OSS API has not been usable for quite some time.

audio/ossaudio.c +0 -4
index 00be9c9..007c641 100644
@@ -25,11 +25,7 @@
 #include <sys/mman.h>
 #include <sys/types.h>
 #include <sys/ioctl.h>
-#ifdef __OpenBSD__
-#include <soundcard.h>
-#else
 #include <sys/soundcard.h>
-#endif
 #include "qemu-common.h"
 #include "qemu/main-loop.h"
 #include "qemu/host-utils.h"
configure +0 -2
index 9439f1c..89dda5b 100755
@@ -468,8 +468,7 @@ OpenBSD)
   bsd="yes"
   make="${MAKE-gmake}"
   audio_drv_list="oss"
-  audio_possible_drivers="oss sdl esd"
-  oss_lib="-lossaudio"
Quoted 8 lines

configure OpenBSD) · line 474

Quoted 5 lines
configure +1 -0
+  audio_possible_drivers="sdl esd"
 ;;
 Darwin)
   bsd="yes"

Shouldn't the default audio driver list ($audio_drv_list) be a subset of the possible driver list?

My mistake. A new patch sent.

Signature · 3 lines
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.