Skip to contentSkip to conversation

ARM: OMAP: RX-51: change probe order of touchscreen and panel SPI devices

PATCH New Aaro Koskinen 2 participants 2 messages May 1, 2013 – May 8, 2013

Subsystems (3)
lore
Share & tools
lore

Aaro Koskinen

author maintainer
#0 lore raw

PATCH 1/1 ARM: OMAP: RX-51: change probe order of touchscreen and panel SPI devices

Commit 9fdca9df (spi: omap2-mcspi: convert to module_platform_driver) broke the SPI display/panel driver probe on RX-51/N900. The exact cause is not fully understood, but it seems to be related to the probe order. SPI communication to the panel driver (spi1.2) fails unless the touchscreen (spi1.0) has been probed/initialized before. When the omap2-mcspi driver was converted to a platform driver, it resulted in that the devices are probed immediately after the board registers them in the order they are listed in the board file.

Fix the issue by moving the touchscreen before the panel in the SPI device list.

The patch fixes the following failure:

[    1.260955] acx565akm spi1.2: invalid display ID
[    1.265899] panel-acx565akm display0: acx_panel_probe panel detect error
[    1.273071] omapdss CORE error: driver probe failed: -19
Cc Pali Roh?r <[email protected]>
Cc Joni Lapilainen <[email protected]>
Cc Tomi Valkeinen <[email protected]>
Cc Felipe Balbi <[email protected]>
Cc stable at vger.kernel.org
---
 arch/arm/mach-omap2/board-rx51-peripherals.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-omap2/board-rx51-peripherals.c +2 -2
index 1a88467..18ca61e 100644
@@ -73,11 +73,11 @@
 #define LIS302_IRQ1_GPIO 181
 #define LIS302_IRQ2_GPIO 180  /* Not yet in use */
 
-/* list all spi devices here */
+/* List all SPI devices here. Note that the list/probe order seems to matter! */
 enum {
 	RX51_SPI_WL1251,
-	RX51_SPI_MIPID,		/* LCD panel */
 	RX51_SPI_TSC2005,	/* Touch Controller */
+	RX51_SPI_MIPID,		/* LCD panel */
 };
 
 static struct wl12xx_platform_data wl1251_pdata;
Signature · 1 line
1.7.10.4
maintainer
#1 lore raw

PATCH 1/1 ARM: OMAP: RX-51: change probe order of touchscreen and panel SPI devices

Quoted 9 lines · Aaro Koskinen

Commit 9fdca9df (spi: omap2-mcspi: convert to module_platform_driver) broke the SPI display/panel driver probe on RX-51/N900. The exact cause is not fully understood, but it seems to be related to the probe order. SPI communication to the panel driver (spi1.2) fails unless the touchscreen (spi1.0) has been probed/initialized before. When the omap2-mcspi driver was converted to a platform driver, it resulted in that the devices are probed immediately after the board registers them in the order they are listed in the board file.

Quoted 8 lines

Fix the issue by moving the touchscreen before the panel in the SPI device list.

The patch fixes the following failure:

[    1.260955] acx565akm spi1.2: invalid display ID
[    1.265899] panel-acx565akm display0: acx_panel_probe panel detect error
[    1.273071] omapdss CORE error: driver probe failed: -19

Thanks for updating the description, applying into omap-for-v3.10/fixes.

Regards,

Tony