Skip to contentSkip to conversation

svcauth_gss: fix error code in use_gss_proxy()

PATCH In review Dan Carpenter 2 participants 2 messages May 11, 2013 1 message not in the archive

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 svcauth_gss: fix error code in use_gss_proxy()

This should return zero on success and -EBUSY on error so the type needs to be int instead of bool.

net/sunrpc/auth_gss/svcauth_gss.c +1 -1
index 871c73c..2c6a1ec 100644
@@ -1287,7 +1287,7 @@ static bool use_gss_proxy(struct net *net)
 
 #ifdef CONFIG_PROC_FS
 
-static bool set_gss_proxy(struct net *net, int type)
+static int set_gss_proxy(struct net *net, int type)
 {
 	struct sunrpc_net *sn = net_generic(net, sunrpc_net_id);
 	int ret = 0;

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 2 lines · Dan Carpenter

This should return zero on success and -EBUSY on error so the type needs to be int instead of bool.

Oops, you're right--thanks. Applying.--b.

Quoted 16 lines
net/sunrpc/auth_gss/svcauth_gss.c +1 -1
index 871c73c..2c6a1ec 100644
@@ -1287,7 +1287,7 @@ static bool use_gss_proxy(struct net *net)
 
 #ifdef CONFIG_PROC_FS
 
-static bool set_gss_proxy(struct net *net, int type)
+static int set_gss_proxy(struct net *net, int type)
 {
 	struct sunrpc_net *sn = net_generic(net, sunrpc_net_id);
 	int ret = 0;