graph-depends: ignore the 'target-generic-dont-remount-rw' target
PATCH 1/2 graph-depends: ignore the 'target-generic-dont-remount-rw' target
The graph-depends script tries to call 'make target-generic-dont-remount-rw', which doesn't exist since 'target-generic-dont-remount-rw' is not a package.
See also the comments for commit 72bd61e5b8c2094378.
---
I guess we could compute the TARGET_EXCEPTIONS automatically and avoid the need to update it every time. But it would be a longer work, so for now I would just fix it manually.
support/scripts/graph-depends | 1 + 1 file changed, 1 insertion(+)
support/scripts/graph-depends +1 -0
@@ -164,6 +164,7 @@ TARGET_EXCEPTIONS = [ "target-generic-issue", "target-generic-getty-busybox", "target-generic-do-remount-rw", + "target-generic-dont-remount-rw", "target-finalize", "erase-fakeroots", "target-generic-hostname",
Signature · 1 line
1.7.10.4
PATCH 2/2 graph-depends: fix program path in comment
--- support/scripts/graph-depends | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
support/scripts/graph-depends +1 -1
@@ -1,7 +1,7 @@ #!/usr/bin/python # Usage (the graphviz package must be installed in your distribution) -# ./scripts/graph-depends [package-name] > test.dot +# ./support/scripts/graph-depends [package-name] > test.dot # dot -Tpdf test.dot -o test.pdf # # With no arguments, graph-depends will draw a complete graph of
Signature · 1 line
1.7.10.4
PATCH 2/2 graph-depends: fix program path in comment
Dear Luca Ceresoli,
Quoted 4 lines · Luca Ceresoli
Signed-off-by Luca Ceresoli <[email protected]>--- support/scripts/graph-depends | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 2/2 graph-depends: fix program path in comment
In reply to Luca CeresoliQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Luca" == Luca Ceresoli <[email protected]> writes:
Luca> Signed-off-by: Luca Ceresoli <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/2 graph-depends: ignore the 'target-generic-dont-remount-rw' target
In reply to Luca CeresoliDear Luca Ceresoli,
Quoted 6 lines · Luca Ceresoli
The graph-depends script tries to call 'make target-generic-dont-remount-rw', which doesn't exist since 'target-generic-dont-remount-rw' is not a package.
See also the comments for commit
72bd61e5b8c2094378.Signed-off-by Luca Ceresoli <[email protected]>
Quoted 3 lines
I guess we could compute the
TARGET_EXCEPTIONSautomatically and avoid the need to update it every time. But it would be a longer work, so for now I would just fix it manually.
I agree. For example, target-generic-getty-sysvinit is still missing from the list.
I see two ways to handle that automatically:
* Have all those special targets starting with "target-" and have graph-depends exclude them automatically. Simple, but not nice if we have a real package named "target-<something>".
* Instead of registering all packages into the make variable called TARGETS, register them into a variable called PACKAGES, which will get appended (at the right place) to the TARGETS variable. This way, the 'show-targets' thing can be turned into a 'show-packages' that will only display the value of the PACKAGES variable. This solution is probably cleaner than the previous one.
What do you think?
Best regards,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/2 graph-depends: ignore the 'target-generic-dont-remount-rw' target
Quoted 23 lines · Thomas Petazzoni
Dear Luca Ceresoli,
Quoted 6 lines · Luca Ceresoli
The graph-depends script tries to call 'make target-generic-dont-remount-rw', which doesn't exist since 'target-generic-dont-remount-rw' is not a package.
See also the comments for commit
72bd61e5b8c2094378.Signed-off-by Luca Ceresoli <[email protected]>Acked-by Thomas Petazzoni <[email protected]>Quoted 3 lines
I guess we could compute the
TARGET_EXCEPTIONSautomatically and avoid the need to update it every time. But it would be a longer work, so for now I would just fix it manually.I agree. For example, target-generic-getty-sysvinit is still missing from the list.
I see two ways to handle that automatically:
* Have all those special targets starting with "target-" and have graph-depends exclude them automatically. Simple, but not nice if we have a real package named "target-<something>".
Quoted 8 lines
* Instead of registering all packages into the make variable called TARGETS, register them into a variable called PACKAGES, which will get appended (at the right place) to the TARGETS variable. This way, the 'show-targets' thing can be turned into a 'show-packages' that will only display the value of the PACKAGES variable. This solution is probably cleaner than the previous one.
What do you think?
The second option looks much better to me, too.
Luca
PATCH 1/2 graph-depends: ignore the 'target-generic-dont-remount-rw' target
In reply to Luca CeresoliQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Luca" == Luca Ceresoli <[email protected]> writes:
Luca> The graph-depends script tries to call 'make Luca> target-generic-dont-remount-rw', which doesn't exist since Luca> 'target-generic-dont-remount-rw' is not a package.
Luca> See also the comments for commit 72bd61e5b8c2094378.
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard