Skip to contentSkip to conversation

graph-depends: ignore the 'target-generic-dont-remount-rw' target

PATCH New Luca Ceresoli 3 participants 7 messages May 15, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 graph-depends: ignore the 'target-generic-dont-remount-rw' target

The graph-depends script tries to call 'make target-generic-dont-remount-rw', which doesn't exist since 'target-generic-dont-remount-rw' is not a package.

See also the comments for commit 72bd61e5b8c2094378.

---

I guess we could compute the TARGET_EXCEPTIONS automatically and avoid the need to update it every time. But it would be a longer work, so for now I would just fix it manually.

 support/scripts/graph-depends |    1 +
 1 file changed, 1 insertion(+)
support/scripts/graph-depends +1 -0
index 180c81d..8d81969 100755
@@ -164,6 +164,7 @@ TARGET_EXCEPTIONS = [
     "target-generic-issue",
     "target-generic-getty-busybox",
     "target-generic-do-remount-rw",
+    "target-generic-dont-remount-rw",
     "target-finalize",
     "erase-fakeroots",
     "target-generic-hostname",
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 2/2 graph-depends: fix program path in comment

---
 support/scripts/graph-depends |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/scripts/graph-depends +1 -1
index 8d81969..790e24e 100755
@@ -1,7 +1,7 @@
 #!/usr/bin/python
 
 # Usage (the graphviz package must be installed in your distribution)
-#  ./scripts/graph-depends [package-name] > test.dot
+#  ./support/scripts/graph-depends [package-name] > test.dot
 #  dot -Tpdf test.dot -o test.pdf
 #
 # With no arguments, graph-depends will draw a complete graph of
Signature · 1 line
1.7.10.4
#2 lore raw

PATCH 2/2 graph-depends: fix program path in comment

Dear Luca Ceresoli,

Quoted 4 lines · Luca Ceresoli
---
 support/scripts/graph-depends |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#4 lore raw

PATCH 1/2 graph-depends: ignore the 'target-generic-dont-remount-rw' target

In reply to Luca Ceresoli

Dear Luca Ceresoli,

Quoted 6 lines · Luca Ceresoli

The graph-depends script tries to call 'make target-generic-dont-remount-rw', which doesn't exist since 'target-generic-dont-remount-rw' is not a package.

See also the comments for commit 72bd61e5b8c2094378.

Quoted 3 lines

I guess we could compute the TARGET_EXCEPTIONS automatically and avoid the need to update it every time. But it would be a longer work, so for now I would just fix it manually.

I agree. For example, target-generic-getty-sysvinit is still missing from the list.

I see two ways to handle that automatically:

* Have all those special targets starting with "target-" and have graph-depends exclude them automatically. Simple, but not nice if we have a real package named "target-<something>".

* Instead of registering all packages into the make variable called TARGETS, register them into a variable called PACKAGES, which will get appended (at the right place) to the TARGETS variable. This way, the 'show-targets' thing can be turned into a 'show-packages' that will only display the value of the PACKAGES variable. This solution is probably cleaner than the previous one.

What do you think?

Best regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#5 lore raw

PATCH 1/2 graph-depends: ignore the 'target-generic-dont-remount-rw' target

Quoted 23 lines · Thomas Petazzoni

Dear Luca Ceresoli,

Quoted 6 lines · Luca Ceresoli

The graph-depends script tries to call 'make target-generic-dont-remount-rw', which doesn't exist since 'target-generic-dont-remount-rw' is not a package.

See also the comments for commit 72bd61e5b8c2094378.

Quoted 3 lines

I guess we could compute the TARGET_EXCEPTIONS automatically and avoid the need to update it every time. But it would be a longer work, so for now I would just fix it manually.

I agree. For example, target-generic-getty-sysvinit is still missing from the list.

I see two ways to handle that automatically:

* Have all those special targets starting with "target-" and have graph-depends exclude them automatically. Simple, but not nice if we have a real package named "target-<something>".

Quoted 8 lines

* Instead of registering all packages into the make variable called TARGETS, register them into a variable called PACKAGES, which will get appended (at the right place) to the TARGETS variable. This way, the 'show-targets' thing can be turned into a 'show-packages' that will only display the value of the PACKAGES variable. This solution is probably cleaner than the previous one.

What do you think?

The second option looks much better to me, too.

Luca

#6 lore raw

PATCH 1/2 graph-depends: ignore the 'target-generic-dont-remount-rw' target

In reply to Luca Ceresoli
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Luca" == Luca Ceresoli <[email protected]> writes:

Luca> The graph-depends script tries to call 'make Luca> target-generic-dont-remount-rw', which doesn't exist since Luca> 'target-generic-dont-remount-rw' is not a package.

Luca> See also the comments for commit 72bd61e5b8c2094378.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard