cdrom: gdrom: fix device number leak
PATCH 1/1 cdrom: gdrom: fix device number leak
without this patch, gdrom_major will leak when gd.cd_info alloc faild
Signed-off-by Libo Chen <[email protected]>
--- drivers/cdrom/gdrom.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/cdrom/gdrom.c +1 -1
@@ -830,9 +830,9 @@ probe_fail_cdrom_register:del_gendisk (gd.disk); probe_fail_no_disk:kfree (gd.cd_info); +probe_fail_no_mem:unregister_blkdev (gdrom_major,GDROM_DEV_NAME ); gdrom_major =0 ; -probe_fail_no_mem:pr_warning ("Probe failed - error is 0x%X\n" , err);return err; }
Signature · 1 line
1.7.1
Quoted 4 lines · Libo Chen
without this patch,
gdrom_majorwill leak when gd.cd_info alloc faildSigned-off-by Libo Chen <[email protected]>
Acked-by Tejun Heo <[email protected]>
This should be routed through the block tree. Can you please repost with Jens Axboe <[email protected]> added?
Thanks.
Signature · 1 line
tejun
PATCH 1/1 cdrom: gdrom: fix device number leak
In reply to Libo Chen"repost with Jens Axboe <[email protected]> added" suggest by Tejun Heo <[email protected]>
without this patch, gdrom_major will leak when gd.cd_info alloc faild
Signed-off-by Libo Chen <[email protected]>
--- drivers/cdrom/gdrom.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/cdrom/gdrom.c +1 -1
@@ -830,9 +830,9 @@ probe_fail_cdrom_register:del_gendisk (gd.disk); probe_fail_no_disk:kfree (gd.cd_info); +probe_fail_no_mem:unregister_blkdev (gdrom_major,GDROM_DEV_NAME ); gdrom_major =0 ; -probe_fail_no_mem:pr_warning ("Probe failed - error is 0x%X\n" , err);return err; }
Signature · 1 line
1.7.1