Skip to contentSkip to conversation

cdrom: gdrom: fix device number leak

PATCH In review Libo Chen 2 participants 3 messages May 17, 2013 – May 20, 2013

lore
Share & tools
lore

Libo Chen

author
#0 lore raw

PATCH 1/1 cdrom: gdrom: fix device number leak

without this patch, gdrom_major will leak when gd.cd_info alloc faild

---
 drivers/cdrom/gdrom.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/cdrom/gdrom.c +1 -1
index 4afcb65..5980cb9 100644
@@ -830,9 +830,9 @@ probe_fail_cdrom_register:
 	del_gendisk(gd.disk);
 probe_fail_no_disk:
 	kfree(gd.cd_info);
+probe_fail_no_mem:
 	unregister_blkdev(gdrom_major, GDROM_DEV_NAME);
 	gdrom_major = 0;
-probe_fail_no_mem:
 	pr_warning("Probe failed - error is 0x%X\n", err);
 	return err;
 }
Signature · 1 line
1.7.1
author
#2 lore raw

PATCH 1/1 cdrom: gdrom: fix device number leak

In reply to Libo Chen

"repost with Jens Axboe <[email protected]> added" suggest by Tejun Heo <[email protected]>

without this patch, gdrom_major will leak when gd.cd_info alloc faild

---
 drivers/cdrom/gdrom.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/cdrom/gdrom.c +1 -1
index 4afcb65..5980cb9 100644
@@ -830,9 +830,9 @@ probe_fail_cdrom_register:
 	del_gendisk(gd.disk);
 probe_fail_no_disk:
 	kfree(gd.cd_info);
+probe_fail_no_mem:
 	unregister_blkdev(gdrom_major, GDROM_DEV_NAME);
 	gdrom_major = 0;
-probe_fail_no_mem:
 	pr_warning("Probe failed - error is 0x%X\n", err);
 	return err;
 }
Signature · 1 line
1.7.1