Skip to contentSkip to conversation

arm: mvebu: enable the third USB interface on OpenBlocks AX3

PATCH New Thomas Petazzoni 5 participants 10 messages May 16, 2013 – May 20, 2013 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: mvebu: enable the third USB interface on OpenBlocks AX3

Besides the two "classic" USB interfaces with normal USB ports on the front side, the PlatHome OpenBlocks AX3 uses the third USB interface of the Marvell SoC in the mini-PCIe connector. This allows certain mini-PCIe cards to expose parts of their functionality as a USB peripheral.

This commit enables this third USB interface in the OpenBlocks AX3 Device Tree, and also adds comments on top of the two other USB interfaces so that the Device Tree makes it clear which USB interface at the SoC level matches which USB interface visible on the board.

---
 arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts |    9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts +9 -0
index f14d36c..60a79e7 100644
@@ -134,13 +134,22 @@
 				nr-ports = <2>;
 				status = "okay";
 			};
+
+			/* Front side USB 0 */
 			usb at 50000 {
 				status = "okay";
 			};
+
+			/* Front side USB 1 */
 			usb at 51000 {
 				status = "okay";
 			};
 
+			/* USB interface in the mini-PCIe connector */
+			usb at 52000 {
+				status = "okay";
+			};
+
 			devbus-bootcs at 10400 {
 				status = "okay";
 				ranges = <0 0xf0000000 0x8000000>; /* @addr 0xf000000, size 0x8000000 */
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 arm: mvebu: enable the third USB interface on OpenBlocks AX3

Dear Mr. Petazzoni

Quoted 10 lines

Besides the two "classic" USB interfaces with normal USB ports on the front side, the PlatHome OpenBlocks AX3 uses the third USB interface of the Marvell SoC in the mini-PCIe connector. This allows certain mini-PCIe cards to expose parts of their functionality as a USB peripheral.

This commit enables this third USB interface in the OpenBlocks AX3 Device Tree, and also adds comments on top of the two other USB interfaces so that the Device Tree makes it clear which USB interface at the SoC level matches which USB interface visible on the board.

I see the following messages by dmesg with your patch for linux-3.10-rc1 and 3.9.2.

...
usb 3-1: New USB device found, idVendor=0a5c, idProduct=219c usb 3-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 usb 3-1: Product: Broadcom BCM2070 Bluetooth Device
usb 3-1: Manufacturer: Broadcom Corp
usb 3-1: SerialNumber: B4749F63C1B6
...
Bluetooth: Core ver 2.16
NET: Registered protocol family 31
Bluetooth: HCI device and connection manager initialized
Bluetooth: HCI socket layer initialized
Bluetooth: L2CAP socket layer initialized
Bluetooth: SCO socket layer initialized
usbcore: registered new interface driver btusb
...

Best regards

Atsushi Yamagata
--- Atsushi Yamagata

#2 lore raw

PATCH 1/1 arm: mvebu: enable the third USB interface on OpenBlocks AX3

Hi Thomas,

Quoted 16 lines · yamagata at plathome.co.jp

Dear Mr. Petazzoni

Quoted 10 lines

Besides the two "classic" USB interfaces with normal USB ports on the front side, the PlatHome OpenBlocks AX3 uses the third USB interface of the Marvell SoC in the mini-PCIe connector. This allows certain mini-PCIe cards to expose parts of their functionality as a USB peripheral.

This commit enables this third USB interface in the OpenBlocks AX3 Device Tree, and also adds comments on top of the two other USB interfaces so that the Device Tree makes it clear which USB interface at the SoC level matches which USB interface visible on the board.

I see the following messages by dmesg with your patch for linux-3.10-rc1 and 3.9.2.

Quoted 14 lines

...
usb 3-1: New USB device found, idVendor=0a5c, idProduct=219c usb 3-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 usb 3-1: Product: Broadcom BCM2070 Bluetooth Device
usb 3-1: Manufacturer: Broadcom Corp
usb 3-1: SerialNumber: B4749F63C1B6
...
Bluetooth: Core ver 2.16
NET: Registered protocol family 31
Bluetooth: HCI device and connection manager initialized
Bluetooth: HCI socket layer initialized
Bluetooth: L2CAP socket layer initialized
Bluetooth: SCO socket layer initialized
usbcore: registered new interface driver btusb

This patch is nice and adds useful information.

I applied and tested on my OpenBlocks AX3 and get the 3rd USB interface detected. As I don't have any mini-PCIe card which use USB, I didn't tested it furthermore, but as Atsushi Yamagata managed to detect an USB device on this interface, we can be pretty confident with this patch:

Thanks,

Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#3 lore raw

PATCH 1/1 arm: mvebu: enable the third USB interface on OpenBlocks AX3

Hi Gregory,

Quoted 5 lines · Gregory CLEMENT

I applied and tested on my OpenBlocks AX3 and get the 3rd USB interface detected. As I don't have any mini-PCIe card which use USB, I didn't tested it furthermore, but as Atsushi Yamagata managed to detect an USB device on this interface, we can be pretty confident with this patch:

I do have a mini-PCIe to PCIe+USB adapter [1]. I have plugged it with a USB flash and it was correctly detected as well after I applied the patch :

usb 3-1: new high-speed USB device number 2 using orion-ehci usb 3-1: New USB device found, idVendor=0781, idProduct=5567 usb 3-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 usb 3-1: Product: Cruzer Blade
usb 3-1: Manufacturer: SanDisk

Best regards,
Willy

[1] : http://www.hwtools.net/Adapter/PM2.html

#4 lore raw

PATCH 1/1 arm: mvebu: enable the third USB interface on OpenBlocks AX3

In reply to yamagata at plathome.co.jp

Mr Yamagata, Willy,

I don't like to assume for people, so if you could please provided a "Tested-by:" I'd appreciate it.

thx,

Jason.

Quoted 41 lines · yamagata at plathome.co.jp

Dear Mr. Petazzoni

Quoted 10 lines

Besides the two "classic" USB interfaces with normal USB ports on the front side, the PlatHome OpenBlocks AX3 uses the third USB interface of the Marvell SoC in the mini-PCIe connector. This allows certain mini-PCIe cards to expose parts of their functionality as a USB peripheral.

This commit enables this third USB interface in the OpenBlocks AX3 Device Tree, and also adds comments on top of the two other USB interfaces so that the Device Tree makes it clear which USB interface at the SoC level matches which USB interface visible on the board.

I see the following messages by dmesg with your patch for linux-3.10-rc1 and 3.9.2.

...
usb 3-1: New USB device found, idVendor=0a5c, idProduct=219c usb 3-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 usb 3-1: Product: Broadcom BCM2070 Bluetooth Device
usb 3-1: Manufacturer: Broadcom Corp
usb 3-1: SerialNumber: B4749F63C1B6
...
Bluetooth: Core ver 2.16
NET: Registered protocol family 31
Bluetooth: HCI device and connection manager initialized
Bluetooth: HCI socket layer initialized
Bluetooth: L2CAP socket layer initialized
Bluetooth: SCO socket layer initialized
usbcore: registered new interface driver btusb
...

Best regards

Atsushi Yamagata
--- Atsushi Yamagata

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#5 lore raw

PATCH 1/1 arm: mvebu: enable the third USB interface on OpenBlocks AX3

Quoted 4 lines · Jason Cooper

Mr Yamagata, Willy,

I don't like to assume for people, so if you could please provided a "Tested-by:" I'd appreciate it.

Yes of course, I didn't propose it in order to save you the work of collecting these tags :-)

Best regards,
Willy

#6 lore raw

PATCH 1/1 arm: mvebu: enable the third USB interface on OpenBlocks AX3

Quoted 10 lines · Willy Tarreau
Quoted 4 lines · Jason Cooper

Mr Yamagata, Willy,

I don't like to assume for people, so if you could please provided a "Tested-by:" I'd appreciate it.

Yes of course, I didn't propose it in order to save you the work of collecting these tags :-)

Thanks!

Jason.

#8 lore raw

PATCH 1/1 arm: mvebu: enable the third USB interface on OpenBlocks AX3

Quoted 6 lines · yamagata at plathome.co.jp

Dear Mr. Jason Cooper

Quoted 2 lines

I don't like to assume for people, so if you could please provided a "Tested-by:" I'd appreciate it.

Thanks!

Jason.

#9 lore raw

PATCH 1/1 arm: mvebu: enable the third USB interface on OpenBlocks AX3

In reply to Thomas Petazzoni
Quoted 11 lines · Thomas Petazzoni

Besides the two "classic" USB interfaces with normal USB ports on the front side, the PlatHome OpenBlocks AX3 uses the third USB interface of the Marvell SoC in the mini-PCIe connector. This allows certain mini-PCIe cards to expose parts of their functionality as a USB peripheral.

This commit enables this third USB interface in the OpenBlocks AX3 Device Tree, and also adds comments on top of the two other USB interfaces so that the Device Tree makes it clear which USB interface at the SoC level matches which USB interface visible on the board.

Quoted 4 lines
---
 arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts |    9 +++++++++
 1 file changed, 9 insertions(+)

Applied to mvebu/dt with Willy's and Mr. Yamagata's Tested-by's

thx,

Jason.